Re: [PATCH v1] drivers: pinctrl: qcom: fix Kconfig dependency on GPIOLIB
On Thu 08 Apr 03:03 CDT 2021, Linus Walleij wrote: > On Mon, Mar 29, 2021 at 6:41 PM Julian Braha wrote: > > > > On Tuesday, March 2, 2021 9:46:04 AM EDT you wrote: > > > On Thu, Feb 25, 2021 at 9:33 AM Julian Braha > > > wrote: > > > > > > > When PINCTRL_MSM is enabled, and GPIOLIB is disabled, > > > > Kbuild gives the following warning: > > > > > > > > WARNING: unmet direct dependencies detected for GPIOLIB_IRQCHIP > > > > Depends on [n]: GPIOLIB [=n] > > > > Selected by [y]: > > > > - PINCTRL_MSM [=y] && PINCTRL [=y] && (ARCH_QCOM || COMPILE_TEST [=y]) > > > > > > > > This is because PINCTRL_MSM selects GPIOLIB_IRQCHIP, > > > > without selecting or depending on GPIOLIB, despite > > > > GPIOLIB_IRQCHIP depending on GPIOLIB. Having PINCTRL_MSM > > > > select GPIOLIB will cause a recursive dependency error. > > > > > > > > Signed-off-by: Julian Braha > > > > > > Does it work to just: > > > > > > select GPIOLIB > > > > > > instead? > > > > > > The driver needs the library so... > > > > > > Yours, > > > Linus Walleij > > > > > > > Hi Linus, > > > > Looks like I confused this patch with another one when > > I responded last time. This config option cannot select > > GPIOLIB, because it will cause a recursive dependency > > error. > > > > Any other ideas? > > No we can apply the patch as-is but let Bjorn have a look at it first, > I noticed he is not on the To: line of the original patch. > > You may need to resend with Bjorn Andersson in the recipients. > I don't see a resend of this, perhaps I'm just not good at searching today...I dug up the patch on lore instead. GPIOLIB is user selectable, so it makes sense to depend on it, rather than use select. And it seems like our current defconfigs have GPIOLIB enabled already (directly or indirectly). So... Reviewed-by: Bjorn Andersson Regards, Bjorn
Re: [PATCH v1] drivers: pinctrl: qcom: fix Kconfig dependency on GPIOLIB
On Mon, Mar 29, 2021 at 6:41 PM Julian Braha wrote: > > On Tuesday, March 2, 2021 9:46:04 AM EDT you wrote: > > On Thu, Feb 25, 2021 at 9:33 AM Julian Braha wrote: > > > > > When PINCTRL_MSM is enabled, and GPIOLIB is disabled, > > > Kbuild gives the following warning: > > > > > > WARNING: unmet direct dependencies detected for GPIOLIB_IRQCHIP > > > Depends on [n]: GPIOLIB [=n] > > > Selected by [y]: > > > - PINCTRL_MSM [=y] && PINCTRL [=y] && (ARCH_QCOM || COMPILE_TEST [=y]) > > > > > > This is because PINCTRL_MSM selects GPIOLIB_IRQCHIP, > > > without selecting or depending on GPIOLIB, despite > > > GPIOLIB_IRQCHIP depending on GPIOLIB. Having PINCTRL_MSM > > > select GPIOLIB will cause a recursive dependency error. > > > > > > Signed-off-by: Julian Braha > > > > Does it work to just: > > > > select GPIOLIB > > > > instead? > > > > The driver needs the library so... > > > > Yours, > > Linus Walleij > > > > Hi Linus, > > Looks like I confused this patch with another one when > I responded last time. This config option cannot select > GPIOLIB, because it will cause a recursive dependency > error. > > Any other ideas? No we can apply the patch as-is but let Bjorn have a look at it first, I noticed he is not on the To: line of the original patch. You may need to resend with Bjorn Andersson in the recipients. Yours, Linus Walleij
Re: [PATCH v1] drivers: pinctrl: qcom: fix Kconfig dependency on GPIOLIB
On Tuesday, March 2, 2021 9:46:04 AM EDT you wrote: > On Thu, Feb 25, 2021 at 9:33 AM Julian Braha wrote: > > > When PINCTRL_MSM is enabled, and GPIOLIB is disabled, > > Kbuild gives the following warning: > > > > WARNING: unmet direct dependencies detected for GPIOLIB_IRQCHIP > > Depends on [n]: GPIOLIB [=n] > > Selected by [y]: > > - PINCTRL_MSM [=y] && PINCTRL [=y] && (ARCH_QCOM || COMPILE_TEST [=y]) > > > > This is because PINCTRL_MSM selects GPIOLIB_IRQCHIP, > > without selecting or depending on GPIOLIB, despite > > GPIOLIB_IRQCHIP depending on GPIOLIB. Having PINCTRL_MSM > > select GPIOLIB will cause a recursive dependency error. > > > > Signed-off-by: Julian Braha > > Does it work to just: > > select GPIOLIB > > instead? > > The driver needs the library so... > > Yours, > Linus Walleij > Hi Linus, Looks like I confused this patch with another one when I responded last time. This config option cannot select GPIOLIB, because it will cause a recursive dependency error. Any other ideas? - Julian Braha
Re: [PATCH v1] drivers: pinctrl: qcom: fix Kconfig dependency on GPIOLIB
On Thu, Feb 25, 2021 at 9:33 AM Julian Braha wrote: > When PINCTRL_MSM is enabled, and GPIOLIB is disabled, > Kbuild gives the following warning: > > WARNING: unmet direct dependencies detected for GPIOLIB_IRQCHIP > Depends on [n]: GPIOLIB [=n] > Selected by [y]: > - PINCTRL_MSM [=y] && PINCTRL [=y] && (ARCH_QCOM || COMPILE_TEST [=y]) > > This is because PINCTRL_MSM selects GPIOLIB_IRQCHIP, > without selecting or depending on GPIOLIB, despite > GPIOLIB_IRQCHIP depending on GPIOLIB. Having PINCTRL_MSM > select GPIOLIB will cause a recursive dependency error. > > Signed-off-by: Julian Braha Does it work to just: select GPIOLIB instead? The driver needs the library so... Yours, Linus Walleij
[PATCH v1] drivers: pinctrl: qcom: fix Kconfig dependency on GPIOLIB
When PINCTRL_MSM is enabled, and GPIOLIB is disabled, Kbuild gives the following warning: WARNING: unmet direct dependencies detected for GPIOLIB_IRQCHIP Depends on [n]: GPIOLIB [=n] Selected by [y]: - PINCTRL_MSM [=y] && PINCTRL [=y] && (ARCH_QCOM || COMPILE_TEST [=y]) This is because PINCTRL_MSM selects GPIOLIB_IRQCHIP, without selecting or depending on GPIOLIB, despite GPIOLIB_IRQCHIP depending on GPIOLIB. Having PINCTRL_MSM select GPIOLIB will cause a recursive dependency error. Signed-off-by: Julian Braha --- drivers/pinctrl/qcom/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/qcom/Kconfig b/drivers/pinctrl/qcom/Kconfig index 6853a896c476..d42ac59875ab 100644 --- a/drivers/pinctrl/qcom/Kconfig +++ b/drivers/pinctrl/qcom/Kconfig @@ -3,7 +3,7 @@ if (ARCH_QCOM || COMPILE_TEST) config PINCTRL_MSM tristate "Qualcomm core pin controller driver" - depends on QCOM_SCM || !QCOM_SCM #if QCOM_SCM=m this can't be =y + depends on GPIOLIB && (QCOM_SCM || !QCOM_SCM) #if QCOM_SCM=m this can't be =y select PINMUX select PINCONF select GENERIC_PINCONF -- 2.27.0
