Re: [PATCH v1] mm: balloon: drop unused function stubs

2019-04-02 Thread Rafael Aquini 
On Fri, Mar 29, 2019 at 01:26:49PM +0100, David Hildenbrand wrote:
> These are leftovers from the pre-"general non-lru movable page" era.
> 
> Signed-off-by: David Hildenbrand 
> ---
>  include/linux/balloon_compaction.h | 15 ---
>  1 file changed, 15 deletions(-)
> 
> diff --git a/include/linux/balloon_compaction.h 
> b/include/linux/balloon_compaction.h
> index f111c780ef1d..f31521dcb09a 100644
> --- a/include/linux/balloon_compaction.h
> +++ b/include/linux/balloon_compaction.h
> @@ -151,21 +151,6 @@ static inline void balloon_page_delete(struct page *page)
>   list_del(>lru);
>  }
>  
> -static inline bool __is_movable_balloon_page(struct page *page)
> -{
> - return false;
> -}
> -
> -static inline bool balloon_page_movable(struct page *page)
> -{
> - return false;
> -}
> -
> -static inline bool isolated_balloon_page(struct page *page)
> -{
> - return false;
> -}
> -
>  static inline bool balloon_page_isolate(struct page *page)
>  {
>   return false;
> -- 
> 2.17.2
> 
Acked-by: Rafael Aquini

Re: [PATCH v1] mm: balloon: drop unused function stubs

2019-04-01 Thread Pankaj Gupta 


> 
> These are leftovers from the pre-"general non-lru movable page" era.
> 
> Signed-off-by: David Hildenbrand 
> ---
>  include/linux/balloon_compaction.h | 15 ---
>  1 file changed, 15 deletions(-)
> 
> diff --git a/include/linux/balloon_compaction.h
> b/include/linux/balloon_compaction.h
> index f111c780ef1d..f31521dcb09a 100644
> --- a/include/linux/balloon_compaction.h
> +++ b/include/linux/balloon_compaction.h
> @@ -151,21 +151,6 @@ static inline void balloon_page_delete(struct page
> *page)
>   list_del(>lru);
>  }
>  
> -static inline bool __is_movable_balloon_page(struct page *page)
> -{
> - return false;
> -}
> -
> -static inline bool balloon_page_movable(struct page *page)
> -{
> - return false;
> -}
> -
> -static inline bool isolated_balloon_page(struct page *page)
> -{
> - return false;
> -}
> -
>  static inline bool balloon_page_isolate(struct page *page)
>  {
>   return false;
> --
> 2.17.2

Looks good to me.

Acked-by: Pankaj Gupta 

> 
>

Re: [PATCH v1] mm: balloon: drop unused function stubs

2019-03-29 Thread Michael S. Tsirkin 
On Fri, Mar 29, 2019 at 01:26:49PM +0100, David Hildenbrand wrote:
> These are leftovers from the pre-"general non-lru movable page" era.
> 
> Signed-off-by: David Hildenbrand 

Acked-by: Michael S. Tsirkin 

> ---
>  include/linux/balloon_compaction.h | 15 ---
>  1 file changed, 15 deletions(-)
> 
> diff --git a/include/linux/balloon_compaction.h 
> b/include/linux/balloon_compaction.h
> index f111c780ef1d..f31521dcb09a 100644
> --- a/include/linux/balloon_compaction.h
> +++ b/include/linux/balloon_compaction.h
> @@ -151,21 +151,6 @@ static inline void balloon_page_delete(struct page *page)
>   list_del(>lru);
>  }
>  
> -static inline bool __is_movable_balloon_page(struct page *page)
> -{
> - return false;
> -}
> -
> -static inline bool balloon_page_movable(struct page *page)
> -{
> - return false;
> -}
> -
> -static inline bool isolated_balloon_page(struct page *page)
> -{
> - return false;
> -}
> -
>  static inline bool balloon_page_isolate(struct page *page)
>  {
>   return false;
> -- 
> 2.17.2

Re: [PATCH v1] mm: balloon: drop unused function stubs

2019-03-29 Thread Mukesh Ojha 



On 3/29/2019 5:56 PM, David Hildenbrand wrote:

These are leftovers from the pre-"general non-lru movable page" era.

Signed-off-by: David Hildenbrand 
---
  include/linux/balloon_compaction.h | 15 ---
  1 file changed, 15 deletions(-)



Reviewed-by: Mukesh Ojha 

Cheers,
-Mukesh



diff --git a/include/linux/balloon_compaction.h 
b/include/linux/balloon_compaction.h
index f111c780ef1d..f31521dcb09a 100644
--- a/include/linux/balloon_compaction.h
+++ b/include/linux/balloon_compaction.h
@@ -151,21 +151,6 @@ static inline void balloon_page_delete(struct page *page)
list_del(>lru);
  }
  
-static inline bool __is_movable_balloon_page(struct page *page)

-{
-   return false;
-}
-
-static inline bool balloon_page_movable(struct page *page)
-{
-   return false;
-}
-
-static inline bool isolated_balloon_page(struct page *page)
-{
-   return false;
-}
-
  static inline bool balloon_page_isolate(struct page *page)
  {
return false;

[PATCH v1] mm: balloon: drop unused function stubs

2019-03-29 Thread David Hildenbrand 
These are leftovers from the pre-"general non-lru movable page" era.

Signed-off-by: David Hildenbrand 
---
 include/linux/balloon_compaction.h | 15 ---
 1 file changed, 15 deletions(-)

diff --git a/include/linux/balloon_compaction.h 
b/include/linux/balloon_compaction.h
index f111c780ef1d..f31521dcb09a 100644
--- a/include/linux/balloon_compaction.h
+++ b/include/linux/balloon_compaction.h
@@ -151,21 +151,6 @@ static inline void balloon_page_delete(struct page *page)
list_del(>lru);
 }
 
-static inline bool __is_movable_balloon_page(struct page *page)
-{
-   return false;
-}
-
-static inline bool balloon_page_movable(struct page *page)
-{
-   return false;
-}
-
-static inline bool isolated_balloon_page(struct page *page)
-{
-   return false;
-}
-
 static inline bool balloon_page_isolate(struct page *page)
 {
return false;
-- 
2.17.2