[PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-20 Thread Gaurav Pathak 
staging: rts5208: Fix coding style issue caught by checkpatch.pl related to
function name in debug print

Signed-off-by: Gaurav Pathak 
---
 drivers/staging/rts5208/ms.c|  5 +++--
 drivers/staging/rts5208/rtsx.c  |  4 ++--
 drivers/staging/rts5208/rtsx_chip.c |  4 ++--
 drivers/staging/rts5208/sd.c| 21 +++--
 drivers/staging/rts5208/spi.c   |  8 +---
 drivers/staging/rts5208/xd.c| 17 ++---
 6 files changed, 33 insertions(+), 26 deletions(-)

diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c
index 482a29d..7cdce87 100644
--- a/drivers/staging/rts5208/ms.c
+++ b/drivers/staging/rts5208/ms.c
@@ -3064,7 +3064,8 @@ static int mspro_rw_multi_sector(struct scsi_cmnd *srb,
 
if (detect_card_cd(chip, MS_CARD) != STATUS_SUCCESS) {
chip->rw_need_retry = 0;
-   dev_dbg(rtsx_dev(chip), "No card exist, exit 
mspro_rw_multi_sector\n");
+   dev_dbg(rtsx_dev(chip), "No card exist, exit %s\n",
+   __func__);
rtsx_trace(chip);
return STATUS_FAIL;
}
@@ -3101,7 +3102,7 @@ static int mspro_read_format_progress(struct rtsx_chip 
*chip,
u8 cnt, tmp;
u8 data[8];
 
-   dev_dbg(rtsx_dev(chip), "mspro_read_format_progress, short_data_len = 
%d\n",
+   dev_dbg(rtsx_dev(chip), "%s, short_data_len = %d\n", __func__,
short_data_len);
 
retval = ms_switch_clock(chip);
diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index b8177f5..53748d6 100644
--- a/drivers/staging/rts5208/rtsx.c
+++ b/drivers/staging/rts5208/rtsx.c
@@ -999,7 +999,7 @@ static int rtsx_probe(struct pci_dev *pci,
 
/* We come here if there are any problems */
 errout:
-   dev_err(>dev, "rtsx_probe() failed\n");
+   dev_err(>dev, "%s failed\n", __func__);
release_everything(dev);
 
return err;
@@ -1009,7 +1009,7 @@ static void rtsx_remove(struct pci_dev *pci)
 {
struct rtsx_dev *dev = pci_get_drvdata(pci);
 
-   dev_info(>dev, "rtsx_remove() called\n");
+   dev_info(>dev, "%s called\n", __func__);
 
quiesce_and_remove_host(dev);
release_everything(dev);
diff --git a/drivers/staging/rts5208/rtsx_chip.c 
b/drivers/staging/rts5208/rtsx_chip.c
index 7f4107b..4ad472d 100644
--- a/drivers/staging/rts5208/rtsx_chip.c
+++ b/drivers/staging/rts5208/rtsx_chip.c
@@ -616,8 +616,8 @@ int rtsx_reset_chip(struct rtsx_chip *chip)
else
retval = rtsx_pre_handle_sdio_new(chip);
 
-   dev_dbg(rtsx_dev(chip), "chip->need_reset = 0x%x 
(rtsx_reset_chip)\n",
-   (unsigned int)(chip->need_reset));
+   dev_dbg(rtsx_dev(chip), "chip->need_reset = 0x%x (%s)\n",
+   (unsigned int)(chip->need_reset), __func__);
 #else  /* HW_AUTO_SWITCH_SD_BUS */
retval = rtsx_pre_handle_sdio_old(chip);
 #endif  /* HW_AUTO_SWITCH_SD_BUS */
diff --git a/drivers/staging/rts5208/sd.c b/drivers/staging/rts5208/sd.c
index c2eb072..b1fd0a1 100644
--- a/drivers/staging/rts5208/sd.c
+++ b/drivers/staging/rts5208/sd.c
@@ -910,8 +910,8 @@ static int sd_change_phase(struct rtsx_chip *chip, u8 
sample_point, u8 tune_dir)
int retval;
bool ddr_rx = false;
 
-   dev_dbg(rtsx_dev(chip), "sd_change_phase (sample_point = %d, tune_dir = 
%d)\n",
-   sample_point, tune_dir);
+   dev_dbg(rtsx_dev(chip), "%s (sample_point = %d, tune_dir = %d)\n",
+   __func__, sample_point, tune_dir);
 
if (tune_dir == TUNE_RX) {
SD_VP_CTL = SD_VPRX_CTL;
@@ -1225,8 +1225,8 @@ static int sd_check_switch_mode(struct rtsx_chip *chip, 
u8 mode, u8 func_group,
int retval;
u8 cmd[5], buf[64];
 
-   dev_dbg(rtsx_dev(chip), "sd_check_switch_mode (mode = %d, func_group = 
%d, func_to_switch = %d)\n",
-   mode, func_group, func_to_switch);
+   dev_dbg(rtsx_dev(chip), "%s (mode = %d, func_group = %d, func_to_switch 
= %d)\n",
+   __func__, mode, func_group, func_to_switch);
 
cmd[0] = 0x40 | SWITCH;
cmd[1] = mode;
@@ -3575,8 +3575,8 @@ static int reset_mmc_only(struct rtsx_chip *chip)
return STATUS_FAIL;
}
 
-   dev_dbg(rtsx_dev(chip), "In reset_mmc_only, sd_card->sd_type = 0x%x\n",
-   sd_card->sd_type);
+   dev_dbg(rtsx_dev(chip), "In %s, sd_card->sd_type = 0x%x\n",
+   __func__, sd_card->sd_type);
 
return STATUS_SUCCESS;
 }
@@ -3699,11 +3699,11 @@ int sd_rw(struct scsi_cmnd *srb, struct rtsx_chip 
*chip, u32 start_sector,
int retval;
 
if (srb->sc_data_direction == DMA_FROM_DEVICE) {
-   dev_dbg(rtsx_dev(chip), "sd_rw: Read %d %s from 0x%x\n",
+   dev_dbg(rtsx_dev(chip), "%s: Read %d %s from

[PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-20 Thread Gaurav Pathak 
staging: rts5208: Fix coding style issue caught by checkpatch.pl related to
function name in debug print

Signed-off-by: Gaurav Pathak 
---
 drivers/staging/rts5208/ms.c|  5 +++--
 drivers/staging/rts5208/rtsx.c  |  4 ++--
 drivers/staging/rts5208/rtsx_chip.c |  4 ++--
 drivers/staging/rts5208/sd.c| 21 +++--
 drivers/staging/rts5208/spi.c   |  8 +---
 drivers/staging/rts5208/xd.c| 17 ++---
 6 files changed, 33 insertions(+), 26 deletions(-)

diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c
index 482a29d..7cdce87 100644
--- a/drivers/staging/rts5208/ms.c
+++ b/drivers/staging/rts5208/ms.c
@@ -3064,7 +3064,8 @@ static int mspro_rw_multi_sector(struct scsi_cmnd *srb,
 
if (detect_card_cd(chip, MS_CARD) != STATUS_SUCCESS) {
chip->rw_need_retry = 0;
-   dev_dbg(rtsx_dev(chip), "No card exist, exit 
mspro_rw_multi_sector\n");
+   dev_dbg(rtsx_dev(chip), "No card exist, exit %s\n",
+   __func__);
rtsx_trace(chip);
return STATUS_FAIL;
}
@@ -3101,7 +3102,7 @@ static int mspro_read_format_progress(struct rtsx_chip 
*chip,
u8 cnt, tmp;
u8 data[8];
 
-   dev_dbg(rtsx_dev(chip), "mspro_read_format_progress, short_data_len = 
%d\n",
+   dev_dbg(rtsx_dev(chip), "%s, short_data_len = %d\n", __func__,
short_data_len);
 
retval = ms_switch_clock(chip);
diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index b8177f5..53748d6 100644
--- a/drivers/staging/rts5208/rtsx.c
+++ b/drivers/staging/rts5208/rtsx.c
@@ -999,7 +999,7 @@ static int rtsx_probe(struct pci_dev *pci,
 
/* We come here if there are any problems */
 errout:
-   dev_err(>dev, "rtsx_probe() failed\n");
+   dev_err(>dev, "%s failed\n", __func__);
release_everything(dev);
 
return err;
@@ -1009,7 +1009,7 @@ static void rtsx_remove(struct pci_dev *pci)
 {
struct rtsx_dev *dev = pci_get_drvdata(pci);
 
-   dev_info(>dev, "rtsx_remove() called\n");
+   dev_info(>dev, "%s called\n", __func__);
 
quiesce_and_remove_host(dev);
release_everything(dev);
diff --git a/drivers/staging/rts5208/rtsx_chip.c 
b/drivers/staging/rts5208/rtsx_chip.c
index 7f4107b..4ad472d 100644
--- a/drivers/staging/rts5208/rtsx_chip.c
+++ b/drivers/staging/rts5208/rtsx_chip.c
@@ -616,8 +616,8 @@ int rtsx_reset_chip(struct rtsx_chip *chip)
else
retval = rtsx_pre_handle_sdio_new(chip);
 
-   dev_dbg(rtsx_dev(chip), "chip->need_reset = 0x%x 
(rtsx_reset_chip)\n",
-   (unsigned int)(chip->need_reset));
+   dev_dbg(rtsx_dev(chip), "chip->need_reset = 0x%x (%s)\n",
+   (unsigned int)(chip->need_reset), __func__);
 #else  /* HW_AUTO_SWITCH_SD_BUS */
retval = rtsx_pre_handle_sdio_old(chip);
 #endif  /* HW_AUTO_SWITCH_SD_BUS */
diff --git a/drivers/staging/rts5208/sd.c b/drivers/staging/rts5208/sd.c
index c2eb072..b1fd0a1 100644
--- a/drivers/staging/rts5208/sd.c
+++ b/drivers/staging/rts5208/sd.c
@@ -910,8 +910,8 @@ static int sd_change_phase(struct rtsx_chip *chip, u8 
sample_point, u8 tune_dir)
int retval;
bool ddr_rx = false;
 
-   dev_dbg(rtsx_dev(chip), "sd_change_phase (sample_point = %d, tune_dir = 
%d)\n",
-   sample_point, tune_dir);
+   dev_dbg(rtsx_dev(chip), "%s (sample_point = %d, tune_dir = %d)\n",
+   __func__, sample_point, tune_dir);
 
if (tune_dir == TUNE_RX) {
SD_VP_CTL = SD_VPRX_CTL;
@@ -1225,8 +1225,8 @@ static int sd_check_switch_mode(struct rtsx_chip *chip, 
u8 mode, u8 func_group,
int retval;
u8 cmd[5], buf[64];
 
-   dev_dbg(rtsx_dev(chip), "sd_check_switch_mode (mode = %d, func_group = 
%d, func_to_switch = %d)\n",
-   mode, func_group, func_to_switch);
+   dev_dbg(rtsx_dev(chip), "%s (mode = %d, func_group = %d, func_to_switch 
= %d)\n",
+   __func__, mode, func_group, func_to_switch);
 
cmd[0] = 0x40 | SWITCH;
cmd[1] = mode;
@@ -3575,8 +3575,8 @@ static int reset_mmc_only(struct rtsx_chip *chip)
return STATUS_FAIL;
}
 
-   dev_dbg(rtsx_dev(chip), "In reset_mmc_only, sd_card->sd_type = 0x%x\n",
-   sd_card->sd_type);
+   dev_dbg(rtsx_dev(chip), "In %s, sd_card->sd_type = 0x%x\n",
+   __func__, sd_card->sd_type);
 
return STATUS_SUCCESS;
 }
@@ -3699,11 +3699,11 @@ int sd_rw(struct scsi_cmnd *srb, struct rtsx_chip 
*chip, u32 start_sector,
int retval;
 
if (srb->sc_data_direction == DMA_FROM_DEVICE) {
-   dev_dbg(rtsx_dev(chip), "sd_rw: Read %d %s from 0x%x\n",
+   dev_dbg(rtsx_dev(chip), "%s: Read %d %s from 0x%x\n", __func__,

Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-18 Thread Greg KH 
On Mon, Jul 17, 2017 at 08:19:45PM +0530, Gaurav Pathak wrote:
> staging: rts5208: Fix coding style issue caught by checkpatch.pl related to
> function name in debug print and shorten few lines over 80 char

No, only do one-type-of-thing per patch.  It would make sense to maybe
fix an 80 char line issue for a line you are fixing up for the function
name, but not for any other random line.

Please break this up into individual patches.

thanks,

greg k-h

Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-18 Thread Greg KH 
On Mon, Jul 17, 2017 at 08:19:45PM +0530, Gaurav Pathak wrote:
> staging: rts5208: Fix coding style issue caught by checkpatch.pl related to
> function name in debug print and shorten few lines over 80 char

No, only do one-type-of-thing per patch.  It would make sense to maybe
fix an 80 char line issue for a line you are fixing up for the function
name, but not for any other random line.

Please break this up into individual patches.

thanks,

greg k-h

[PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-17 Thread Gaurav Pathak 
staging: rts5208: Fix coding style issue caught by checkpatch.pl related to
function name in debug print and shorten few lines over 80 char

Signed-off-by: Gaurav Pathak 
---
 drivers/staging/rts5208/ms.c|  5 +++--
 drivers/staging/rts5208/rtsx.c  |  4 ++--
 drivers/staging/rts5208/rtsx_chip.c |  4 ++--
 drivers/staging/rts5208/sd.c| 28 +++-
 drivers/staging/rts5208/spi.c   |  8 +---
 drivers/staging/rts5208/xd.c| 17 ++---
 6 files changed, 37 insertions(+), 29 deletions(-)

diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c
index 482a29d..7cdce87 100644
--- a/drivers/staging/rts5208/ms.c
+++ b/drivers/staging/rts5208/ms.c
@@ -3064,7 +3064,8 @@ static int mspro_rw_multi_sector(struct scsi_cmnd *srb,
 
if (detect_card_cd(chip, MS_CARD) != STATUS_SUCCESS) {
chip->rw_need_retry = 0;
-   dev_dbg(rtsx_dev(chip), "No card exist, exit 
mspro_rw_multi_sector\n");
+   dev_dbg(rtsx_dev(chip), "No card exist, exit %s\n",
+   __func__);
rtsx_trace(chip);
return STATUS_FAIL;
}
@@ -3101,7 +3102,7 @@ static int mspro_read_format_progress(struct rtsx_chip 
*chip,
u8 cnt, tmp;
u8 data[8];
 
-   dev_dbg(rtsx_dev(chip), "mspro_read_format_progress, short_data_len = 
%d\n",
+   dev_dbg(rtsx_dev(chip), "%s, short_data_len = %d\n", __func__,
short_data_len);
 
retval = ms_switch_clock(chip);
diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index b8177f5..53748d6 100644
--- a/drivers/staging/rts5208/rtsx.c
+++ b/drivers/staging/rts5208/rtsx.c
@@ -999,7 +999,7 @@ static int rtsx_probe(struct pci_dev *pci,
 
/* We come here if there are any problems */
 errout:
-   dev_err(>dev, "rtsx_probe() failed\n");
+   dev_err(>dev, "%s failed\n", __func__);
release_everything(dev);
 
return err;
@@ -1009,7 +1009,7 @@ static void rtsx_remove(struct pci_dev *pci)
 {
struct rtsx_dev *dev = pci_get_drvdata(pci);
 
-   dev_info(>dev, "rtsx_remove() called\n");
+   dev_info(>dev, "%s called\n", __func__);
 
quiesce_and_remove_host(dev);
release_everything(dev);
diff --git a/drivers/staging/rts5208/rtsx_chip.c 
b/drivers/staging/rts5208/rtsx_chip.c
index 7f4107b..4ad472d 100644
--- a/drivers/staging/rts5208/rtsx_chip.c
+++ b/drivers/staging/rts5208/rtsx_chip.c
@@ -616,8 +616,8 @@ int rtsx_reset_chip(struct rtsx_chip *chip)
else
retval = rtsx_pre_handle_sdio_new(chip);
 
-   dev_dbg(rtsx_dev(chip), "chip->need_reset = 0x%x 
(rtsx_reset_chip)\n",
-   (unsigned int)(chip->need_reset));
+   dev_dbg(rtsx_dev(chip), "chip->need_reset = 0x%x (%s)\n",
+   (unsigned int)(chip->need_reset), __func__);
 #else  /* HW_AUTO_SWITCH_SD_BUS */
retval = rtsx_pre_handle_sdio_old(chip);
 #endif  /* HW_AUTO_SWITCH_SD_BUS */
diff --git a/drivers/staging/rts5208/sd.c b/drivers/staging/rts5208/sd.c
index c2eb072..e2b1fa03 100644
--- a/drivers/staging/rts5208/sd.c
+++ b/drivers/staging/rts5208/sd.c
@@ -910,8 +910,8 @@ static int sd_change_phase(struct rtsx_chip *chip, u8 
sample_point, u8 tune_dir)
int retval;
bool ddr_rx = false;
 
-   dev_dbg(rtsx_dev(chip), "sd_change_phase (sample_point = %d, tune_dir = 
%d)\n",
-   sample_point, tune_dir);
+   dev_dbg(rtsx_dev(chip), "%s (sample_point = %d, tune_dir = %d)\n",
+   __func__, sample_point, tune_dir);
 
if (tune_dir == TUNE_RX) {
SD_VP_CTL = SD_VPRX_CTL;
@@ -1225,8 +1225,9 @@ static int sd_check_switch_mode(struct rtsx_chip *chip, 
u8 mode, u8 func_group,
int retval;
u8 cmd[5], buf[64];
 
-   dev_dbg(rtsx_dev(chip), "sd_check_switch_mode (mode = %d, func_group = 
%d, func_to_switch = %d)\n",
-   mode, func_group, func_to_switch);
+   dev_dbg(rtsx_dev(chip), "%s ", __func__);
+   dev_dbg(rtsx_dev(chip), "mode = %d, func_group = %d,", mode, 
func_group);
+   dev_dbg(rtsx_dev(chip), "func_to_switch = %d)\n", func_to_switch);
 
cmd[0] = 0x40 | SWITCH;
cmd[1] = mode;
@@ -3575,7 +3576,7 @@ static int reset_mmc_only(struct rtsx_chip *chip)
return STATUS_FAIL;
}
 
-   dev_dbg(rtsx_dev(chip), "In reset_mmc_only, sd_card->sd_type = 0x%x\n",
+   dev_dbg(rtsx_dev(chip), "In %s, sd_card->sd_type = 0x%x\n", __func__,
sd_card->sd_type);
 
return STATUS_SUCCESS;
@@ -3699,11 +3700,11 @@ int sd_rw(struct scsi_cmnd *srb, struct rtsx_chip 
*chip, u32 start_sector,
int retval;
 
if (srb->sc_data_direction == DMA_FROM_DEVICE) {
-   dev_dbg(rtsx_dev(chip), "sd_rw: Read %d %s from 0x%x\n",

[PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-17 Thread Gaurav Pathak 
staging: rts5208: Fix coding style issue caught by checkpatch.pl related to
function name in debug print and shorten few lines over 80 char

Signed-off-by: Gaurav Pathak 
---
 drivers/staging/rts5208/ms.c|  5 +++--
 drivers/staging/rts5208/rtsx.c  |  4 ++--
 drivers/staging/rts5208/rtsx_chip.c |  4 ++--
 drivers/staging/rts5208/sd.c| 28 +++-
 drivers/staging/rts5208/spi.c   |  8 +---
 drivers/staging/rts5208/xd.c| 17 ++---
 6 files changed, 37 insertions(+), 29 deletions(-)

diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c
index 482a29d..7cdce87 100644
--- a/drivers/staging/rts5208/ms.c
+++ b/drivers/staging/rts5208/ms.c
@@ -3064,7 +3064,8 @@ static int mspro_rw_multi_sector(struct scsi_cmnd *srb,
 
if (detect_card_cd(chip, MS_CARD) != STATUS_SUCCESS) {
chip->rw_need_retry = 0;
-   dev_dbg(rtsx_dev(chip), "No card exist, exit 
mspro_rw_multi_sector\n");
+   dev_dbg(rtsx_dev(chip), "No card exist, exit %s\n",
+   __func__);
rtsx_trace(chip);
return STATUS_FAIL;
}
@@ -3101,7 +3102,7 @@ static int mspro_read_format_progress(struct rtsx_chip 
*chip,
u8 cnt, tmp;
u8 data[8];
 
-   dev_dbg(rtsx_dev(chip), "mspro_read_format_progress, short_data_len = 
%d\n",
+   dev_dbg(rtsx_dev(chip), "%s, short_data_len = %d\n", __func__,
short_data_len);
 
retval = ms_switch_clock(chip);
diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index b8177f5..53748d6 100644
--- a/drivers/staging/rts5208/rtsx.c
+++ b/drivers/staging/rts5208/rtsx.c
@@ -999,7 +999,7 @@ static int rtsx_probe(struct pci_dev *pci,
 
/* We come here if there are any problems */
 errout:
-   dev_err(>dev, "rtsx_probe() failed\n");
+   dev_err(>dev, "%s failed\n", __func__);
release_everything(dev);
 
return err;
@@ -1009,7 +1009,7 @@ static void rtsx_remove(struct pci_dev *pci)
 {
struct rtsx_dev *dev = pci_get_drvdata(pci);
 
-   dev_info(>dev, "rtsx_remove() called\n");
+   dev_info(>dev, "%s called\n", __func__);
 
quiesce_and_remove_host(dev);
release_everything(dev);
diff --git a/drivers/staging/rts5208/rtsx_chip.c 
b/drivers/staging/rts5208/rtsx_chip.c
index 7f4107b..4ad472d 100644
--- a/drivers/staging/rts5208/rtsx_chip.c
+++ b/drivers/staging/rts5208/rtsx_chip.c
@@ -616,8 +616,8 @@ int rtsx_reset_chip(struct rtsx_chip *chip)
else
retval = rtsx_pre_handle_sdio_new(chip);
 
-   dev_dbg(rtsx_dev(chip), "chip->need_reset = 0x%x 
(rtsx_reset_chip)\n",
-   (unsigned int)(chip->need_reset));
+   dev_dbg(rtsx_dev(chip), "chip->need_reset = 0x%x (%s)\n",
+   (unsigned int)(chip->need_reset), __func__);
 #else  /* HW_AUTO_SWITCH_SD_BUS */
retval = rtsx_pre_handle_sdio_old(chip);
 #endif  /* HW_AUTO_SWITCH_SD_BUS */
diff --git a/drivers/staging/rts5208/sd.c b/drivers/staging/rts5208/sd.c
index c2eb072..e2b1fa03 100644
--- a/drivers/staging/rts5208/sd.c
+++ b/drivers/staging/rts5208/sd.c
@@ -910,8 +910,8 @@ static int sd_change_phase(struct rtsx_chip *chip, u8 
sample_point, u8 tune_dir)
int retval;
bool ddr_rx = false;
 
-   dev_dbg(rtsx_dev(chip), "sd_change_phase (sample_point = %d, tune_dir = 
%d)\n",
-   sample_point, tune_dir);
+   dev_dbg(rtsx_dev(chip), "%s (sample_point = %d, tune_dir = %d)\n",
+   __func__, sample_point, tune_dir);
 
if (tune_dir == TUNE_RX) {
SD_VP_CTL = SD_VPRX_CTL;
@@ -1225,8 +1225,9 @@ static int sd_check_switch_mode(struct rtsx_chip *chip, 
u8 mode, u8 func_group,
int retval;
u8 cmd[5], buf[64];
 
-   dev_dbg(rtsx_dev(chip), "sd_check_switch_mode (mode = %d, func_group = 
%d, func_to_switch = %d)\n",
-   mode, func_group, func_to_switch);
+   dev_dbg(rtsx_dev(chip), "%s ", __func__);
+   dev_dbg(rtsx_dev(chip), "mode = %d, func_group = %d,", mode, 
func_group);
+   dev_dbg(rtsx_dev(chip), "func_to_switch = %d)\n", func_to_switch);
 
cmd[0] = 0x40 | SWITCH;
cmd[1] = mode;
@@ -3575,7 +3576,7 @@ static int reset_mmc_only(struct rtsx_chip *chip)
return STATUS_FAIL;
}
 
-   dev_dbg(rtsx_dev(chip), "In reset_mmc_only, sd_card->sd_type = 0x%x\n",
+   dev_dbg(rtsx_dev(chip), "In %s, sd_card->sd_type = 0x%x\n", __func__,
sd_card->sd_type);
 
return STATUS_SUCCESS;
@@ -3699,11 +3700,11 @@ int sd_rw(struct scsi_cmnd *srb, struct rtsx_chip 
*chip, u32 start_sector,
int retval;
 
if (srb->sc_data_direction == DMA_FROM_DEVICE) {
-   dev_dbg(rtsx_dev(chip), "sd_rw: Read %d %s from 0x%x\n",
+

Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-17 Thread Greg KH 
On Fri, Jul 14, 2017 at 07:38:43PM +0530, Gaurav Pathak wrote:
> staging: rts5208: Refactored code to avoid few defects.

That's the subject line, why repeat it here?

Please put a "real" description of the patch here.

> 
> Signed-off-by: Gaurav Pathak 
> ---
> Hi, Gaurav hope this text appaers in the email, and i put it at the right 
> place in patch.

You did, but why are you writing to yourself?

thanks,

greg k-h

Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-17 Thread Greg KH 
On Fri, Jul 14, 2017 at 07:38:43PM +0530, Gaurav Pathak wrote:
> staging: rts5208: Refactored code to avoid few defects.

That's the subject line, why repeat it here?

Please put a "real" description of the patch here.

> 
> Signed-off-by: Gaurav Pathak 
> ---
> Hi, Gaurav hope this text appaers in the email, and i put it at the right 
> place in patch.

You did, but why are you writing to yourself?

thanks,

greg k-h

[PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-14 Thread Gaurav Pathak 
staging: rts5208: Refactored code to avoid few defects.

Signed-off-by: Gaurav Pathak 
---
Hi, Gaurav hope this text appaers in the email, and i put it at the right place 
in patch.
 drivers/staging/rts5208/ms.c|  5 +++--
 drivers/staging/rts5208/rtsx.c  |  4 ++--
 drivers/staging/rts5208/rtsx_chip.c |  4 ++--
 drivers/staging/rts5208/sd.c| 28 +++-
 drivers/staging/rts5208/spi.c   |  8 +---
 drivers/staging/rts5208/xd.c| 17 ++---
 6 files changed, 37 insertions(+), 29 deletions(-)

diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c
index 482a29d..7cdce87 100644
--- a/drivers/staging/rts5208/ms.c
+++ b/drivers/staging/rts5208/ms.c
@@ -3064,7 +3064,8 @@ static int mspro_rw_multi_sector(struct scsi_cmnd *srb,
 
if (detect_card_cd(chip, MS_CARD) != STATUS_SUCCESS) {
chip->rw_need_retry = 0;
-   dev_dbg(rtsx_dev(chip), "No card exist, exit 
mspro_rw_multi_sector\n");
+   dev_dbg(rtsx_dev(chip), "No card exist, exit %s\n",
+   __func__);
rtsx_trace(chip);
return STATUS_FAIL;
}
@@ -3101,7 +3102,7 @@ static int mspro_read_format_progress(struct rtsx_chip 
*chip,
u8 cnt, tmp;
u8 data[8];
 
-   dev_dbg(rtsx_dev(chip), "mspro_read_format_progress, short_data_len = 
%d\n",
+   dev_dbg(rtsx_dev(chip), "%s, short_data_len = %d\n", __func__,
short_data_len);
 
retval = ms_switch_clock(chip);
diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index b8177f5..53748d6 100644
--- a/drivers/staging/rts5208/rtsx.c
+++ b/drivers/staging/rts5208/rtsx.c
@@ -999,7 +999,7 @@ static int rtsx_probe(struct pci_dev *pci,
 
/* We come here if there are any problems */
 errout:
-   dev_err(>dev, "rtsx_probe() failed\n");
+   dev_err(>dev, "%s failed\n", __func__);
release_everything(dev);
 
return err;
@@ -1009,7 +1009,7 @@ static void rtsx_remove(struct pci_dev *pci)
 {
struct rtsx_dev *dev = pci_get_drvdata(pci);
 
-   dev_info(>dev, "rtsx_remove() called\n");
+   dev_info(>dev, "%s called\n", __func__);
 
quiesce_and_remove_host(dev);
release_everything(dev);
diff --git a/drivers/staging/rts5208/rtsx_chip.c 
b/drivers/staging/rts5208/rtsx_chip.c
index 7f4107b..4ad472d 100644
--- a/drivers/staging/rts5208/rtsx_chip.c
+++ b/drivers/staging/rts5208/rtsx_chip.c
@@ -616,8 +616,8 @@ int rtsx_reset_chip(struct rtsx_chip *chip)
else
retval = rtsx_pre_handle_sdio_new(chip);
 
-   dev_dbg(rtsx_dev(chip), "chip->need_reset = 0x%x 
(rtsx_reset_chip)\n",
-   (unsigned int)(chip->need_reset));
+   dev_dbg(rtsx_dev(chip), "chip->need_reset = 0x%x (%s)\n",
+   (unsigned int)(chip->need_reset), __func__);
 #else  /* HW_AUTO_SWITCH_SD_BUS */
retval = rtsx_pre_handle_sdio_old(chip);
 #endif  /* HW_AUTO_SWITCH_SD_BUS */
diff --git a/drivers/staging/rts5208/sd.c b/drivers/staging/rts5208/sd.c
index c2eb072..e2b1fa03 100644
--- a/drivers/staging/rts5208/sd.c
+++ b/drivers/staging/rts5208/sd.c
@@ -910,8 +910,8 @@ static int sd_change_phase(struct rtsx_chip *chip, u8 
sample_point, u8 tune_dir)
int retval;
bool ddr_rx = false;
 
-   dev_dbg(rtsx_dev(chip), "sd_change_phase (sample_point = %d, tune_dir = 
%d)\n",
-   sample_point, tune_dir);
+   dev_dbg(rtsx_dev(chip), "%s (sample_point = %d, tune_dir = %d)\n",
+   __func__, sample_point, tune_dir);
 
if (tune_dir == TUNE_RX) {
SD_VP_CTL = SD_VPRX_CTL;
@@ -1225,8 +1225,9 @@ static int sd_check_switch_mode(struct rtsx_chip *chip, 
u8 mode, u8 func_group,
int retval;
u8 cmd[5], buf[64];
 
-   dev_dbg(rtsx_dev(chip), "sd_check_switch_mode (mode = %d, func_group = 
%d, func_to_switch = %d)\n",
-   mode, func_group, func_to_switch);
+   dev_dbg(rtsx_dev(chip), "%s ", __func__);
+   dev_dbg(rtsx_dev(chip), "mode = %d, func_group = %d,", mode, 
func_group);
+   dev_dbg(rtsx_dev(chip), "func_to_switch = %d)\n", func_to_switch);
 
cmd[0] = 0x40 | SWITCH;
cmd[1] = mode;
@@ -3575,7 +3576,7 @@ static int reset_mmc_only(struct rtsx_chip *chip)
return STATUS_FAIL;
}
 
-   dev_dbg(rtsx_dev(chip), "In reset_mmc_only, sd_card->sd_type = 0x%x\n",
+   dev_dbg(rtsx_dev(chip), "In %s, sd_card->sd_type = 0x%x\n", __func__,
sd_card->sd_type);
 
return STATUS_SUCCESS;
@@ -3699,11 +3700,11 @@ int sd_rw(struct scsi_cmnd *srb, struct rtsx_chip 
*chip, u32 start_sector,
int retval;
 
if (srb->sc_data_direction == DMA_FROM_DEVICE) {
-   dev_dbg(rtsx_dev(chip), "sd_rw: Read %d %s from

[PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-14 Thread Gaurav Pathak 
staging: rts5208: Refactored code to avoid few defects.

Signed-off-by: Gaurav Pathak 
---
Hi, Gaurav hope this text appaers in the email, and i put it at the right place 
in patch.
 drivers/staging/rts5208/ms.c|  5 +++--
 drivers/staging/rts5208/rtsx.c  |  4 ++--
 drivers/staging/rts5208/rtsx_chip.c |  4 ++--
 drivers/staging/rts5208/sd.c| 28 +++-
 drivers/staging/rts5208/spi.c   |  8 +---
 drivers/staging/rts5208/xd.c| 17 ++---
 6 files changed, 37 insertions(+), 29 deletions(-)

diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c
index 482a29d..7cdce87 100644
--- a/drivers/staging/rts5208/ms.c
+++ b/drivers/staging/rts5208/ms.c
@@ -3064,7 +3064,8 @@ static int mspro_rw_multi_sector(struct scsi_cmnd *srb,
 
if (detect_card_cd(chip, MS_CARD) != STATUS_SUCCESS) {
chip->rw_need_retry = 0;
-   dev_dbg(rtsx_dev(chip), "No card exist, exit 
mspro_rw_multi_sector\n");
+   dev_dbg(rtsx_dev(chip), "No card exist, exit %s\n",
+   __func__);
rtsx_trace(chip);
return STATUS_FAIL;
}
@@ -3101,7 +3102,7 @@ static int mspro_read_format_progress(struct rtsx_chip 
*chip,
u8 cnt, tmp;
u8 data[8];
 
-   dev_dbg(rtsx_dev(chip), "mspro_read_format_progress, short_data_len = 
%d\n",
+   dev_dbg(rtsx_dev(chip), "%s, short_data_len = %d\n", __func__,
short_data_len);
 
retval = ms_switch_clock(chip);
diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index b8177f5..53748d6 100644
--- a/drivers/staging/rts5208/rtsx.c
+++ b/drivers/staging/rts5208/rtsx.c
@@ -999,7 +999,7 @@ static int rtsx_probe(struct pci_dev *pci,
 
/* We come here if there are any problems */
 errout:
-   dev_err(>dev, "rtsx_probe() failed\n");
+   dev_err(>dev, "%s failed\n", __func__);
release_everything(dev);
 
return err;
@@ -1009,7 +1009,7 @@ static void rtsx_remove(struct pci_dev *pci)
 {
struct rtsx_dev *dev = pci_get_drvdata(pci);
 
-   dev_info(>dev, "rtsx_remove() called\n");
+   dev_info(>dev, "%s called\n", __func__);
 
quiesce_and_remove_host(dev);
release_everything(dev);
diff --git a/drivers/staging/rts5208/rtsx_chip.c 
b/drivers/staging/rts5208/rtsx_chip.c
index 7f4107b..4ad472d 100644
--- a/drivers/staging/rts5208/rtsx_chip.c
+++ b/drivers/staging/rts5208/rtsx_chip.c
@@ -616,8 +616,8 @@ int rtsx_reset_chip(struct rtsx_chip *chip)
else
retval = rtsx_pre_handle_sdio_new(chip);
 
-   dev_dbg(rtsx_dev(chip), "chip->need_reset = 0x%x 
(rtsx_reset_chip)\n",
-   (unsigned int)(chip->need_reset));
+   dev_dbg(rtsx_dev(chip), "chip->need_reset = 0x%x (%s)\n",
+   (unsigned int)(chip->need_reset), __func__);
 #else  /* HW_AUTO_SWITCH_SD_BUS */
retval = rtsx_pre_handle_sdio_old(chip);
 #endif  /* HW_AUTO_SWITCH_SD_BUS */
diff --git a/drivers/staging/rts5208/sd.c b/drivers/staging/rts5208/sd.c
index c2eb072..e2b1fa03 100644
--- a/drivers/staging/rts5208/sd.c
+++ b/drivers/staging/rts5208/sd.c
@@ -910,8 +910,8 @@ static int sd_change_phase(struct rtsx_chip *chip, u8 
sample_point, u8 tune_dir)
int retval;
bool ddr_rx = false;
 
-   dev_dbg(rtsx_dev(chip), "sd_change_phase (sample_point = %d, tune_dir = 
%d)\n",
-   sample_point, tune_dir);
+   dev_dbg(rtsx_dev(chip), "%s (sample_point = %d, tune_dir = %d)\n",
+   __func__, sample_point, tune_dir);
 
if (tune_dir == TUNE_RX) {
SD_VP_CTL = SD_VPRX_CTL;
@@ -1225,8 +1225,9 @@ static int sd_check_switch_mode(struct rtsx_chip *chip, 
u8 mode, u8 func_group,
int retval;
u8 cmd[5], buf[64];
 
-   dev_dbg(rtsx_dev(chip), "sd_check_switch_mode (mode = %d, func_group = 
%d, func_to_switch = %d)\n",
-   mode, func_group, func_to_switch);
+   dev_dbg(rtsx_dev(chip), "%s ", __func__);
+   dev_dbg(rtsx_dev(chip), "mode = %d, func_group = %d,", mode, 
func_group);
+   dev_dbg(rtsx_dev(chip), "func_to_switch = %d)\n", func_to_switch);
 
cmd[0] = 0x40 | SWITCH;
cmd[1] = mode;
@@ -3575,7 +3576,7 @@ static int reset_mmc_only(struct rtsx_chip *chip)
return STATUS_FAIL;
}
 
-   dev_dbg(rtsx_dev(chip), "In reset_mmc_only, sd_card->sd_type = 0x%x\n",
+   dev_dbg(rtsx_dev(chip), "In %s, sd_card->sd_type = 0x%x\n", __func__,
sd_card->sd_type);
 
return STATUS_SUCCESS;
@@ -3699,11 +3700,11 @@ int sd_rw(struct scsi_cmnd *srb, struct rtsx_chip 
*chip, u32 start_sector,
int retval;
 
if (srb->sc_data_direction == DMA_FROM_DEVICE) {
-   dev_dbg(rtsx_dev(chip), "sd_rw: Read %d %s from 0x%x\n",
+

Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-13 Thread Greg KH 
On Thu, Jul 13, 2017 at 09:30:20PM +0530, Gaurav Pathak wrote:
> Adding public mailing list address and Joe.
> 
> Hi Gerg,
> 
> I am trying my best to avoid such silly mistakes, but this is first
> time I am sending patch to a maintainer.  Please disregard my
> mistakes.
> 
> I will send it to the correct mailing list, but when I ran
> get_maintainer.pl on my patch your Name and email was displayed on
> top.

That's fine, but there was also another mailing list on that it showed
as well, right?  Please use that for patches for staging drivers.

thanks,

greg k-h

Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-13 Thread Greg KH 
On Thu, Jul 13, 2017 at 09:30:20PM +0530, Gaurav Pathak wrote:
> Adding public mailing list address and Joe.
> 
> Hi Gerg,
> 
> I am trying my best to avoid such silly mistakes, but this is first
> time I am sending patch to a maintainer.  Please disregard my
> mistakes.
> 
> I will send it to the correct mailing list, but when I ran
> get_maintainer.pl on my patch your Name and email was displayed on
> top.

That's fine, but there was also another mailing list on that it showed
as well, right?  Please use that for patches for staging drivers.

thanks,

greg k-h

Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-13 Thread Gaurav Pathak 
Adding public mailing list address and Joe.

Hi Gerg,

I am trying my best to avoid such silly mistakes, but this is first time I am 
sending patch to a maintainer.
Please disregard my mistakes.

I will send it to the correct mailing list, but when I ran get_maintainer.pl on 
my patch your Name and email was displayed on top.


On Thursday 13 July 2017 09:08 PM, Greg KH wrote:
> On Thu, Jul 13, 2017 at 08:40:26PM +0530, Gaurav Pathak wrote:
>> Hi Gerg,
>>
>> I am trying my best to avoid such silly mistakes, but this is first time I 
>> am sending patch to a maintainer.
>> Please disregard my mistakes.
>>
>> I will send it to the correct mailing list, but when I ran get_maintainer.pl 
>> on my patch your Name and email was displayed on top.
> 
>
> For some reason you sent this only to me, which is a bit rude to
> everyone else on the mailing list.  I'll be glad to respond if you
> resend it to everyone.
>
> thanks,
>
> greg k-h
>
>
>
>
> Great question, care to ask this on the  mailing list and CC me?  That
> way I can answer it in public to enable everyone else to know the answer, and
> let the search engines pick it up.
>
> Also, please read the following two links on why it is not good to
> directly email people:
>   http://www.arm.linux.org.uk/news/?newsitem=11
>   http://www.eyrie.org/~eagle/faqs/questions.html
>
> thanks,
>
> greg k-h

Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-13 Thread Gaurav Pathak 
Adding public mailing list address and Joe.

Hi Gerg,

I am trying my best to avoid such silly mistakes, but this is first time I am 
sending patch to a maintainer.
Please disregard my mistakes.

I will send it to the correct mailing list, but when I ran get_maintainer.pl on 
my patch your Name and email was displayed on top.


On Thursday 13 July 2017 09:08 PM, Greg KH wrote:
> On Thu, Jul 13, 2017 at 08:40:26PM +0530, Gaurav Pathak wrote:
>> Hi Gerg,
>>
>> I am trying my best to avoid such silly mistakes, but this is first time I 
>> am sending patch to a maintainer.
>> Please disregard my mistakes.
>>
>> I will send it to the correct mailing list, but when I ran get_maintainer.pl 
>> on my patch your Name and email was displayed on top.
> 
>
> For some reason you sent this only to me, which is a bit rude to
> everyone else on the mailing list.  I'll be glad to respond if you
> resend it to everyone.
>
> thanks,
>
> greg k-h
>
>
>
>
> Great question, care to ask this on the  mailing list and CC me?  That
> way I can answer it in public to enable everyone else to know the answer, and
> let the search engines pick it up.
>
> Also, please read the following two links on why it is not good to
> directly email people:
>   http://www.arm.linux.org.uk/news/?newsitem=11
>   http://www.eyrie.org/~eagle/faqs/questions.html
>
> thanks,
>
> greg k-h

Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-13 Thread Greg KH 
On Thu, Jul 13, 2017 at 08:02:20PM +0530, Gaurav Pathak wrote:
> staging: rts5208: Fixed compiler errors for dev_dbg()

That's not what this patch does :(

Please also use the correct mailing list, scripts/get_maintainer.pl is
your friend...

thanks,

greg k-h

Re: [PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-13 Thread Greg KH 
On Thu, Jul 13, 2017 at 08:02:20PM +0530, Gaurav Pathak wrote:
> staging: rts5208: Fixed compiler errors for dev_dbg()

That's not what this patch does :(

Please also use the correct mailing list, scripts/get_maintainer.pl is
your friend...

thanks,

greg k-h

[PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-13 Thread Gaurav Pathak 
staging: rts5208: Fixed compiler errors for dev_dbg()

Signed-off-by: Gaurav Pathak 
---
 drivers/staging/rts5208/ms.c|  5 +++--
 drivers/staging/rts5208/rtsx.c  |  4 ++--
 drivers/staging/rts5208/rtsx_chip.c |  4 ++--
 drivers/staging/rts5208/sd.c| 28 +++-
 drivers/staging/rts5208/spi.c   |  8 +---
 drivers/staging/rts5208/xd.c| 17 ++---
 6 files changed, 37 insertions(+), 29 deletions(-)

diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c
index 482a29d..7cdce87 100644
--- a/drivers/staging/rts5208/ms.c
+++ b/drivers/staging/rts5208/ms.c
@@ -3064,7 +3064,8 @@ static int mspro_rw_multi_sector(struct scsi_cmnd *srb,
 
if (detect_card_cd(chip, MS_CARD) != STATUS_SUCCESS) {
chip->rw_need_retry = 0;
-   dev_dbg(rtsx_dev(chip), "No card exist, exit 
mspro_rw_multi_sector\n");
+   dev_dbg(rtsx_dev(chip), "No card exist, exit %s\n",
+   __func__);
rtsx_trace(chip);
return STATUS_FAIL;
}
@@ -3101,7 +3102,7 @@ static int mspro_read_format_progress(struct rtsx_chip 
*chip,
u8 cnt, tmp;
u8 data[8];
 
-   dev_dbg(rtsx_dev(chip), "mspro_read_format_progress, short_data_len = 
%d\n",
+   dev_dbg(rtsx_dev(chip), "%s, short_data_len = %d\n", __func__,
short_data_len);
 
retval = ms_switch_clock(chip);
diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index b8177f5..53748d6 100644
--- a/drivers/staging/rts5208/rtsx.c
+++ b/drivers/staging/rts5208/rtsx.c
@@ -999,7 +999,7 @@ static int rtsx_probe(struct pci_dev *pci,
 
/* We come here if there are any problems */
 errout:
-   dev_err(>dev, "rtsx_probe() failed\n");
+   dev_err(>dev, "%s failed\n", __func__);
release_everything(dev);
 
return err;
@@ -1009,7 +1009,7 @@ static void rtsx_remove(struct pci_dev *pci)
 {
struct rtsx_dev *dev = pci_get_drvdata(pci);
 
-   dev_info(>dev, "rtsx_remove() called\n");
+   dev_info(>dev, "%s called\n", __func__);
 
quiesce_and_remove_host(dev);
release_everything(dev);
diff --git a/drivers/staging/rts5208/rtsx_chip.c 
b/drivers/staging/rts5208/rtsx_chip.c
index 7f4107b..4ad472d 100644
--- a/drivers/staging/rts5208/rtsx_chip.c
+++ b/drivers/staging/rts5208/rtsx_chip.c
@@ -616,8 +616,8 @@ int rtsx_reset_chip(struct rtsx_chip *chip)
else
retval = rtsx_pre_handle_sdio_new(chip);
 
-   dev_dbg(rtsx_dev(chip), "chip->need_reset = 0x%x 
(rtsx_reset_chip)\n",
-   (unsigned int)(chip->need_reset));
+   dev_dbg(rtsx_dev(chip), "chip->need_reset = 0x%x (%s)\n",
+   (unsigned int)(chip->need_reset), __func__);
 #else  /* HW_AUTO_SWITCH_SD_BUS */
retval = rtsx_pre_handle_sdio_old(chip);
 #endif  /* HW_AUTO_SWITCH_SD_BUS */
diff --git a/drivers/staging/rts5208/sd.c b/drivers/staging/rts5208/sd.c
index c2eb072..e2b1fa03 100644
--- a/drivers/staging/rts5208/sd.c
+++ b/drivers/staging/rts5208/sd.c
@@ -910,8 +910,8 @@ static int sd_change_phase(struct rtsx_chip *chip, u8 
sample_point, u8 tune_dir)
int retval;
bool ddr_rx = false;
 
-   dev_dbg(rtsx_dev(chip), "sd_change_phase (sample_point = %d, tune_dir = 
%d)\n",
-   sample_point, tune_dir);
+   dev_dbg(rtsx_dev(chip), "%s (sample_point = %d, tune_dir = %d)\n",
+   __func__, sample_point, tune_dir);
 
if (tune_dir == TUNE_RX) {
SD_VP_CTL = SD_VPRX_CTL;
@@ -1225,8 +1225,9 @@ static int sd_check_switch_mode(struct rtsx_chip *chip, 
u8 mode, u8 func_group,
int retval;
u8 cmd[5], buf[64];
 
-   dev_dbg(rtsx_dev(chip), "sd_check_switch_mode (mode = %d, func_group = 
%d, func_to_switch = %d)\n",
-   mode, func_group, func_to_switch);
+   dev_dbg(rtsx_dev(chip), "%s ", __func__);
+   dev_dbg(rtsx_dev(chip), "mode = %d, func_group = %d,", mode, 
func_group);
+   dev_dbg(rtsx_dev(chip), "func_to_switch = %d)\n", func_to_switch);
 
cmd[0] = 0x40 | SWITCH;
cmd[1] = mode;
@@ -3575,7 +3576,7 @@ static int reset_mmc_only(struct rtsx_chip *chip)
return STATUS_FAIL;
}
 
-   dev_dbg(rtsx_dev(chip), "In reset_mmc_only, sd_card->sd_type = 0x%x\n",
+   dev_dbg(rtsx_dev(chip), "In %s, sd_card->sd_type = 0x%x\n", __func__,
sd_card->sd_type);
 
return STATUS_SUCCESS;
@@ -3699,11 +3700,11 @@ int sd_rw(struct scsi_cmnd *srb, struct rtsx_chip 
*chip, u32 start_sector,
int retval;
 
if (srb->sc_data_direction == DMA_FROM_DEVICE) {
-   dev_dbg(rtsx_dev(chip), "sd_rw: Read %d %s from 0x%x\n",
+   dev_dbg(rtsx_dev(chip), "%s: Read %d %s from 0x%x\n", __func__,

[PATCH v1] staging: rts5208: Change fixed function names with "%s: ", __func__

2017-07-13 Thread Gaurav Pathak 
staging: rts5208: Fixed compiler errors for dev_dbg()

Signed-off-by: Gaurav Pathak 
---
 drivers/staging/rts5208/ms.c|  5 +++--
 drivers/staging/rts5208/rtsx.c  |  4 ++--
 drivers/staging/rts5208/rtsx_chip.c |  4 ++--
 drivers/staging/rts5208/sd.c| 28 +++-
 drivers/staging/rts5208/spi.c   |  8 +---
 drivers/staging/rts5208/xd.c| 17 ++---
 6 files changed, 37 insertions(+), 29 deletions(-)

diff --git a/drivers/staging/rts5208/ms.c b/drivers/staging/rts5208/ms.c
index 482a29d..7cdce87 100644
--- a/drivers/staging/rts5208/ms.c
+++ b/drivers/staging/rts5208/ms.c
@@ -3064,7 +3064,8 @@ static int mspro_rw_multi_sector(struct scsi_cmnd *srb,
 
if (detect_card_cd(chip, MS_CARD) != STATUS_SUCCESS) {
chip->rw_need_retry = 0;
-   dev_dbg(rtsx_dev(chip), "No card exist, exit 
mspro_rw_multi_sector\n");
+   dev_dbg(rtsx_dev(chip), "No card exist, exit %s\n",
+   __func__);
rtsx_trace(chip);
return STATUS_FAIL;
}
@@ -3101,7 +3102,7 @@ static int mspro_read_format_progress(struct rtsx_chip 
*chip,
u8 cnt, tmp;
u8 data[8];
 
-   dev_dbg(rtsx_dev(chip), "mspro_read_format_progress, short_data_len = 
%d\n",
+   dev_dbg(rtsx_dev(chip), "%s, short_data_len = %d\n", __func__,
short_data_len);
 
retval = ms_switch_clock(chip);
diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index b8177f5..53748d6 100644
--- a/drivers/staging/rts5208/rtsx.c
+++ b/drivers/staging/rts5208/rtsx.c
@@ -999,7 +999,7 @@ static int rtsx_probe(struct pci_dev *pci,
 
/* We come here if there are any problems */
 errout:
-   dev_err(>dev, "rtsx_probe() failed\n");
+   dev_err(>dev, "%s failed\n", __func__);
release_everything(dev);
 
return err;
@@ -1009,7 +1009,7 @@ static void rtsx_remove(struct pci_dev *pci)
 {
struct rtsx_dev *dev = pci_get_drvdata(pci);
 
-   dev_info(>dev, "rtsx_remove() called\n");
+   dev_info(>dev, "%s called\n", __func__);
 
quiesce_and_remove_host(dev);
release_everything(dev);
diff --git a/drivers/staging/rts5208/rtsx_chip.c 
b/drivers/staging/rts5208/rtsx_chip.c
index 7f4107b..4ad472d 100644
--- a/drivers/staging/rts5208/rtsx_chip.c
+++ b/drivers/staging/rts5208/rtsx_chip.c
@@ -616,8 +616,8 @@ int rtsx_reset_chip(struct rtsx_chip *chip)
else
retval = rtsx_pre_handle_sdio_new(chip);
 
-   dev_dbg(rtsx_dev(chip), "chip->need_reset = 0x%x 
(rtsx_reset_chip)\n",
-   (unsigned int)(chip->need_reset));
+   dev_dbg(rtsx_dev(chip), "chip->need_reset = 0x%x (%s)\n",
+   (unsigned int)(chip->need_reset), __func__);
 #else  /* HW_AUTO_SWITCH_SD_BUS */
retval = rtsx_pre_handle_sdio_old(chip);
 #endif  /* HW_AUTO_SWITCH_SD_BUS */
diff --git a/drivers/staging/rts5208/sd.c b/drivers/staging/rts5208/sd.c
index c2eb072..e2b1fa03 100644
--- a/drivers/staging/rts5208/sd.c
+++ b/drivers/staging/rts5208/sd.c
@@ -910,8 +910,8 @@ static int sd_change_phase(struct rtsx_chip *chip, u8 
sample_point, u8 tune_dir)
int retval;
bool ddr_rx = false;
 
-   dev_dbg(rtsx_dev(chip), "sd_change_phase (sample_point = %d, tune_dir = 
%d)\n",
-   sample_point, tune_dir);
+   dev_dbg(rtsx_dev(chip), "%s (sample_point = %d, tune_dir = %d)\n",
+   __func__, sample_point, tune_dir);
 
if (tune_dir == TUNE_RX) {
SD_VP_CTL = SD_VPRX_CTL;
@@ -1225,8 +1225,9 @@ static int sd_check_switch_mode(struct rtsx_chip *chip, 
u8 mode, u8 func_group,
int retval;
u8 cmd[5], buf[64];
 
-   dev_dbg(rtsx_dev(chip), "sd_check_switch_mode (mode = %d, func_group = 
%d, func_to_switch = %d)\n",
-   mode, func_group, func_to_switch);
+   dev_dbg(rtsx_dev(chip), "%s ", __func__);
+   dev_dbg(rtsx_dev(chip), "mode = %d, func_group = %d,", mode, 
func_group);
+   dev_dbg(rtsx_dev(chip), "func_to_switch = %d)\n", func_to_switch);
 
cmd[0] = 0x40 | SWITCH;
cmd[1] = mode;
@@ -3575,7 +3576,7 @@ static int reset_mmc_only(struct rtsx_chip *chip)
return STATUS_FAIL;
}
 
-   dev_dbg(rtsx_dev(chip), "In reset_mmc_only, sd_card->sd_type = 0x%x\n",
+   dev_dbg(rtsx_dev(chip), "In %s, sd_card->sd_type = 0x%x\n", __func__,
sd_card->sd_type);
 
return STATUS_SUCCESS;
@@ -3699,11 +3700,11 @@ int sd_rw(struct scsi_cmnd *srb, struct rtsx_chip 
*chip, u32 start_sector,
int retval;
 
if (srb->sc_data_direction == DMA_FROM_DEVICE) {
-   dev_dbg(rtsx_dev(chip), "sd_rw: Read %d %s from 0x%x\n",
+   dev_dbg(rtsx_dev(chip), "%s: Read %d %s from 0x%x\n", __func__,