Re: [PATCH v1 0/4] net: stmmac: dwmac-rk: Fix phy regulator issues
Hi all, 2015-01-19 21:19 GMT+01:00 Heiko Stübner : > Hi Romain > > Am Montag, 19. Januar 2015, 18:08:05 schrieb Romain Perier: >> This series fixes few issues in dwmac-rk: >> >> 1. Voltage settings was hardcoded into the driver for the phy regulator. >>The driver now uses the default voltage settings found in the devicetree, >> which are applied throught the regulator framework. >> 2. The regulator name used to power on or power off the phy was put in the >> devicetree variable "phy_regulator", which is not standard and added a lot >> of code for nothing. The driver now uses the devicetree property >> "phy-supply" and the corresponding functions to manipulate this regulator. >> >> The corresponding devicetree files are also updated. As, dwmac-rk was >> recently pushed in the development tree, I don't care about devicetree >> backward compatibility issues. > > This last sentence is slightly misleading :-) . > Yes, I meant that I don't need to care about it, as you explain it well below. Sorry for my misleading sentence ;) . I will fix it in my second serie. > The actual fact is, that these new bindings for the rk3288 gmac have not been > released with any official kernel release yet ... i.e. the will be released > with > 3.20 in whatever form, so we don't _need_ to care about keeping compatibility > still for the next 2.5 weeks or so. > > @Dave: it would be good if this series (when fixed) could still go into the > 3.20 material so we don't get stuck with the non-standard regulator property. > > > As we'll probably need a v2 due to at the issue in patch3, could you also > switch places of patch1 and 2, which would keep bisecatbility (i.e. regulator > property before removing the voltage setting from the driver). This sentence about re-ordering patches is for Dave or for me ? Thanks, Romain -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v1 0/4] net: stmmac: dwmac-rk: Fix phy regulator issues
Hi Romain Am Montag, 19. Januar 2015, 18:08:05 schrieb Romain Perier: > This series fixes few issues in dwmac-rk: > > 1. Voltage settings was hardcoded into the driver for the phy regulator. >The driver now uses the default voltage settings found in the devicetree, > which are applied throught the regulator framework. > 2. The regulator name used to power on or power off the phy was put in the > devicetree variable "phy_regulator", which is not standard and added a lot > of code for nothing. The driver now uses the devicetree property > "phy-supply" and the corresponding functions to manipulate this regulator. > > The corresponding devicetree files are also updated. As, dwmac-rk was > recently pushed in the development tree, I don't care about devicetree > backward compatibility issues. This last sentence is slightly misleading :-) . The actual fact is, that these new bindings for the rk3288 gmac have not been released with any official kernel release yet ... i.e. the will be released with 3.20 in whatever form, so we don't _need_ to care about keeping compatibility still for the next 2.5 weeks or so. @Dave: it would be good if this series (when fixed) could still go into the 3.20 material so we don't get stuck with the non-standard regulator property. As we'll probably need a v2 due to at the issue in patch3, could you also switch places of patch1 and 2, which would keep bisecatbility (i.e. regulator property before removing the voltage setting from the driver). Otherwise this series: Reviewed-by: Heiko Stuebner Tested-by: Heiko Stuebner -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v1 0/4] net: stmmac: dwmac-rk: Fix phy regulator issues
This series fixes few issues in dwmac-rk: 1. Voltage settings was hardcoded into the driver for the phy regulator. The driver now uses the default voltage settings found in the devicetree, which are applied throught the regulator framework. 2. The regulator name used to power on or power off the phy was put in the devicetree variable "phy_regulator", which is not standard and added a lot of code for nothing. The driver now uses the devicetree property "phy-supply" and the corresponding functions to manipulate this regulator. The corresponding devicetree files are also updated. As, dwmac-rk was recently pushed in the development tree, I don't care about devicetree backward compatibility issues. Romain Perier (4): net: stmmac: dwmac-rk: Don't set the regulator voltage for phy from the driver ARM: dts: Add regulator voltage settings for vcc_phy in rk3288-evb.dtsi net: stmmac: dwmac-rk: Use standard devicetree property for phy regulator ARM: dts: Convert gmac to phy-supply in rk3288-evb-rk808.dts arch/arm/boot/dts/rk3288-evb-rk808.dts | 2 +- arch/arm/boot/dts/rk3288-evb.dtsi | 2 + drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 62 -- 3 files changed, 22 insertions(+), 44 deletions(-) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
