RE: [linux-keystone] Re: [PATCH v1 01/12] clk: davinci - add Main PLL clock driver
>> -Original Message-
>> From: Linus Walleij [mailto:linus.wall...@linaro.org]
>> Sent: Wednesday, September 26, 2012 7:11 AM
>> To: Karicheri, Muralidharan
>> Cc: mturque...@linaro.org; a...@arndb.de; a...@linux-foundation.org;
>> shawn@linaro.org; rob.herr...@calxeda.com; viresh.li...@gmail.com; linux-
>> ker...@vger.kernel.org; Nori, Sekhar; Hilman, Kevin; li...@arm.linux.org.uk;
>> davinci-
>> linux-open-sou...@linux.davincidsp.com;
>> linux-arm-ker...@lists.infradead.org; linux-
>> keyst...@list.ti.com - Linux developers for Keystone family of devices (May
>> contain non-
>> TIers); linux-c6x-...@linux-c6x.org; Chemparathy, Cyril
>> Subject: [linux-keystone] Re: [PATCH v1 01/12] clk: davinci - add Main PLL
>> clock driver
>>
>> On Tue, Sep 25, 2012 at 12:20 AM, Murali Karicheri
>> wrote:
>>
>> > +struct clk_davinci_pll_data {
>> > + /* physical addresses set by platform code */
>> > + u32 phy_pllm;
>> > + /* if PLL has a prediv register this should be non zero */
>> > + u32 phy_prediv;
>> > + /* if PLL has a postdiv register this should be non zero */
>> > + u32 phy_postdiv;
>> > + /* mapped addresses. should be initialized by */
>> > + void __iomem *pllm;
>> > + void __iomem *prediv;
>> > + void __iomem *postdiv;
>> > + u32 pllm_mask;
>> > + u32 prediv_mask;
>> > + u32 postdiv_mask;
>> > + u32 num;
>> > + /* framework flags */
>> > + u32 flags;
>> > + /* pll flags */
>> > + u32 pll_flags;
>> > + u32 fixed_prediv; /* use this value for prediv */
>> > + u32 pllm_multiplier;/* multiply PLLM by this factor. By default
>> > +* most SOC set this to zero that
>> > translates
>> > +* to a multiplier of 1 and incrementer of
>> > 1.
>> > +* To override default, set this factor */
>> > +};
>>
>> OMG this commenting style hurt my eyes ;-)
>>
>> Please use good old kerneldoc above the struct instead.
>>
>> Yours,
>> Linus Walleij
Sure! I will fix these in my next revision.
Murali
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v1 01/12] clk: davinci - add Main PLL clock driver
On Tue, Sep 25, 2012 at 12:20 AM, Murali Karicheri wrote:
> +struct clk_davinci_pll_data {
> + /* physical addresses set by platform code */
> + u32 phy_pllm;
> + /* if PLL has a prediv register this should be non zero */
> + u32 phy_prediv;
> + /* if PLL has a postdiv register this should be non zero */
> + u32 phy_postdiv;
> + /* mapped addresses. should be initialized by */
> + void __iomem *pllm;
> + void __iomem *prediv;
> + void __iomem *postdiv;
> + u32 pllm_mask;
> + u32 prediv_mask;
> + u32 postdiv_mask;
> + u32 num;
> + /* framework flags */
> + u32 flags;
> + /* pll flags */
> + u32 pll_flags;
> + u32 fixed_prediv; /* use this value for prediv */
> + u32 pllm_multiplier;/* multiply PLLM by this factor. By default
> +* most SOC set this to zero that translates
> +* to a multiplier of 1 and incrementer of 1.
> +* To override default, set this factor */
> +};
OMG this commenting style hurt my eyes ;-)
Please use good old kerneldoc above the struct instead.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v1 01/12] clk: davinci - add Main PLL clock driver
On Tue, Sep 25, 2012 at 12:20 AM, Murali Karicheri m-kariche...@ti.com wrote:
+struct clk_davinci_pll_data {
+ /* physical addresses set by platform code */
+ u32 phy_pllm;
+ /* if PLL has a prediv register this should be non zero */
+ u32 phy_prediv;
+ /* if PLL has a postdiv register this should be non zero */
+ u32 phy_postdiv;
+ /* mapped addresses. should be initialized by */
+ void __iomem *pllm;
+ void __iomem *prediv;
+ void __iomem *postdiv;
+ u32 pllm_mask;
+ u32 prediv_mask;
+ u32 postdiv_mask;
+ u32 num;
+ /* framework flags */
+ u32 flags;
+ /* pll flags */
+ u32 pll_flags;
+ u32 fixed_prediv; /* use this value for prediv */
+ u32 pllm_multiplier;/* multiply PLLM by this factor. By default
+* most SOC set this to zero that translates
+* to a multiplier of 1 and incrementer of 1.
+* To override default, set this factor */
+};
OMG this commenting style hurt my eyes ;-)
Please use good old kerneldoc above the struct instead.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [linux-keystone] Re: [PATCH v1 01/12] clk: davinci - add Main PLL clock driver
-Original Message-
From: Linus Walleij [mailto:linus.wall...@linaro.org]
Sent: Wednesday, September 26, 2012 7:11 AM
To: Karicheri, Muralidharan
Cc: mturque...@linaro.org; a...@arndb.de; a...@linux-foundation.org;
shawn@linaro.org; rob.herr...@calxeda.com; viresh.li...@gmail.com; linux-
ker...@vger.kernel.org; Nori, Sekhar; Hilman, Kevin; li...@arm.linux.org.uk;
davinci-
linux-open-sou...@linux.davincidsp.com;
linux-arm-ker...@lists.infradead.org; linux-
keyst...@list.ti.com - Linux developers for Keystone family of devices (May
contain non-
TIers); linux-c6x-...@linux-c6x.org; Chemparathy, Cyril
Subject: [linux-keystone] Re: [PATCH v1 01/12] clk: davinci - add Main PLL
clock driver
On Tue, Sep 25, 2012 at 12:20 AM, Murali Karicheri m-kariche...@ti.com
wrote:
+struct clk_davinci_pll_data {
+ /* physical addresses set by platform code */
+ u32 phy_pllm;
+ /* if PLL has a prediv register this should be non zero */
+ u32 phy_prediv;
+ /* if PLL has a postdiv register this should be non zero */
+ u32 phy_postdiv;
+ /* mapped addresses. should be initialized by */
+ void __iomem *pllm;
+ void __iomem *prediv;
+ void __iomem *postdiv;
+ u32 pllm_mask;
+ u32 prediv_mask;
+ u32 postdiv_mask;
+ u32 num;
+ /* framework flags */
+ u32 flags;
+ /* pll flags */
+ u32 pll_flags;
+ u32 fixed_prediv; /* use this value for prediv */
+ u32 pllm_multiplier;/* multiply PLLM by this factor. By default
+* most SOC set this to zero that
translates
+* to a multiplier of 1 and incrementer of
1.
+* To override default, set this factor */
+};
OMG this commenting style hurt my eyes ;-)
Please use good old kerneldoc above the struct instead.
Yours,
Linus Walleij
Sure! I will fix these in my next revision.
Murali
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
