Hi Eizan,
Thank you for your patch. One trivial comment below ...
Missatge de Eizan Miyamoto del dia dt., 5 de maig
2020 a les 6:01:
>
> These fields are not used and can be removed.
>
> Signed-off-by: ei...@chromium.org
Malformatted Signed-off-by tag. Drop it.
> Signed-off-by: Eizan Miyamoto
Note that the author/seder should match the Signed-off-by, so you
should use your chromium.org account here. Other than that the patch
looks good to me, so
Reviewed-by: Enric Balletbo i Serra
> ---
>
> drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 1 -
> drivers/media/platform/mtk-mdp/mtk_mdp_comp.h | 2 --
> 2 files changed, 3 deletions(-)
>
> diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
> b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
> index 14991685adb7..facc6104b91f 100644
> --- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
> +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.c
> @@ -106,7 +106,6 @@ int mtk_mdp_comp_init(struct device *dev, struct
> device_node *node,
> comp->dev_node = of_node_get(node);
> comp->id = comp_id;
> comp->type = mtk_mdp_matches[comp_id].type;
> - comp->regs = of_iomap(node, 0);
>
> for (i = 0; i < ARRAY_SIZE(comp->clk); i++) {
> comp->clk[i] = of_clk_get(node, i);
> diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
> b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
> index 998a4b953025..3b83bd6e0d8b 100644
> --- a/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
> +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_comp.h
> @@ -38,7 +38,6 @@ enum mtk_mdp_comp_id {
> * struct mtk_mdp_comp - the MDP's function component data
> * @dev_node: component device node
> * @clk: clocks required for component
> - * @regs: Mapped address of component registers.
> * @larb_dev: SMI device required for component
> * @type: component type
> * @id:component ID
> @@ -46,7 +45,6 @@ enum mtk_mdp_comp_id {
> struct mtk_mdp_comp {
> struct device_node *dev_node;
> struct clk *clk[2];
> - void __iomem*regs;
> struct device *larb_dev;
> enum mtk_mdp_comp_type type;
> enum mtk_mdp_comp_idid;
> --
> 2.26.2.526.g744177e7f7-goog
>
>
> ___
> Linux-mediatek mailing list
> linux-media...@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
