Re: [PATCH v1 1/7] pps: clients: gpio: Bail out on error when requesting GPIO echo line
On 09/03/21 12:28, Andy Shevchenko wrote: > On Tue, Mar 09, 2021 at 11:51:58AM +0100, Rodolfo Giometti wrote: >> On 09/03/21 11:47, Andy Shevchenko wrote: >>> +Cc: Greg >>> >>> On Fri, Feb 26, 2021 at 07:03:32PM +0200, Andy Shevchenko wrote: On Tue, Feb 16, 2021 at 01:31:48PM +0200, Andy Shevchenko wrote: > When requesting optional GPIO echo line, bail out on error, > so user will know that something wrong with the existing property. Guys, any comments on this series? >>> >>> Greg, seems PPS maintainer keeps silent, can I route this series thru one of >>> yours tree (resend implied)? >> >> I'm sorry but I suppose I missed this patch... -_-' > > Entire series (7 patches) has been Cc'ed to you :-) > >> Can you please resend it to me? > > Okay, I will resend with Greg included just in case. > > Done! Thanks! Got them and acked. :-) Sorry for delay. > For the future, I recommend to switch to b4 tool (most likely already in your > Linux distribution), so > > 0/ Install b4 tool (if not yet in distro: `pip install b4` should work) > 1/ Find message ID for the thread, for example, > 20210216113154.70852-1-andriy.shevche...@linux.intel.com (v1) > 20210309112403.36633-1-andriy.shevche...@linux.intel.com (v1 resend) > > 2/ `b4 am -s $MESSAGE_ID`, replace $MESSAGE_ID with one of the above > 3/ it will download a mailbox that you may apply with `git am ...` Uao! I'm going to use it for sure! Thanks. Ciao, Rodolfo -- GNU/Linux Solutions e-mail: giome...@enneenne.com Linux Device Driver giome...@linux.it Embedded Systems phone: +39 349 2432127 UNIX programming skype: rodolfo.giometti
Re: [PATCH v1 1/7] pps: clients: gpio: Bail out on error when requesting GPIO echo line
On Tue, Mar 09, 2021 at 11:51:58AM +0100, Rodolfo Giometti wrote: > On 09/03/21 11:47, Andy Shevchenko wrote: > > +Cc: Greg > > > > On Fri, Feb 26, 2021 at 07:03:32PM +0200, Andy Shevchenko wrote: > >> On Tue, Feb 16, 2021 at 01:31:48PM +0200, Andy Shevchenko wrote: > >>> When requesting optional GPIO echo line, bail out on error, > >>> so user will know that something wrong with the existing property. > >> > >> Guys, any comments on this series? > > > > Greg, seems PPS maintainer keeps silent, can I route this series thru one of > > yours tree (resend implied)? > > I'm sorry but I suppose I missed this patch... -_-' Entire series (7 patches) has been Cc'ed to you :-) > Can you please resend it to me? Okay, I will resend with Greg included just in case. Done! For the future, I recommend to switch to b4 tool (most likely already in your Linux distribution), so 0/ Install b4 tool (if not yet in distro: `pip install b4` should work) 1/ Find message ID for the thread, for example, 20210216113154.70852-1-andriy.shevche...@linux.intel.com (v1) 20210309112403.36633-1-andriy.shevche...@linux.intel.com (v1 resend) 2/ `b4 am -s $MESSAGE_ID`, replace $MESSAGE_ID with one of the above 3/ it will download a mailbox that you may apply with `git am ...` -- With Best Regards, Andy Shevchenko
Re: [PATCH v1 1/7] pps: clients: gpio: Bail out on error when requesting GPIO echo line
On 09/03/21 11:47, Andy Shevchenko wrote: > +Cc: Greg > > On Fri, Feb 26, 2021 at 07:03:32PM +0200, Andy Shevchenko wrote: >> On Tue, Feb 16, 2021 at 01:31:48PM +0200, Andy Shevchenko wrote: >>> When requesting optional GPIO echo line, bail out on error, >>> so user will know that something wrong with the existing property. >> >> Guys, any comments on this series? > > Greg, seems PPS maintainer keeps silent, can I route this series thru one of > yours tree (resend implied)? I'm sorry but I suppose I missed this patch... -_-' Can you please resend it to me? Ciao, Rodolfo -- GNU/Linux Solutions e-mail: giome...@enneenne.com Linux Device Driver giome...@linux.it Embedded Systems phone: +39 349 2432127 UNIX programming skype: rodolfo.giometti
Re: [PATCH v1 1/7] pps: clients: gpio: Bail out on error when requesting GPIO echo line
+Cc: Greg On Fri, Feb 26, 2021 at 07:03:32PM +0200, Andy Shevchenko wrote: > On Tue, Feb 16, 2021 at 01:31:48PM +0200, Andy Shevchenko wrote: > > When requesting optional GPIO echo line, bail out on error, > > so user will know that something wrong with the existing property. > > Guys, any comments on this series? Greg, seems PPS maintainer keeps silent, can I route this series thru one of yours tree (resend implied)? -- With Best Regards, Andy Shevchenko
Re: [PATCH v1 1/7] pps: clients: gpio: Bail out on error when requesting GPIO echo line
On Tue, Feb 16, 2021 at 01:31:48PM +0200, Andy Shevchenko wrote:
> When requesting optional GPIO echo line, bail out on error,
> so user will know that something wrong with the existing property.
Guys, any comments on this series?
> Signed-off-by: Andy Shevchenko
> ---
> drivers/pps/clients/pps-gpio.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pps/clients/pps-gpio.c b/drivers/pps/clients/pps-gpio.c
> index e0de1df2ede0..f89c31aa66f1 100644
> --- a/drivers/pps/clients/pps-gpio.c
> +++ b/drivers/pps/clients/pps-gpio.c
> @@ -119,12 +119,12 @@ static int pps_gpio_setup(struct platform_device *pdev)
> data->echo_pin = devm_gpiod_get_optional(>dev,
> "echo",
> GPIOD_OUT_LOW);
> - if (data->echo_pin) {
> - if (IS_ERR(data->echo_pin)) {
> - dev_err(>dev, "failed to request ECHO GPIO\n");
> - return PTR_ERR(data->echo_pin);
> - }
> + if (IS_ERR(data->echo_pin)) {
> + dev_err(>dev, "failed to request ECHO GPIO\n");
> + return PTR_ERR(data->echo_pin);
> + }
>
> + if (data->echo_pin) {
> ret = of_property_read_u32(np,
> "echo-active-ms",
> );
> --
> 2.30.0
>
--
With Best Regards,
Andy Shevchenko
[PATCH v1 1/7] pps: clients: gpio: Bail out on error when requesting GPIO echo line
When requesting optional GPIO echo line, bail out on error,
so user will know that something wrong with the existing property.
Signed-off-by: Andy Shevchenko
---
drivers/pps/clients/pps-gpio.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/pps/clients/pps-gpio.c b/drivers/pps/clients/pps-gpio.c
index e0de1df2ede0..f89c31aa66f1 100644
--- a/drivers/pps/clients/pps-gpio.c
+++ b/drivers/pps/clients/pps-gpio.c
@@ -119,12 +119,12 @@ static int pps_gpio_setup(struct platform_device *pdev)
data->echo_pin = devm_gpiod_get_optional(>dev,
"echo",
GPIOD_OUT_LOW);
- if (data->echo_pin) {
- if (IS_ERR(data->echo_pin)) {
- dev_err(>dev, "failed to request ECHO GPIO\n");
- return PTR_ERR(data->echo_pin);
- }
+ if (IS_ERR(data->echo_pin)) {
+ dev_err(>dev, "failed to request ECHO GPIO\n");
+ return PTR_ERR(data->echo_pin);
+ }
+ if (data->echo_pin) {
ret = of_property_read_u32(np,
"echo-active-ms",
);
--
2.30.0
