Re: [PATCH v1 2/3] mtd: spi-nor: mtk-quadspi: add SNOR_HWCAPS_READ for capcity setting
On Tue, 2019-01-15 at 06:59 +, tudor.amba...@microchip.com wrote:
> Hi, Ryder,
>
> On 01/14/2019 07:12 AM, Ryder Lee wrote:
> > From: Guochun Mao
> >
> > SNOR_HWCAPS_READ is a basic read mode for both flash and controller,
> > it should be supported, so add the capcity for mtk-quadspi.
>
> Since I couldn't find a datasheet for mt8173, I tend to share your assumption
> -
> SNOR_HWCAPS_READ should be supported by this controller. However, it's always
> better to test it and not rely on assumptions. You can test it by forcing the
> mask to have just SNOR_HWCAPS_READ | SNOR_HWCAPS_PP set. Or you already
> tested it?
Our IPs all support SNOR_HWCAPS_READ, Ryedr and I have test it.
>
> You have a typo in capcity. Maybe substitute it with capability or "add this
> flag to spi_nor_hwcaps mask"
Ok, we'll correct it next version.
Thanks.
Guochun
>
> >
> > Signed-off-by: Guochun Mao
>
> You should add your SoB tag, because you are sending a patch that is not
> yours.
>
> Cheers,
> ta
>
> > ---
> > Changes since v1: none.
> > ---
> > drivers/mtd/spi-nor/mtk-quadspi.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/mtd/spi-nor/mtk-quadspi.c
> > b/drivers/mtd/spi-nor/mtk-quadspi.c
> > index 5442993..d9eed68 100644
> > --- a/drivers/mtd/spi-nor/mtk-quadspi.c
> > +++ b/drivers/mtd/spi-nor/mtk-quadspi.c
> > @@ -431,7 +431,8 @@ static int mtk_nor_init(struct mtk_nor *mtk_nor,
> > struct device_node *flash_node)
> > {
> > const struct spi_nor_hwcaps hwcaps = {
> > - .mask = SNOR_HWCAPS_READ_FAST |
> > + .mask = SNOR_HWCAPS_READ |
> > + SNOR_HWCAPS_READ_FAST |
> > SNOR_HWCAPS_READ_1_1_2 |
> > SNOR_HWCAPS_PP,
> > };
> >
Re: [PATCH v1 2/3] mtd: spi-nor: mtk-quadspi: add SNOR_HWCAPS_READ for capcity setting
Hi, Ryder,
On 01/14/2019 07:12 AM, Ryder Lee wrote:
> From: Guochun Mao
>
> SNOR_HWCAPS_READ is a basic read mode for both flash and controller,
> it should be supported, so add the capcity for mtk-quadspi.
Since I couldn't find a datasheet for mt8173, I tend to share your assumption -
SNOR_HWCAPS_READ should be supported by this controller. However, it's always
better to test it and not rely on assumptions. You can test it by forcing the
mask to have just SNOR_HWCAPS_READ | SNOR_HWCAPS_PP set. Or you already tested
it?
You have a typo in capcity. Maybe substitute it with capability or "add this
flag to spi_nor_hwcaps mask"
>
> Signed-off-by: Guochun Mao
You should add your SoB tag, because you are sending a patch that is not yours.
Cheers,
ta
> ---
> Changes since v1: none.
> ---
> drivers/mtd/spi-nor/mtk-quadspi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/mtk-quadspi.c
> b/drivers/mtd/spi-nor/mtk-quadspi.c
> index 5442993..d9eed68 100644
> --- a/drivers/mtd/spi-nor/mtk-quadspi.c
> +++ b/drivers/mtd/spi-nor/mtk-quadspi.c
> @@ -431,7 +431,8 @@ static int mtk_nor_init(struct mtk_nor *mtk_nor,
> struct device_node *flash_node)
> {
> const struct spi_nor_hwcaps hwcaps = {
> - .mask = SNOR_HWCAPS_READ_FAST |
> + .mask = SNOR_HWCAPS_READ |
> + SNOR_HWCAPS_READ_FAST |
> SNOR_HWCAPS_READ_1_1_2 |
> SNOR_HWCAPS_PP,
> };
>
[PATCH v1 2/3] mtd: spi-nor: mtk-quadspi: add SNOR_HWCAPS_READ for capcity setting
From: Guochun Mao
SNOR_HWCAPS_READ is a basic read mode for both flash and controller,
it should be supported, so add the capcity for mtk-quadspi.
Signed-off-by: Guochun Mao
---
Changes since v1: none.
---
drivers/mtd/spi-nor/mtk-quadspi.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/mtk-quadspi.c
b/drivers/mtd/spi-nor/mtk-quadspi.c
index 5442993..d9eed68 100644
--- a/drivers/mtd/spi-nor/mtk-quadspi.c
+++ b/drivers/mtd/spi-nor/mtk-quadspi.c
@@ -431,7 +431,8 @@ static int mtk_nor_init(struct mtk_nor *mtk_nor,
struct device_node *flash_node)
{
const struct spi_nor_hwcaps hwcaps = {
- .mask = SNOR_HWCAPS_READ_FAST |
+ .mask = SNOR_HWCAPS_READ |
+ SNOR_HWCAPS_READ_FAST |
SNOR_HWCAPS_READ_1_1_2 |
SNOR_HWCAPS_PP,
};
--
1.9.1
