Re: [PATCH v1 3/6] serial: sunzilog: Return proper error code from console ->setup() hook

[David Miller]

From: Andy Shevchenko 
Date: Thu, 18 Jun 2020 19:47:48 +0300

> For unifying console ->setup() handling, which is pure documented,
> return error code, rather than non-zero arbitrary number.
> 
> Signed-off-by: Andy Shevchenko 
> Cc: "David S. Miller" 

Acked-by: David S. Miller 

[PATCH v1 3/6] serial: sunzilog: Return proper error code from console ->setup() hook

[Andy Shevchenko]

For unifying console ->setup() handling, which is pure documented,
return error code, rather than non-zero arbitrary number.

Signed-off-by: Andy Shevchenko 
Cc: "David S. Miller" 
---
 drivers/tty/serial/sunzilog.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/sunzilog.c b/drivers/tty/serial/sunzilog.c
index 103ab8c556e7..7ea06bbc6197 100644
--- a/drivers/tty/serial/sunzilog.c
+++ b/drivers/tty/serial/sunzilog.c
@@ -1221,7 +1221,7 @@ static int __init sunzilog_console_setup(struct console 
*con, char *options)
int baud, brg;
 
if (up->port.type != PORT_SUNZILOG)
-   return -1;
+   return -EINVAL;
 
printk(KERN_INFO "Console: ttyS%d (SunZilog zs%d)\n",
   (sunzilog_reg.minor - 64) + con->index, con->index);
-- 
2.27.0