Re: [PATCH v10 1/7] regulator: fixed: add support for ACPI interface
Hi Felipe and Heikki, On 06/08/2016 12:42 PM, Greg Kroah-Hartman wrote: > On Thu, Jun 02, 2016 at 09:37:23AM +0800, Lu Baolu wrote: >> Add support to retrieve fixed voltage configure information through >> ACPI interface. This is needed for Intel Bay Trail devices, where a >> GPIO is used to control the USB vbus. >> >> Signed-off-by: Lu Baolu >> --- >> drivers/regulator/fixed.c | 46 >> ++ >> 1 file changed, 46 insertions(+) > Can't do anything with this until I get an ack from the "owners" of this > file. > > And what happened to the acks from other Intel developers for this whole > patch series, I don't see that here :( > You have reviewed the whole patches in this series. Are you willing to ack them? Best regards, Lu Baolu
Re: [PATCH v10 1/7] regulator: fixed: add support for ACPI interface
On Wed, Jun 08, 2016 at 02:43:27PM +0100, Mark Brown wrote: > On Tue, Jun 07, 2016 at 09:42:48PM -0700, Greg Kroah-Hartman wrote: > > On Thu, Jun 02, 2016 at 09:37:23AM +0800, Lu Baolu wrote: > > > > Add support to retrieve fixed voltage configure information through > > > ACPI interface. This is needed for Intel Bay Trail devices, where a > > > GPIO is used to control the USB vbus. > > > Can't do anything with this until I get an ack from the "owners" of this > > file. > > Please allow a reasonable time for review, it's been under a week since > this was posted. I would *not* expect this to be applied to another > tree, please don't do that. I wouldn't consider it, my response was to the developer of the patch, sorry for the confusion, greg k-h
Re: [PATCH v10 1/7] regulator: fixed: add support for ACPI interface
On Tue, Jun 07, 2016 at 09:42:48PM -0700, Greg Kroah-Hartman wrote: > On Thu, Jun 02, 2016 at 09:37:23AM +0800, Lu Baolu wrote: > > Add support to retrieve fixed voltage configure information through > > ACPI interface. This is needed for Intel Bay Trail devices, where a > > GPIO is used to control the USB vbus. > Can't do anything with this until I get an ack from the "owners" of this > file. Please allow a reasonable time for review, it's been under a week since this was posted. I would *not* expect this to be applied to another tree, please don't do that. signature.asc Description: PGP signature
Re: [PATCH v10 1/7] regulator: fixed: add support for ACPI interface
On Thu, Jun 02, 2016 at 09:37:23AM +0800, Lu Baolu wrote: > Add support to retrieve fixed voltage configure information through > ACPI interface. This is needed for Intel Bay Trail devices, where a > GPIO is used to control the USB vbus. > > Signed-off-by: Lu Baolu > --- > drivers/regulator/fixed.c | 46 ++ > 1 file changed, 46 insertions(+) Can't do anything with this until I get an ack from the "owners" of this file. And what happened to the acks from other Intel developers for this whole patch series, I don't see that here :( greg k-h
[PATCH v10 1/7] regulator: fixed: add support for ACPI interface
Add support to retrieve fixed voltage configure information through
ACPI interface. This is needed for Intel Bay Trail devices, where a
GPIO is used to control the USB vbus.
Signed-off-by: Lu Baolu
---
drivers/regulator/fixed.c | 46 ++
1 file changed, 46 insertions(+)
diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c
index ff62d69..207ab40 100644
--- a/drivers/regulator/fixed.c
+++ b/drivers/regulator/fixed.c
@@ -30,6 +30,9 @@
#include
#include
#include
+#include
+#include
+#include
struct fixed_voltage_data {
struct regulator_desc desc;
@@ -104,6 +107,44 @@ of_get_fixed_voltage_config(struct device *dev,
return config;
}
+/**
+ * acpi_get_fixed_voltage_config - extract fixed_voltage_config structure info
+ * @dev: device requesting for fixed_voltage_config
+ * @desc: regulator description
+ *
+ * Populates fixed_voltage_config structure by extracting data through ACPI
+ * interface, returns a pointer to the populated structure of NULL if memory
+ * alloc fails.
+ */
+static struct fixed_voltage_config *
+acpi_get_fixed_voltage_config(struct device *dev,
+ const struct regulator_desc *desc)
+{
+ struct fixed_voltage_config *config;
+ const char *supply_name;
+ struct gpio_desc *gpiod;
+ int ret;
+
+ config = devm_kzalloc(dev, sizeof(*config), GFP_KERNEL);
+ if (!config)
+ return ERR_PTR(-ENOMEM);
+
+ ret = device_property_read_string(dev, "supply-name", &supply_name);
+ if (!ret)
+ config->supply_name = supply_name;
+
+ gpiod = gpiod_get(dev, "gpio", GPIOD_ASIS);
+ if (IS_ERR(gpiod))
+ return ERR_PTR(-ENODEV);
+
+ config->gpio = desc_to_gpio(gpiod);
+ config->enable_high = device_property_read_bool(dev,
+ "enable-active-high");
+ gpiod_put(gpiod);
+
+ return config;
+}
+
static struct regulator_ops fixed_voltage_ops = {
};
@@ -124,6 +165,11 @@ static int reg_fixed_voltage_probe(struct platform_device
*pdev)
&drvdata->desc);
if (IS_ERR(config))
return PTR_ERR(config);
+ } else if (ACPI_HANDLE(&pdev->dev)) {
+ config = acpi_get_fixed_voltage_config(&pdev->dev,
+ &drvdata->desc);
+ if (IS_ERR(config))
+ return PTR_ERR(config);
} else {
config = dev_get_platdata(&pdev->dev);
}
--
2.1.4
