Re: [PATCH v14 2/3] dt-bindings: pps: pps-gpio PPS ECHO implementation

2019-01-04 Thread Rodolfo Giometti

On 30/12/2018 09:33, Tom Burkart wrote:

This patch implements the device tree binding changes required for the
pps echo functionality for pps-gpio, that sysfs claims is available
already.

This patch was originally written by Lukas Senger as part of a masters
thesis project and modified for inclusion into the linux kernel by Tom
Burkart.


I think this patch it's OK but I'm asking to myself if it should be merged with 
next one... logically it describes what patch 3/3 does so why do we keep them 
separated?


Ciao,

Rodolfo

--
GNU/Linux Solutions  e-mail: giome...@enneenne.com
Linux Device Driver  giome...@linux.it
Embedded Systems phone:  +39 349 2432127
UNIX programming skype:  rodolfo.giometti


[PATCH v14 2/3] dt-bindings: pps: pps-gpio PPS ECHO implementation

2018-12-30 Thread Tom Burkart
This patch implements the device tree binding changes required for the
pps echo functionality for pps-gpio, that sysfs claims is available
already.

This patch was originally written by Lukas Senger as part of a masters
thesis project and modified for inclusion into the linux kernel by Tom
Burkart.

Reviewed-by: Rob Herring 
Signed-off-by: Lukas Senger 
Signed-off-by: Tom Burkart 
---
 Documentation/devicetree/bindings/pps/pps-gpio.txt | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/pps/pps-gpio.txt 
b/Documentation/devicetree/bindings/pps/pps-gpio.txt
index 3683874832ae..9012a2a02e14 100644
--- a/Documentation/devicetree/bindings/pps/pps-gpio.txt
+++ b/Documentation/devicetree/bindings/pps/pps-gpio.txt
@@ -7,6 +7,10 @@ Required properties:
 - compatible: should be "pps-gpio"
 - gpios: one PPS GPIO in the format described by ../gpio/gpio.txt
 
+Additional required properties for the PPS ECHO functionality:
+- echo-gpios: one PPS ECHO GPIO in the format described by ../gpio/gpio.txt
+- echo-active-ms: duration in ms of the active portion of the echo pulse
+
 Optional properties:
 - assert-falling-edge: when present, assert is indicated by a falling edge
(instead of by a rising edge)
@@ -19,5 +23,8 @@ Example:
gpios = < 26 GPIO_ACTIVE_HIGH>;
assert-falling-edge;
 
+   echo-gpios = < 27 GPIO_ACTIVE_HIGH>;
+   echo-active-ms = <100>;
+
compatible = "pps-gpio";
};
-- 
2.12.3