Re: [PATCH v2] ARM: dts: exynos5422-odroidxu3: add on-board INA231 sensors
Joonyoung Shim writes:
> Hi Kevin,
>
> On 01/15/2015 10:08 AM, Kevin Hilman wrote:
>> From: Kevin Hilman
>>
>> The odroid-xu3 has 4 INA231 current sensors on board which can be
>> accessed from the Linux via the hwmon interface.
>>
>> There is one sensor for each of these power rails:
>>
>> - A15 cluster: VDD_ARM
>> - A7 cluster: VDD_KFC
>> - GPU: VDD_G3D
>> - memory: VDD_MEM
>>
>> In addition to adding the sensors, LDO26 from the PMIC needs to be
>> enabled because it's powering these sensor.
>>
>> Cc: Javier Martinez Canillas
>> Cc: Sjoerd Simons
>> Signed-off-by: Kevin Hilman
>> ---
>> v2: use "ti,ina231" as compatible string.
>>
>> Applies on top of "ARM: dts: Add dts file for odroid XU3 board" from Sjoerd
>> Simons.
>>
>> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 39
>> ++
>> 1 file changed, 39 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> index c29123c0734d..50353d023225 100644
>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> @@ -174,6 +174,13 @@
>> regulator-always-on;
>> };
>>
>> +ldo26_reg: LDO26 {
>> +regulator-name = "vdd_ldo26";
>> +regulator-min-microvolt = <300>;
>> +regulator-max-microvolt = <300>;
>> +regulator-always-on;
>> +};
>> +
>> buck1_reg: BUCK1 {
>> regulator-name = "vdd_mif";
>> regulator-min-microvolt = <80>;
>> @@ -257,6 +264,38 @@
>> };
>> };
>>
>> +i2c_0: i2c@12C6 {
>
> It's ok but IMHO it can split using label reference, e.g.
>
> &i2c_0 {
> ...
> };
Yes, you're right. I'll spin a v3.
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] ARM: dts: exynos5422-odroidxu3: add on-board INA231 sensors
Hi Kevin,
On 01/15/2015 10:08 AM, Kevin Hilman wrote:
> From: Kevin Hilman
>
> The odroid-xu3 has 4 INA231 current sensors on board which can be
> accessed from the Linux via the hwmon interface.
>
> There is one sensor for each of these power rails:
>
> - A15 cluster: VDD_ARM
> - A7 cluster: VDD_KFC
> - GPU: VDD_G3D
> - memory: VDD_MEM
>
> In addition to adding the sensors, LDO26 from the PMIC needs to be
> enabled because it's powering these sensor.
>
> Cc: Javier Martinez Canillas
> Cc: Sjoerd Simons
> Signed-off-by: Kevin Hilman
> ---
> v2: use "ti,ina231" as compatible string.
>
> Applies on top of "ARM: dts: Add dts file for odroid XU3 board" from Sjoerd
> Simons.
>
> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 39
> ++
> 1 file changed, 39 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> index c29123c0734d..50353d023225 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> @@ -174,6 +174,13 @@
> regulator-always-on;
> };
>
> + ldo26_reg: LDO26 {
> + regulator-name = "vdd_ldo26";
> + regulator-min-microvolt = <300>;
> + regulator-max-microvolt = <300>;
> + regulator-always-on;
> + };
> +
> buck1_reg: BUCK1 {
> regulator-name = "vdd_mif";
> regulator-min-microvolt = <80>;
> @@ -257,6 +264,38 @@
> };
> };
>
> + i2c_0: i2c@12C6 {
It's ok but IMHO it can split using label reference, e.g.
&i2c_0 {
...
};
Thanks.
> + status = "okay";
> +
> + /* A15 cluster: VDD_ARM */
> + ina231@40 {
> + compatible = "ti,ina231";
> + reg = <0x40>;
> + shunt-resistor = <1>;
> + };
> +
> + /* memory: VDD_MEM */
> + ina231@41 {
> + compatible = "ti,ina231";
> + reg = <0x41>;
> + shunt-resistor = <1>;
> + };
> +
> + /* GPU: VDD_G3D */
> + ina231@44 {
> + compatible = "ti,ina231";
> + reg = <0x44>;
> + shunt-resistor = <1>;
> + };
> +
> + /* A7 cluster: VDD_KFC */
> + ina231@45 {
> + compatible = "ti,ina231";
> + reg = <0x45>;
> + shunt-resistor = <1>;
> + };
> + };
> +
> i2c_2: i2c@12C8 {
> samsung,i2c-sda-delay = <100>;
> samsung,i2c-max-bus-freq = <66000>;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2] ARM: dts: exynos5422-odroidxu3: add on-board INA231 sensors
On Wed, 2015-01-14 at 17:08 -0800, Kevin Hilman wrote:
> From: Kevin Hilman
>
> The odroid-xu3 has 4 INA231 current sensors on board which can be
> accessed from the Linux via the hwmon interface.
>
> There is one sensor for each of these power rails:
>
> - A15 cluster: VDD_ARM
> - A7 cluster: VDD_KFC
> - GPU: VDD_G3D
> - memory: VDD_MEM
>
> In addition to adding the sensors, LDO26 from the PMIC needs to be
> enabled because it's powering these sensor.
I haven't tested whether the sensor values are correct, but based on the
schematics & the hardkernel dts this describes the hardware correctly.
Reviewed-By: Sjoerd Simons
> Cc: Javier Martinez Canillas
> Cc: Sjoerd Simons
> Signed-off-by: Kevin Hilman
> ---
> v2: use "ti,ina231" as compatible string.
>
> Applies on top of "ARM: dts: Add dts file for odroid XU3 board" from Sjoerd
> Simons.
>
> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 39
> ++
> 1 file changed, 39 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> index c29123c0734d..50353d023225 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> @@ -174,6 +174,13 @@
> regulator-always-on;
> };
>
> + ldo26_reg: LDO26 {
> + regulator-name = "vdd_ldo26";
> + regulator-min-microvolt = <300>;
> + regulator-max-microvolt = <300>;
> + regulator-always-on;
> + };
> +
> buck1_reg: BUCK1 {
> regulator-name = "vdd_mif";
> regulator-min-microvolt = <80>;
> @@ -257,6 +264,38 @@
> };
> };
>
> + i2c_0: i2c@12C6 {
> + status = "okay";
> +
> + /* A15 cluster: VDD_ARM */
> + ina231@40 {
> + compatible = "ti,ina231";
> + reg = <0x40>;
> + shunt-resistor = <1>;
> + };
> +
> + /* memory: VDD_MEM */
> + ina231@41 {
> + compatible = "ti,ina231";
> + reg = <0x41>;
> + shunt-resistor = <1>;
> + };
> +
> + /* GPU: VDD_G3D */
> + ina231@44 {
> + compatible = "ti,ina231";
> + reg = <0x44>;
> + shunt-resistor = <1>;
> + };
> +
> + /* A7 cluster: VDD_KFC */
> + ina231@45 {
> + compatible = "ti,ina231";
> + reg = <0x45>;
> + shunt-resistor = <1>;
> + };
> + };
> +
> i2c_2: i2c@12C8 {
> samsung,i2c-sda-delay = <100>;
> samsung,i2c-max-bus-freq = <66000>;
smime.p7s
Description: S/MIME cryptographic signature
[PATCH v2] ARM: dts: exynos5422-odroidxu3: add on-board INA231 sensors
From: Kevin Hilman
The odroid-xu3 has 4 INA231 current sensors on board which can be
accessed from the Linux via the hwmon interface.
There is one sensor for each of these power rails:
- A15 cluster: VDD_ARM
- A7 cluster: VDD_KFC
- GPU: VDD_G3D
- memory: VDD_MEM
In addition to adding the sensors, LDO26 from the PMIC needs to be
enabled because it's powering these sensor.
Cc: Javier Martinez Canillas
Cc: Sjoerd Simons
Signed-off-by: Kevin Hilman
---
v2: use "ti,ina231" as compatible string.
Applies on top of "ARM: dts: Add dts file for odroid XU3 board" from Sjoerd
Simons.
arch/arm/boot/dts/exynos5422-odroidxu3.dts | 39 ++
1 file changed, 39 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index c29123c0734d..50353d023225 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -174,6 +174,13 @@
regulator-always-on;
};
+ ldo26_reg: LDO26 {
+ regulator-name = "vdd_ldo26";
+ regulator-min-microvolt = <300>;
+ regulator-max-microvolt = <300>;
+ regulator-always-on;
+ };
+
buck1_reg: BUCK1 {
regulator-name = "vdd_mif";
regulator-min-microvolt = <80>;
@@ -257,6 +264,38 @@
};
};
+ i2c_0: i2c@12C6 {
+ status = "okay";
+
+ /* A15 cluster: VDD_ARM */
+ ina231@40 {
+ compatible = "ti,ina231";
+ reg = <0x40>;
+ shunt-resistor = <1>;
+ };
+
+ /* memory: VDD_MEM */
+ ina231@41 {
+ compatible = "ti,ina231";
+ reg = <0x41>;
+ shunt-resistor = <1>;
+ };
+
+ /* GPU: VDD_G3D */
+ ina231@44 {
+ compatible = "ti,ina231";
+ reg = <0x44>;
+ shunt-resistor = <1>;
+ };
+
+ /* A7 cluster: VDD_KFC */
+ ina231@45 {
+ compatible = "ti,ina231";
+ reg = <0x45>;
+ shunt-resistor = <1>;
+ };
+ };
+
i2c_2: i2c@12C8 {
samsung,i2c-sda-delay = <100>;
samsung,i2c-max-bus-freq = <66000>;
--
2.1.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
