Re: [PATCH v2] PPS: Aesthetic tweaks to PPS-related content

2017-08-28 Thread Rodolfo Giometti 

On 26/08/2017 16:49, Robert P. J. Day wrote:


Collection of aesthetic adjustments to various PPS-related files,
directories and Documentation, some quite minor just for the sake of
consistency, including:

  * Updated example of pps device tree node (courtesy Rodolfo G.)
  * "PPS-API" -> "PPS API"
  * "pps_source_info_s" -> "pps_source_info"
  * "ktimer driver" -> "pps-ktimer driver"
  * "ppstest /dev/pps0" -> "ppstest /dev/pps1" to match example
  * Add missing PPS-related entries to MAINTAINERS file
  * Other trivialities

Diff stat:

  Documentation/devicetree/bindings/pps/pps-gpio.txt |  8 ++--
  Documentation/pps/pps.txt  | 44 
+++-
  MAINTAINERS|  3 +++
  include/linux/pps-gpio.h   |  2 +-
  include/linux/pps_kernel.h | 16 +++-
  include/uapi/linux/pps.h   |  4 ++--
  kernel/time/timekeeping.c  |  2 +-
  7 files changed, 43 insertions(+), 36 deletions(-)

Signed-off-by: Robert P. J. Day 


Acked-by: Rodolfo Giometti 


--

HCE Engineering  e-mail: giome...@hce-engineering.it
GNU/Linux Solutions  giome...@enneenne.com
Linux Device Driver  giome...@linux.it
Embedded Systems phone:  +39 349 2432127
UNIX programming skype:  rodolfo.giometti
Cosino Project - the quick prototyping embedded system - www.cosino.it
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it

Re: [PATCH v2] PPS: Aesthetic tweaks to PPS-related content

2017-08-28 Thread Rodolfo Giometti 

On 26/08/2017 16:49, Robert P. J. Day wrote:


Collection of aesthetic adjustments to various PPS-related files,
directories and Documentation, some quite minor just for the sake of
consistency, including:

  * Updated example of pps device tree node (courtesy Rodolfo G.)
  * "PPS-API" -> "PPS API"
  * "pps_source_info_s" -> "pps_source_info"
  * "ktimer driver" -> "pps-ktimer driver"
  * "ppstest /dev/pps0" -> "ppstest /dev/pps1" to match example
  * Add missing PPS-related entries to MAINTAINERS file
  * Other trivialities

Diff stat:

  Documentation/devicetree/bindings/pps/pps-gpio.txt |  8 ++--
  Documentation/pps/pps.txt  | 44 
+++-
  MAINTAINERS|  3 +++
  include/linux/pps-gpio.h   |  2 +-
  include/linux/pps_kernel.h | 16 +++-
  include/uapi/linux/pps.h   |  4 ++--
  kernel/time/timekeeping.c  |  2 +-
  7 files changed, 43 insertions(+), 36 deletions(-)

Signed-off-by: Robert P. J. Day 


Acked-by: Rodolfo Giometti 


--

HCE Engineering  e-mail: giome...@hce-engineering.it
GNU/Linux Solutions  giome...@enneenne.com
Linux Device Driver  giome...@linux.it
Embedded Systems phone:  +39 349 2432127
UNIX programming skype:  rodolfo.giometti
Cosino Project - the quick prototyping embedded system - www.cosino.it
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it

[PATCH v2] PPS: Aesthetic tweaks to PPS-related content

2017-08-26 Thread Robert P. J. Day 

Collection of aesthetic adjustments to various PPS-related files,
directories and Documentation, some quite minor just for the sake of
consistency, including:

 * Updated example of pps device tree node (courtesy Rodolfo G.)
 * "PPS-API" -> "PPS API"
 * "pps_source_info_s" -> "pps_source_info"
 * "ktimer driver" -> "pps-ktimer driver"
 * "ppstest /dev/pps0" -> "ppstest /dev/pps1" to match example
 * Add missing PPS-related entries to MAINTAINERS file
 * Other trivialities

Diff stat:

 Documentation/devicetree/bindings/pps/pps-gpio.txt |  8 ++--
 Documentation/pps/pps.txt  | 44 
+++-
 MAINTAINERS|  3 +++
 include/linux/pps-gpio.h   |  2 +-
 include/linux/pps_kernel.h | 16 +++-
 include/uapi/linux/pps.h   |  4 ++--
 kernel/time/timekeeping.c  |  2 +-
 7 files changed, 43 insertions(+), 36 deletions(-)

Signed-off-by: Robert P. J. Day 
---
  sorry, forgot to add subsystem "PPS" to patch subject line

  any other changes worth throwing in?


diff --git a/Documentation/devicetree/bindings/pps/pps-gpio.txt 
b/Documentation/devicetree/bindings/pps/pps-gpio.txt
index 40bf9c3..0de23b7 100644
--- a/Documentation/devicetree/bindings/pps/pps-gpio.txt
+++ b/Documentation/devicetree/bindings/pps/pps-gpio.txt
@@ -13,8 +13,12 @@ Optional properties:

 Example:
pps {
-   compatible = "pps-gpio";
-   gpios = < 6 0>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_pps>;

+   gpios = < 26 GPIO_ACTIVE_HIGH>;
assert-falling-edge;
+
+   compatible = "pps-gpio";
+   status = "okay";
};
diff --git a/Documentation/pps/pps.txt b/Documentation/pps/pps.txt
index 1fdbd54..99f5d8c 100644
--- a/Documentation/pps/pps.txt
+++ b/Documentation/pps/pps.txt
@@ -48,12 +48,12 @@ problem:
time_pps_create().

 This implies that the source has a /dev/... entry. This assumption is
-ok for the serial and parallel port, where you can do something
+OK for the serial and parallel port, where you can do something
 useful besides(!) the gathering of timestamps as it is the central
-task for a PPS-API. But this assumption does not work for a single
+task for a PPS API. But this assumption does not work for a single
 purpose GPIO line. In this case even basic file-related functionality
 (like read() and write()) makes no sense at all and should not be a
-precondition for the use of a PPS-API.
+precondition for the use of a PPS API.

 The problem can be simply solved if you consider that a PPS source is
 not always connected with a GPS data source.
@@ -88,13 +88,13 @@ Coding example
 --

 To register a PPS source into the kernel you should define a struct
-pps_source_info_s as follows:
+pps_source_info as follows:

 static struct pps_source_info pps_ktimer_info = {
.name = "ktimer",
.path = "",
-   .mode = PPS_CAPTUREASSERT | PPS_OFFSETASSERT | \
-   PPS_ECHOASSERT | \
+   .mode = PPS_CAPTUREASSERT | PPS_OFFSETASSERT |
+   PPS_ECHOASSERT |
PPS_CANWAIT | PPS_TSFMT_TSPEC,
.echo = pps_ktimer_echo,
.owner= THIS_MODULE,
@@ -108,13 +108,13 @@ initialization routine as follows:

 The pps_register_source() prototype is:

-  int pps_register_source(struct pps_source_info_s *info, int default_params)
+  int pps_register_source(struct pps_source_info *info, int default_params)

 where "info" is a pointer to a structure that describes a particular
 PPS source, "default_params" tells the system what the initial default
 parameters for the device should be (it is obvious that these parameters
 must be a subset of ones defined in the struct
-pps_source_info_s which describe the capabilities of the driver).
+pps_source_info which describe the capabilities of the driver).

 Once you have registered a new PPS source into the system you can
 signal an assert event (for example in the interrupt handler routine)
@@ -142,8 +142,10 @@ If the SYSFS filesystem is enabled in the kernel it 
provides a new class:
 Every directory is the ID of a PPS sources defined in the system and
 inside you find several files:

-   $ ls /sys/class/pps/pps0/
-   assert  clear  echo  mode  name  path  subsystem@  uevent
+   $ ls -F /sys/class/pps/pps0/
+   assert devmode   path   subsystem@
+   clear  echo   name   power/ uevent
+

 Inside each "assert" and "clear" file you can find the timestamp and a
 sequence number:
@@ -154,32 +156,32 @@ sequence number:
 Where before the "#" is the timestamp in seconds; after it is the
 sequence number. Other files are:

-* echo: reports if the PPS source has an echo

[PATCH v2] PPS: Aesthetic tweaks to PPS-related content

2017-08-26 Thread Robert P. J. Day 

Collection of aesthetic adjustments to various PPS-related files,
directories and Documentation, some quite minor just for the sake of
consistency, including:

 * Updated example of pps device tree node (courtesy Rodolfo G.)
 * "PPS-API" -> "PPS API"
 * "pps_source_info_s" -> "pps_source_info"
 * "ktimer driver" -> "pps-ktimer driver"
 * "ppstest /dev/pps0" -> "ppstest /dev/pps1" to match example
 * Add missing PPS-related entries to MAINTAINERS file
 * Other trivialities

Diff stat:

 Documentation/devicetree/bindings/pps/pps-gpio.txt |  8 ++--
 Documentation/pps/pps.txt  | 44 
+++-
 MAINTAINERS|  3 +++
 include/linux/pps-gpio.h   |  2 +-
 include/linux/pps_kernel.h | 16 +++-
 include/uapi/linux/pps.h   |  4 ++--
 kernel/time/timekeeping.c  |  2 +-
 7 files changed, 43 insertions(+), 36 deletions(-)

Signed-off-by: Robert P. J. Day 
---
  sorry, forgot to add subsystem "PPS" to patch subject line

  any other changes worth throwing in?


diff --git a/Documentation/devicetree/bindings/pps/pps-gpio.txt 
b/Documentation/devicetree/bindings/pps/pps-gpio.txt
index 40bf9c3..0de23b7 100644
--- a/Documentation/devicetree/bindings/pps/pps-gpio.txt
+++ b/Documentation/devicetree/bindings/pps/pps-gpio.txt
@@ -13,8 +13,12 @@ Optional properties:

 Example:
pps {
-   compatible = "pps-gpio";
-   gpios = < 6 0>;
+   pinctrl-names = "default";
+   pinctrl-0 = <_pps>;

+   gpios = < 26 GPIO_ACTIVE_HIGH>;
assert-falling-edge;
+
+   compatible = "pps-gpio";
+   status = "okay";
};
diff --git a/Documentation/pps/pps.txt b/Documentation/pps/pps.txt
index 1fdbd54..99f5d8c 100644
--- a/Documentation/pps/pps.txt
+++ b/Documentation/pps/pps.txt
@@ -48,12 +48,12 @@ problem:
time_pps_create().

 This implies that the source has a /dev/... entry. This assumption is
-ok for the serial and parallel port, where you can do something
+OK for the serial and parallel port, where you can do something
 useful besides(!) the gathering of timestamps as it is the central
-task for a PPS-API. But this assumption does not work for a single
+task for a PPS API. But this assumption does not work for a single
 purpose GPIO line. In this case even basic file-related functionality
 (like read() and write()) makes no sense at all and should not be a
-precondition for the use of a PPS-API.
+precondition for the use of a PPS API.

 The problem can be simply solved if you consider that a PPS source is
 not always connected with a GPS data source.
@@ -88,13 +88,13 @@ Coding example
 --

 To register a PPS source into the kernel you should define a struct
-pps_source_info_s as follows:
+pps_source_info as follows:

 static struct pps_source_info pps_ktimer_info = {
.name = "ktimer",
.path = "",
-   .mode = PPS_CAPTUREASSERT | PPS_OFFSETASSERT | \
-   PPS_ECHOASSERT | \
+   .mode = PPS_CAPTUREASSERT | PPS_OFFSETASSERT |
+   PPS_ECHOASSERT |
PPS_CANWAIT | PPS_TSFMT_TSPEC,
.echo = pps_ktimer_echo,
.owner= THIS_MODULE,
@@ -108,13 +108,13 @@ initialization routine as follows:

 The pps_register_source() prototype is:

-  int pps_register_source(struct pps_source_info_s *info, int default_params)
+  int pps_register_source(struct pps_source_info *info, int default_params)

 where "info" is a pointer to a structure that describes a particular
 PPS source, "default_params" tells the system what the initial default
 parameters for the device should be (it is obvious that these parameters
 must be a subset of ones defined in the struct
-pps_source_info_s which describe the capabilities of the driver).
+pps_source_info which describe the capabilities of the driver).

 Once you have registered a new PPS source into the system you can
 signal an assert event (for example in the interrupt handler routine)
@@ -142,8 +142,10 @@ If the SYSFS filesystem is enabled in the kernel it 
provides a new class:
 Every directory is the ID of a PPS sources defined in the system and
 inside you find several files:

-   $ ls /sys/class/pps/pps0/
-   assert  clear  echo  mode  name  path  subsystem@  uevent
+   $ ls -F /sys/class/pps/pps0/
+   assert devmode   path   subsystem@
+   clear  echo   name   power/ uevent
+

 Inside each "assert" and "clear" file you can find the timestamp and a
 sequence number:
@@ -154,32 +156,32 @@ sequence number:
 Where before the "#" is the timestamp in seconds; after it is the
 sequence number. Other files are:

-* echo: reports if the PPS source has an echo function or not;
+ *