Re: [RESEND PATCH v2] dt: bindings: as3645a: Fix the example node

[Rob Herring]

On Fri, Dec 08, 2017 at 09:56:18AM -0600, Dan Murphy wrote:
> Resent to include DT maintainers
> 
> On 12/08/2017 09:55 AM, Dan Murphy wrote:
> > Fix the address-cells and size-cells example node
> > to reflect to the correct representation.
> > 
> > Signed-off-by: Dan Murphy 
> > Acked-by: Pavel Machek 
> > ---
> > 
> > v2 - Moved compatible to be first in the node - 
> > https://patchwork.kernel.org/patch/10092937/
> > 
> >  Documentation/devicetree/bindings/leds/ams,as3645a.txt | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt 
> > b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> > index fdc40e354a64..fc7f5f9f234c 100644
> > --- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> > +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> > @@ -59,10 +59,10 @@ Example
> >  ===
> >  
> > as3645a@30 {
> 
> Rob
> 
> Here is an example of the device name being part of the node name.
> 
> Should this be changed as well to leds@30?

Yes, but I misspoke earlier and it should be "led-controller@30"

That can be a separate patch though, so for this one:

Reviewed-by: Rob Herring 

Re: [RESEND PATCH v2] dt: bindings: as3645a: Fix the example node

[Rob Herring]

On Fri, Dec 08, 2017 at 09:56:18AM -0600, Dan Murphy wrote:
> Resent to include DT maintainers
> 
> On 12/08/2017 09:55 AM, Dan Murphy wrote:
> > Fix the address-cells and size-cells example node
> > to reflect to the correct representation.
> > 
> > Signed-off-by: Dan Murphy 
> > Acked-by: Pavel Machek 
> > ---
> > 
> > v2 - Moved compatible to be first in the node - 
> > https://patchwork.kernel.org/patch/10092937/
> > 
> >  Documentation/devicetree/bindings/leds/ams,as3645a.txt | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt 
> > b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> > index fdc40e354a64..fc7f5f9f234c 100644
> > --- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> > +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> > @@ -59,10 +59,10 @@ Example
> >  ===
> >  
> > as3645a@30 {
> 
> Rob
> 
> Here is an example of the device name being part of the node name.
> 
> Should this be changed as well to leds@30?

Yes, but I misspoke earlier and it should be "led-controller@30"

That can be a separate patch though, so for this one:

Reviewed-by: Rob Herring 

Re: [RESEND PATCH v2] dt: bindings: as3645a: Fix the example node

[Dan Murphy]

Resent to include DT maintainers

On 12/08/2017 09:55 AM, Dan Murphy wrote:
> Fix the address-cells and size-cells example node
> to reflect to the correct representation.
> 
> Signed-off-by: Dan Murphy 
> Acked-by: Pavel Machek 
> ---
> 
> v2 - Moved compatible to be first in the node - 
> https://patchwork.kernel.org/patch/10092937/
> 
>  Documentation/devicetree/bindings/leds/ams,as3645a.txt | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt 
> b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> index fdc40e354a64..fc7f5f9f234c 100644
> --- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> @@ -59,10 +59,10 @@ Example
>  ===
>  
>   as3645a@30 {

Rob

Here is an example of the device name being part of the node name.

Should this be changed as well to leds@30?

Dan

> - #address-cells: 1
> - #size-cells: 0
> - reg = <0x30>;
>   compatible = "ams,as3645a";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x30>;
>   flash@0 {
>   reg = <0x0>;
>   flash-timeout-us = <15>;
> 


-- 
--
Dan Murphy

Re: [RESEND PATCH v2] dt: bindings: as3645a: Fix the example node

[Dan Murphy]

Resent to include DT maintainers

On 12/08/2017 09:55 AM, Dan Murphy wrote:
> Fix the address-cells and size-cells example node
> to reflect to the correct representation.
> 
> Signed-off-by: Dan Murphy 
> Acked-by: Pavel Machek 
> ---
> 
> v2 - Moved compatible to be first in the node - 
> https://patchwork.kernel.org/patch/10092937/
> 
>  Documentation/devicetree/bindings/leds/ams,as3645a.txt | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt 
> b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> index fdc40e354a64..fc7f5f9f234c 100644
> --- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> @@ -59,10 +59,10 @@ Example
>  ===
>  
>   as3645a@30 {

Rob

Here is an example of the device name being part of the node name.

Should this be changed as well to leds@30?

Dan

> - #address-cells: 1
> - #size-cells: 0
> - reg = <0x30>;
>   compatible = "ams,as3645a";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x30>;
>   flash@0 {
>   reg = <0x0>;
>   flash-timeout-us = <15>;
> 


-- 
--
Dan Murphy

[RESEND PATCH v2] dt: bindings: as3645a: Fix the example node

[Dan Murphy]

Fix the address-cells and size-cells example node
to reflect to the correct representation.

Signed-off-by: Dan Murphy 
Acked-by: Pavel Machek 
---

v2 - Moved compatible to be first in the node - 
https://patchwork.kernel.org/patch/10092937/

 Documentation/devicetree/bindings/leds/ams,as3645a.txt | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt 
b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
index fdc40e354a64..fc7f5f9f234c 100644
--- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
+++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
@@ -59,10 +59,10 @@ Example
 ===
 
as3645a@30 {
-   #address-cells: 1
-   #size-cells: 0
-   reg = <0x30>;
compatible = "ams,as3645a";
+   #address-cells = <1>;
+   #size-cells = <0>;
+   reg = <0x30>;
flash@0 {
reg = <0x0>;
flash-timeout-us = <15>;
-- 
2.15.0.124.g7668cbc60

[RESEND PATCH v2] dt: bindings: as3645a: Fix the example node

[Dan Murphy]

Fix the address-cells and size-cells example node
to reflect to the correct representation.

Signed-off-by: Dan Murphy 
Acked-by: Pavel Machek 
---

v2 - Moved compatible to be first in the node - 
https://patchwork.kernel.org/patch/10092937/

 Documentation/devicetree/bindings/leds/ams,as3645a.txt | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt 
b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
index fdc40e354a64..fc7f5f9f234c 100644
--- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
+++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
@@ -59,10 +59,10 @@ Example
 ===
 
as3645a@30 {
-   #address-cells: 1
-   #size-cells: 0
-   reg = <0x30>;
compatible = "ams,as3645a";
+   #address-cells = <1>;
+   #size-cells = <0>;
+   reg = <0x30>;
flash@0 {
reg = <0x0>;
flash-timeout-us = <15>;
-- 
2.15.0.124.g7668cbc60

Re: [PATCH v2] dt: bindings: as3645a: Fix the example node

[Pavel Machek]

On Thu 2017-12-07 06:50:12, Dan Murphy wrote:
> Fix the address-cells and size-cells example node
> to reflect to the correct representation.
> 
> Signed-off-by: Dan Murphy 

Acked-by: Pavel Machek 

> +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> @@ -59,10 +59,10 @@ Example
>  ===
>  
>   as3645a@30 {
> - #address-cells: 1
> - #size-cells: 0
> - reg = <0x30>;
>   compatible = "ams,as3645a";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x30>;
>   flash@0 {
>   reg = <0x0>;
>   flash-timeout-us = <15>;

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


signature.asc
Description: Digital signature

Re: [PATCH v2] dt: bindings: as3645a: Fix the example node

[Pavel Machek]

On Thu 2017-12-07 06:50:12, Dan Murphy wrote:
> Fix the address-cells and size-cells example node
> to reflect to the correct representation.
> 
> Signed-off-by: Dan Murphy 

Acked-by: Pavel Machek 

> +++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
> @@ -59,10 +59,10 @@ Example
>  ===
>  
>   as3645a@30 {
> - #address-cells: 1
> - #size-cells: 0
> - reg = <0x30>;
>   compatible = "ams,as3645a";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0x30>;
>   flash@0 {
>   reg = <0x0>;
>   flash-timeout-us = <15>;

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


signature.asc
Description: Digital signature

[PATCH v2] dt: bindings: as3645a: Fix the example node

[Dan Murphy]

Fix the address-cells and size-cells example node
to reflect to the correct representation.

Signed-off-by: Dan Murphy 
---

v2 - Moved compatible to be first in the node - 
https://patchwork.kernel.org/patch/10092937/

 Documentation/devicetree/bindings/leds/ams,as3645a.txt | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt 
b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
index fdc40e354a64..fc7f5f9f234c 100644
--- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
+++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
@@ -59,10 +59,10 @@ Example
 ===
 
as3645a@30 {
-   #address-cells: 1
-   #size-cells: 0
-   reg = <0x30>;
compatible = "ams,as3645a";
+   #address-cells = <1>;
+   #size-cells = <0>;
+   reg = <0x30>;
flash@0 {
reg = <0x0>;
flash-timeout-us = <15>;
-- 
2.15.0.124.g7668cbc60

[PATCH v2] dt: bindings: as3645a: Fix the example node

[Dan Murphy]

Fix the address-cells and size-cells example node
to reflect to the correct representation.

Signed-off-by: Dan Murphy 
---

v2 - Moved compatible to be first in the node - 
https://patchwork.kernel.org/patch/10092937/

 Documentation/devicetree/bindings/leds/ams,as3645a.txt | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/leds/ams,as3645a.txt 
b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
index fdc40e354a64..fc7f5f9f234c 100644
--- a/Documentation/devicetree/bindings/leds/ams,as3645a.txt
+++ b/Documentation/devicetree/bindings/leds/ams,as3645a.txt
@@ -59,10 +59,10 @@ Example
 ===
 
as3645a@30 {
-   #address-cells: 1
-   #size-cells: 0
-   reg = <0x30>;
compatible = "ams,as3645a";
+   #address-cells = <1>;
+   #size-cells = <0>;
+   reg = <0x30>;
flash@0 {
reg = <0x0>;
flash-timeout-us = <15>;
-- 
2.15.0.124.g7668cbc60