Re: [PATCH v2] irqchip/gic-v3-its: Free unused vpt_page when alloc vpe table fail

[Marc Zyngier]

On Fri, 26 Jul 2019 10:32:57 +0100,
Shaokun Zhang  wrote:
> 
> From: Nianyao Tang 
> 
> In its_vpe_init, when its_alloc_vpe_table fails, we should free
> vpt_page allocated just before, instead of vpe->vpt_page.
> Let's fix it.
> 
> Cc: Thomas Gleixner 
> Cc: Jason Cooper 
> Cc: Marc Zyngier 
> Signed-off-by: Nianyao Tang 
> Signed-off-by: Shaokun Zhang 
> ---
>  drivers/irqchip/irq-gic-v3-its.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-gic-v3-its.c 
> b/drivers/irqchip/irq-gic-v3-its.c
> index 730fbe0e2a9d..1b5c3672aea2 100644
> --- a/drivers/irqchip/irq-gic-v3-its.c
> +++ b/drivers/irqchip/irq-gic-v3-its.c
> @@ -3010,7 +3010,7 @@ static int its_vpe_init(struct its_vpe *vpe)
>  
>   if (!its_alloc_vpe_table(vpe_id)) {
>   its_vpe_id_free(vpe_id);
> - its_free_pending_table(vpe->vpt_page);
> + its_free_pending_table(vpt_page);
>   return -ENOMEM;
>   }
>  
> -- 
> 2.7.4
> 

Applied, thanks.

M.

-- 
Jazz is not dead, it just smells funny.

[PATCH v2] irqchip/gic-v3-its: Free unused vpt_page when alloc vpe table fail

[Shaokun Zhang]

From: Nianyao Tang 

In its_vpe_init, when its_alloc_vpe_table fails, we should free
vpt_page allocated just before, instead of vpe->vpt_page.
Let's fix it.

Cc: Thomas Gleixner 
Cc: Jason Cooper 
Cc: Marc Zyngier 
Signed-off-by: Nianyao Tang 
Signed-off-by: Shaokun Zhang 
---
 drivers/irqchip/irq-gic-v3-its.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
index 730fbe0e2a9d..1b5c3672aea2 100644
--- a/drivers/irqchip/irq-gic-v3-its.c
+++ b/drivers/irqchip/irq-gic-v3-its.c
@@ -3010,7 +3010,7 @@ static int its_vpe_init(struct its_vpe *vpe)
 
if (!its_alloc_vpe_table(vpe_id)) {
its_vpe_id_free(vpe_id);
-   its_free_pending_table(vpe->vpt_page);
+   its_free_pending_table(vpt_page);
return -ENOMEM;
}
 
-- 
2.7.4