Re: [PATCH v2] staging: media: zoran: remove and add '*' in long(multi-line) comments
On 11/04/2021 13:47, Mitali Borkar wrote:
> On Fri, Apr 09, 2021 at 12:53:35PM +0200, Hans Verkuil wrote:
>> On 09/04/2021 12:49, Mitali Borkar wrote:
>>> Added '*' before every line inside long(multi-line) comments. Removed
>>> '*/' from end of the comment line and added to next line as per linux
>>> kernel coding style. Aligned '*' accordingly to make code neater.
>>>
>>> Signed-off-by: Mitali Borkar
>>> ---
>>>
>>> Changes from v1:- Changes made in code according to linux kernel coding
>>> style for long(multi-line) comments.
>>>
>>> drivers/staging/media/zoran/zr36050.c | 138 +++---
>>> 1 file changed, 81 insertions(+), 57 deletions(-)
>>>
>>> diff --git a/drivers/staging/media/zoran/zr36050.c
>>> b/drivers/staging/media/zoran/zr36050.c
>>> index 663ac2b3434e..703064009c6b 100644
>>> --- a/drivers/staging/media/zoran/zr36050.c
>>> +++ b/drivers/staging/media/zoran/zr36050.c
>>> @@ -25,7 +25,8 @@
>>> #include "videocodec.h"
>>>
>>> /* it doesn't make sense to have more than 20 or so,
>>
>> The coding style says that /* is on a line of its own. So change that too.
>>
>
> Sir, I have sent v3 patch for this two days ago and didnt received reply
> til now, should I resend that patch?
It was weekend, you know :-)
If you don't hear from me for more than a week, and the patch state in
patchwork (https://patchwork.linuxtv.org/project/linux-media/list/) is still
'New', then ping me, i.e. just reply to your patch with a 'Gentle ping!'
message.
Regards,
Hans
>
>> Regards,
>>
>> Hans
>>
>>> - * just to prevent some unwanted loops */
>>> + * just to prevent some unwanted loops
>>> + */
>>> #define MAX_CODECS 20
>>>
>>> /* amount of chips attached via this driver */
>>> @@ -44,9 +45,10 @@ MODULE_PARM_DESC(debug, "Debug level (0-4)");
>>>
>>> /*
>>> =
>>> * Local hardware I/O functions:
>>> -
>>> - read/write via codec layer (registers are located in the master device)
>>> -
>>> = */
>>> + *
>>> + * read/write via codec layer (registers are located in the master device)
>>> + *
>>> =
>>> + */
>>>
>>> /* read and write functions */
>>> static u8 zr36050_read(struct zr36050 *ptr, u16 reg)
>>> @@ -81,9 +83,10 @@ static void zr36050_write(struct zr36050 *ptr, u16 reg,
>>> u8 value)
>>>
>>> /*
>>> =
>>> * Local helper function:
>>> -
>>> - status read
>>> -
>>> = */
>>> + *
>>> + * status read
>>> + *
>>> =
>>> + */
>>>
>>> /* status is kept in datastructure */
>>> static u8 zr36050_read_status1(struct zr36050 *ptr)
>>> @@ -96,9 +99,10 @@ static u8 zr36050_read_status1(struct zr36050 *ptr)
>>>
>>> /*
>>> =
>>> * Local helper function:
>>> -
>>> - scale factor read
>>> -
>>> = */
>>> + *
>>> + * scale factor read
>>> + *
>>> =
>>> + */
>>>
>>> /* scale factor is kept in datastructure */
>>> static u16 zr36050_read_scalefactor(struct zr36050 *ptr)
>>> @@ -113,9 +117,10 @@ static u16 zr36050_read_scalefactor(struct zr36050
>>> *ptr)
>>>
>>> /*
>>> =
>>> * Local helper function:
>>> -
>>> - wait if codec is ready to proceed (end of processing) or time is over
>>> -
>>> = */
>>> + *
>>> + * wait if codec is ready to proceed (end of processing) or time is over
>>> + *
>>> =
>>> + */
>>>
>>> static void zr36050_wait_end(struct zr36050 *ptr)
>>> {
>>> @@ -134,9 +139,10 @@ static void zr36050_wait_end(struct zr36050 *ptr)
>>>
>>> /*
>>> =
>>> * Local helper function:
>>> -
>>> - basic test of "connectivity", writes/reads to/from memory the SOF marker
>>> -
>>> = */
>>> + *
>>> + * basic test of "connectivity", writes/reads to/from memory the SOF
>>> marker
>>> + *
>>> =
>>> + */
>>>
>>> static int zr36050_basic_test(struct zr36050 *ptr)
>>> {
>>> @@ -175,9 +181,10 @@ static int zr36050_basic_test(struct zr36050 *ptr)
>>>
>>> /*
>>> =
>>> * Local helper
Re: [PATCH v2] staging: media: zoran: remove and add '*' in long(multi-line) comments
On Fri, Apr 09, 2021 at 12:53:35PM +0200, Hans Verkuil wrote:
> On 09/04/2021 12:49, Mitali Borkar wrote:
> > Added '*' before every line inside long(multi-line) comments. Removed
> > '*/' from end of the comment line and added to next line as per linux
> > kernel coding style. Aligned '*' accordingly to make code neater.
> >
> > Signed-off-by: Mitali Borkar
> > ---
> >
> > Changes from v1:- Changes made in code according to linux kernel coding
> > style for long(multi-line) comments.
> >
> > drivers/staging/media/zoran/zr36050.c | 138 +++---
> > 1 file changed, 81 insertions(+), 57 deletions(-)
> >
> > diff --git a/drivers/staging/media/zoran/zr36050.c
> > b/drivers/staging/media/zoran/zr36050.c
> > index 663ac2b3434e..703064009c6b 100644
> > --- a/drivers/staging/media/zoran/zr36050.c
> > +++ b/drivers/staging/media/zoran/zr36050.c
> > @@ -25,7 +25,8 @@
> > #include "videocodec.h"
> >
> > /* it doesn't make sense to have more than 20 or so,
>
> The coding style says that /* is on a line of its own. So change that too.
>
Sir, I have sent v3 patch for this two days ago and didnt received reply
til now, should I resend that patch?
> Regards,
>
> Hans
>
> > - * just to prevent some unwanted loops */
> > + * just to prevent some unwanted loops
> > + */
> > #define MAX_CODECS 20
> >
> > /* amount of chips attached via this driver */
> > @@ -44,9 +45,10 @@ MODULE_PARM_DESC(debug, "Debug level (0-4)");
> >
> > /*
> > =
> > * Local hardware I/O functions:
> > -
> > - read/write via codec layer (registers are located in the master device)
> > -
> > = */
> > + *
> > + * read/write via codec layer (registers are located in the master device)
> > + *
> > =
> > + */
> >
> > /* read and write functions */
> > static u8 zr36050_read(struct zr36050 *ptr, u16 reg)
> > @@ -81,9 +83,10 @@ static void zr36050_write(struct zr36050 *ptr, u16 reg,
> > u8 value)
> >
> > /*
> > =
> > * Local helper function:
> > -
> > - status read
> > -
> > = */
> > + *
> > + * status read
> > + *
> > =
> > + */
> >
> > /* status is kept in datastructure */
> > static u8 zr36050_read_status1(struct zr36050 *ptr)
> > @@ -96,9 +99,10 @@ static u8 zr36050_read_status1(struct zr36050 *ptr)
> >
> > /*
> > =
> > * Local helper function:
> > -
> > - scale factor read
> > -
> > = */
> > + *
> > + * scale factor read
> > + *
> > =
> > + */
> >
> > /* scale factor is kept in datastructure */
> > static u16 zr36050_read_scalefactor(struct zr36050 *ptr)
> > @@ -113,9 +117,10 @@ static u16 zr36050_read_scalefactor(struct zr36050
> > *ptr)
> >
> > /*
> > =
> > * Local helper function:
> > -
> > - wait if codec is ready to proceed (end of processing) or time is over
> > -
> > = */
> > + *
> > + * wait if codec is ready to proceed (end of processing) or time is over
> > + *
> > =
> > + */
> >
> > static void zr36050_wait_end(struct zr36050 *ptr)
> > {
> > @@ -134,9 +139,10 @@ static void zr36050_wait_end(struct zr36050 *ptr)
> >
> > /*
> > =
> > * Local helper function:
> > -
> > - basic test of "connectivity", writes/reads to/from memory the SOF marker
> > -
> > = */
> > + *
> > + * basic test of "connectivity", writes/reads to/from memory the SOF
> > marker
> > + *
> > =
> > + */
> >
> > static int zr36050_basic_test(struct zr36050 *ptr)
> > {
> > @@ -175,9 +181,10 @@ static int zr36050_basic_test(struct zr36050 *ptr)
> >
> > /*
> > =
> > * Local helper function:
> > -
> > - simple loop for pushing the init datasets
> > -
> > = */
> > + *
> > + * simple loop for pushing the init datasets
> > + *
> > =
> > + */
> >
> > static int
Re: [PATCH v2] staging: media: zoran: remove and add '*' in long(multi-line) comments
On 09/04/2021 12:49, Mitali Borkar wrote:
> Added '*' before every line inside long(multi-line) comments. Removed
> '*/' from end of the comment line and added to next line as per linux
> kernel coding style. Aligned '*' accordingly to make code neater.
>
> Signed-off-by: Mitali Borkar
> ---
>
> Changes from v1:- Changes made in code according to linux kernel coding
> style for long(multi-line) comments.
>
> drivers/staging/media/zoran/zr36050.c | 138 +++---
> 1 file changed, 81 insertions(+), 57 deletions(-)
>
> diff --git a/drivers/staging/media/zoran/zr36050.c
> b/drivers/staging/media/zoran/zr36050.c
> index 663ac2b3434e..703064009c6b 100644
> --- a/drivers/staging/media/zoran/zr36050.c
> +++ b/drivers/staging/media/zoran/zr36050.c
> @@ -25,7 +25,8 @@
> #include "videocodec.h"
>
> /* it doesn't make sense to have more than 20 or so,
The coding style says that /* is on a line of its own. So change that too.
Regards,
Hans
> - * just to prevent some unwanted loops */
> + * just to prevent some unwanted loops
> + */
> #define MAX_CODECS 20
>
> /* amount of chips attached via this driver */
> @@ -44,9 +45,10 @@ MODULE_PARM_DESC(debug, "Debug level (0-4)");
>
> /* =
> * Local hardware I/O functions:
> -
> - read/write via codec layer (registers are located in the master device)
> - =
> */
> + *
> + * read/write via codec layer (registers are located in the master device)
> + * =
> + */
>
> /* read and write functions */
> static u8 zr36050_read(struct zr36050 *ptr, u16 reg)
> @@ -81,9 +83,10 @@ static void zr36050_write(struct zr36050 *ptr, u16 reg, u8
> value)
>
> /* =
> * Local helper function:
> -
> - status read
> - =
> */
> + *
> + * status read
> + * =
> + */
>
> /* status is kept in datastructure */
> static u8 zr36050_read_status1(struct zr36050 *ptr)
> @@ -96,9 +99,10 @@ static u8 zr36050_read_status1(struct zr36050 *ptr)
>
> /* =
> * Local helper function:
> -
> - scale factor read
> - =
> */
> + *
> + * scale factor read
> + * =
> + */
>
> /* scale factor is kept in datastructure */
> static u16 zr36050_read_scalefactor(struct zr36050 *ptr)
> @@ -113,9 +117,10 @@ static u16 zr36050_read_scalefactor(struct zr36050 *ptr)
>
> /* =
> * Local helper function:
> -
> - wait if codec is ready to proceed (end of processing) or time is over
> - =
> */
> + *
> + * wait if codec is ready to proceed (end of processing) or time is over
> + * =
> + */
>
> static void zr36050_wait_end(struct zr36050 *ptr)
> {
> @@ -134,9 +139,10 @@ static void zr36050_wait_end(struct zr36050 *ptr)
>
> /* =
> * Local helper function:
> -
> - basic test of "connectivity", writes/reads to/from memory the SOF marker
> - =
> */
> + *
> + * basic test of "connectivity", writes/reads to/from memory the SOF marker
> + * =
> + */
>
> static int zr36050_basic_test(struct zr36050 *ptr)
> {
> @@ -175,9 +181,10 @@ static int zr36050_basic_test(struct zr36050 *ptr)
>
> /* =
> * Local helper function:
> -
> - simple loop for pushing the init datasets
> - =
> */
> + *
> + * simple loop for pushing the init datasets
> + * =
> + */
>
> static int zr36050_pushit(struct zr36050 *ptr, u16 startreg, u16 len, const
> char *data)
> {
> @@ -193,14 +200,15 @@ static int zr36050_pushit(struct zr36050 *ptr, u16
> startreg, u16 len, const char
>
> /* =
> * Basic datasets:
> -
> - jpeg baseline setup data (you find it on lots places in internet, or just
> - extract it from any regular .jpg image...)
> -
> - Could be variable, but until it's not needed it they
[PATCH v2] staging: media: zoran: remove and add '*' in long(multi-line) comments
Added '*' before every line inside long(multi-line) comments. Removed
'*/' from end of the comment line and added to next line as per linux
kernel coding style. Aligned '*' accordingly to make code neater.
Signed-off-by: Mitali Borkar
---
Changes from v1:- Changes made in code according to linux kernel coding
style for long(multi-line) comments.
drivers/staging/media/zoran/zr36050.c | 138 +++---
1 file changed, 81 insertions(+), 57 deletions(-)
diff --git a/drivers/staging/media/zoran/zr36050.c
b/drivers/staging/media/zoran/zr36050.c
index 663ac2b3434e..703064009c6b 100644
--- a/drivers/staging/media/zoran/zr36050.c
+++ b/drivers/staging/media/zoran/zr36050.c
@@ -25,7 +25,8 @@
#include "videocodec.h"
/* it doesn't make sense to have more than 20 or so,
- * just to prevent some unwanted loops */
+ * just to prevent some unwanted loops
+ */
#define MAX_CODECS 20
/* amount of chips attached via this driver */
@@ -44,9 +45,10 @@ MODULE_PARM_DESC(debug, "Debug level (0-4)");
/* =
* Local hardware I/O functions:
-
- read/write via codec layer (registers are located in the master device)
- = */
+ *
+ * read/write via codec layer (registers are located in the master device)
+ * =
+ */
/* read and write functions */
static u8 zr36050_read(struct zr36050 *ptr, u16 reg)
@@ -81,9 +83,10 @@ static void zr36050_write(struct zr36050 *ptr, u16 reg, u8
value)
/* =
* Local helper function:
-
- status read
- = */
+ *
+ * status read
+ * =
+ */
/* status is kept in datastructure */
static u8 zr36050_read_status1(struct zr36050 *ptr)
@@ -96,9 +99,10 @@ static u8 zr36050_read_status1(struct zr36050 *ptr)
/* =
* Local helper function:
-
- scale factor read
- = */
+ *
+ * scale factor read
+ * =
+ */
/* scale factor is kept in datastructure */
static u16 zr36050_read_scalefactor(struct zr36050 *ptr)
@@ -113,9 +117,10 @@ static u16 zr36050_read_scalefactor(struct zr36050 *ptr)
/* =
* Local helper function:
-
- wait if codec is ready to proceed (end of processing) or time is over
- = */
+ *
+ * wait if codec is ready to proceed (end of processing) or time is over
+ * =
+ */
static void zr36050_wait_end(struct zr36050 *ptr)
{
@@ -134,9 +139,10 @@ static void zr36050_wait_end(struct zr36050 *ptr)
/* =
* Local helper function:
-
- basic test of "connectivity", writes/reads to/from memory the SOF marker
- = */
+ *
+ * basic test of "connectivity", writes/reads to/from memory the SOF marker
+ * =
+ */
static int zr36050_basic_test(struct zr36050 *ptr)
{
@@ -175,9 +181,10 @@ static int zr36050_basic_test(struct zr36050 *ptr)
/* =
* Local helper function:
-
- simple loop for pushing the init datasets
- = */
+ *
+ * simple loop for pushing the init datasets
+ * =
+ */
static int zr36050_pushit(struct zr36050 *ptr, u16 startreg, u16 len, const
char *data)
{
@@ -193,14 +200,15 @@ static int zr36050_pushit(struct zr36050 *ptr, u16
startreg, u16 len, const char
/* =
* Basic datasets:
-
- jpeg baseline setup data (you find it on lots places in internet, or just
- extract it from any regular .jpg image...)
-
- Could be variable, but until it's not needed it they are just fixed to save
- memory. Otherwise expand zr36050 structure with arrays, push the values to
- it and initialize from there, as e.g. the linux zr36057/60 driver does it.
- = */
+ *
+ * jpeg baseline setup data (you find it on lots places in internet, or just
+ * extract it from any regular .jpg image...)
+ *
+ * Could be
