Re: [PATCH v2 -next] tpm: Fix the type of the return value in calc_tpm2_event_size()
On Wed, Feb 20, 2019 at 09:00:42AM -0700, Jason Gunthorpe wrote:
> On Wed, Feb 20, 2019 at 08:31:59AM +0200, Jarkko Sakkinen wrote:
> > On Wed, Feb 20, 2019 at 10:23:00AM +0800, YueHaibing wrote:
> > > calc_tpm2_event_size() has an invalid signature because
> > > it returns a 'size_t' where as its signature says that
> > > it returns 'int'.
> > >
> > > Fixes: 4d23cc323cdb ("tpm: add securityfs support for TPM 2.0 firmware
> > > event log")
> > > Suggested-by: Jarkko Sakkinen
> > > Signed-off-by: YueHaibing
> >
> > Two remarks:
> >
> > - git config user.name "Yue Haibing"
> > - "Cc: sta...@vger.kernel.org" before the fixes tag.
>
> 'Theoretical' bug fixes are not suitable for stable
AFAIK there is no hard rule here. For this one line change I think it
makes sense to backport it even if it is only for avoiding conflicts
with future backports.
/Jarkko
Re: [PATCH v2 -next] tpm: Fix the type of the return value in calc_tpm2_event_size()
On Wed, Feb 20, 2019 at 08:31:59AM +0200, Jarkko Sakkinen wrote:
> On Wed, Feb 20, 2019 at 10:23:00AM +0800, YueHaibing wrote:
> > calc_tpm2_event_size() has an invalid signature because
> > it returns a 'size_t' where as its signature says that
> > it returns 'int'.
> >
> > Fixes: 4d23cc323cdb ("tpm: add securityfs support for TPM 2.0 firmware
> > event log")
> > Suggested-by: Jarkko Sakkinen
> > Signed-off-by: YueHaibing
>
> Two remarks:
>
> - git config user.name "Yue Haibing"
> - "Cc: sta...@vger.kernel.org" before the fixes tag.
'Theoretical' bug fixes are not suitable for stable
Jason
Re: [PATCH v2 -next] tpm: Fix the type of the return value in calc_tpm2_event_size()
On Wed, Feb 20, 2019 at 10:23:00AM +0800, YueHaibing wrote:
> calc_tpm2_event_size() has an invalid signature because
> it returns a 'size_t' where as its signature says that
> it returns 'int'.
>
> Fixes: 4d23cc323cdb ("tpm: add securityfs support for TPM 2.0 firmware event
> log")
> Suggested-by: Jarkko Sakkinen
> Signed-off-by: YueHaibing
Two remarks:
- git config user.name "Yue Haibing"
- "Cc: sta...@vger.kernel.org" before the fixes tag.
Thanks.
/Jarkko
[PATCH v2 -next] tpm: Fix the type of the return value in calc_tpm2_event_size()
calc_tpm2_event_size() has an invalid signature because
it returns a 'size_t' where as its signature says that
it returns 'int'.
Fixes: 4d23cc323cdb ("tpm: add securityfs support for TPM 2.0 firmware event
log")
Suggested-by: Jarkko Sakkinen
Signed-off-by: YueHaibing
---
v2: modify patch title and commit message as Jarkko suggested
---
drivers/char/tpm/eventlog/tpm2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/char/tpm/eventlog/tpm2.c b/drivers/char/tpm/eventlog/tpm2.c
index d8b7713..f824563 100644
--- a/drivers/char/tpm/eventlog/tpm2.c
+++ b/drivers/char/tpm/eventlog/tpm2.c
@@ -37,8 +37,8 @@
*
* Returns size of the event. If it is an invalid event, returns 0.
*/
-static int calc_tpm2_event_size(struct tcg_pcr_event2_head *event,
- struct tcg_pcr_event *event_header)
+static size_t calc_tpm2_event_size(struct tcg_pcr_event2_head *event,
+ struct tcg_pcr_event *event_header)
{
struct tcg_efi_specid_event_head *efispecid;
struct tcg_event_field *event_field;
--
2.7.0
