Re: [PATCH v2 0/1] mm/memory-failure: Poison read receives SIGKILL instead of SIGBUS issue

2019-07-24 Thread Jane Chu

On 7/24/2019 3:52 PM, Dan Williams wrote:

On Wed, Jul 24, 2019 at 3:35 PM Jane Chu  wrote:


Changes in v2:
  - move 'tk' allocations internal to add_to_kill(), suggested by Dan;


Oh, sorry if it wasn't clear, this should move to its own patch that
only does the cleanup, and then the follow on fix patch becomes
smaller and more straightforward.



Make sense, thanks! I'll split up the patch next.

thanks,
-jane


Re: [PATCH v2 0/1] mm/memory-failure: Poison read receives SIGKILL instead of SIGBUS issue

2019-07-24 Thread Dan Williams
On Wed, Jul 24, 2019 at 3:35 PM Jane Chu  wrote:
>
> Changes in v2:
>  - move 'tk' allocations internal to add_to_kill(), suggested by Dan;

Oh, sorry if it wasn't clear, this should move to its own patch that
only does the cleanup, and then the follow on fix patch becomes
smaller and more straightforward.


[PATCH v2 0/1] mm/memory-failure: Poison read receives SIGKILL instead of SIGBUS issue

2019-07-24 Thread Jane Chu
Changes in v2:
 - move 'tk' allocations internal to add_to_kill(), suggested by Dan;
 - ran checkpatch.pl check, pointed out by Matthew;
 - Noaya pointed out that v1 would have missed the SIGKILL
   if "tk->addr == -EFAULT", since the code returns early.
   Incorporated Noaya's suggestion, also, skip VMAs where
   "tk->size_shift == 0" for zone device page, and deliver SIGBUS
   when "tk->size_shift != 0" so the payload is helpful;
 - added Suggested-by: Naoya Horiguchi 


Jane Chu (1):
  mm/memory-failure: Poison read receives SIGKILL instead of SIGBUS if
mmaped more than once

 mm/memory-failure.c | 62 ++---
 1 file changed, 26 insertions(+), 36 deletions(-)

-- 
1.8.3.1