Re: [PATCH v2 0/2] Fix __GFP_ZERO vs constructor
On Thu 12-04-18 12:24:24, Matthew Wilcox wrote: > On Thu, Apr 12, 2018 at 09:54:51AM +0900, Minchan Kim wrote: > > Matthew, > > > > Please Cced relevant people so they know what's going on the problem > > they spent on much time. Everyone doesn't keep an eye on mailing list. > > My apologies; I assumed that git send-email would pick up the people > named in the changelog. I have now read the source code and discovered > it only picks up the people listed in Signed-off-by: and Cc:. That > surprises me; I'll submit a patch. I remember that there was a discussion to add support for more $Foo-by: $EMAIL but I do not remember the outcome of the discussion and from a quick glance into the perl disaster it doesn't seem to handle generic tags. I am using the following $ cat cc-cmd.sh #!/bin/bash if [[ $1 == *gitsendemail.msg* || $1 == *cover-letter* ]]; then grep '<.*@.*>' -h *.patch | sed 's/^.*: //' | sort | uniq else grep '<.*@.*>' -h $1 | sed 's/^.*: //' | sort | uniq fi and use it as --cc-cmd= -- Michal Hocko SUSE Labs
Re: [PATCH v2 0/2] Fix __GFP_ZERO vs constructor
On Thu, Apr 12, 2018 at 09:54:51AM +0900, Minchan Kim wrote: > Matthew, > > Please Cced relevant people so they know what's going on the problem > they spent on much time. Everyone doesn't keep an eye on mailing list. My apologies; I assumed that git send-email would pick up the people named in the changelog. I have now read the source code and discovered it only picks up the people listed in Signed-off-by: and Cc:. That surprises me; I'll submit a patch. > On Tue, Apr 10, 2018 at 11:03:18PM -0700, Matthew Wilcox wrote: > > From: Matthew Wilcox > > > > v1->v2: > > - Added review/ack tags (thanks!) > > - Switched the order of the patches > > - Reworded commit message of the patch which actually fixes the bug > > - Moved slab debug patches under CONFIG_DEBUG_VM to check _every_ > >allocation and added checks in the slowpath for the allocations which > >end up allocating a page. > > > > Matthew Wilcox (2): > > Fix NULL pointer in page_cache_tree_insert > > slab: __GFP_ZERO is incompatible with a constructor > > > > mm/filemap.c | 9 - > > mm/slab.c| 7 --- > > mm/slab.h| 7 +++ > > mm/slob.c| 4 +++- > > mm/slub.c| 5 +++-- > > 5 files changed, 21 insertions(+), 11 deletions(-) > > > > -- > > 2.16.3 > > >
Re: [PATCH v2 0/2] Fix __GFP_ZERO vs constructor
Matthew, Please Cced relevant people so they know what's going on the problem they spent on much time. Everyone doesn't keep an eye on mailing list. On Tue, Apr 10, 2018 at 11:03:18PM -0700, Matthew Wilcox wrote: > From: Matthew Wilcox > > v1->v2: > - Added review/ack tags (thanks!) > - Switched the order of the patches > - Reworded commit message of the patch which actually fixes the bug > - Moved slab debug patches under CONFIG_DEBUG_VM to check _every_ >allocation and added checks in the slowpath for the allocations which >end up allocating a page. > > Matthew Wilcox (2): > Fix NULL pointer in page_cache_tree_insert > slab: __GFP_ZERO is incompatible with a constructor > > mm/filemap.c | 9 - > mm/slab.c| 7 --- > mm/slab.h| 7 +++ > mm/slob.c| 4 +++- > mm/slub.c| 5 +++-- > 5 files changed, 21 insertions(+), 11 deletions(-) > > -- > 2.16.3 >
[PATCH v2 0/2] Fix __GFP_ZERO vs constructor
From: Matthew Wilcox v1->v2: - Added review/ack tags (thanks!) - Switched the order of the patches - Reworded commit message of the patch which actually fixes the bug - Moved slab debug patches under CONFIG_DEBUG_VM to check _every_ allocation and added checks in the slowpath for the allocations which end up allocating a page. Matthew Wilcox (2): Fix NULL pointer in page_cache_tree_insert slab: __GFP_ZERO is incompatible with a constructor mm/filemap.c | 9 - mm/slab.c| 7 --- mm/slab.h| 7 +++ mm/slob.c| 4 +++- mm/slub.c| 5 +++-- 5 files changed, 21 insertions(+), 11 deletions(-) -- 2.16.3
