Re: [PATCH v2 0/2] block,scsi: fixup blk_get_request dead queue scenarios
Joe Lawrence writes: > On Thu, 26 Jun 2014, Jeff Moyer wrote: >> Thanks, Jens. Joe, the patches don't apply anymore... would you mind >> sending an updated set so Jens doesn't have to do the fixups? I think >> you also need to convert blk_mq_alloc_request, I didn't see that in your >> patch. > > Hi Jeff, > > I have a new set that applies on top of 3.16-rc2... but before posting, I > wasn't sure what needs to be converted w/regard to blk_mq_alloc_request. > As far as I can tell, the new multi-queue block IO queueing implementation > via blk_mq_alloc_request should be safe from this bug as it doesn't > include any dead queue checks that introduce early exits. Hi, Joe, blk_mq_alloc_request will return NULL if blk_mq_queue_enter() returns non-zero. Cheers, Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 0/2] block,scsi: fixup blk_get_request dead queue scenarios
Joe Lawrence joe.lawre...@stratus.com writes: On Thu, 26 Jun 2014, Jeff Moyer wrote: Thanks, Jens. Joe, the patches don't apply anymore... would you mind sending an updated set so Jens doesn't have to do the fixups? I think you also need to convert blk_mq_alloc_request, I didn't see that in your patch. Hi Jeff, I have a new set that applies on top of 3.16-rc2... but before posting, I wasn't sure what needs to be converted w/regard to blk_mq_alloc_request. As far as I can tell, the new multi-queue block IO queueing implementation via blk_mq_alloc_request should be safe from this bug as it doesn't include any dead queue checks that introduce early exits. Hi, Joe, blk_mq_alloc_request will return NULL if blk_mq_queue_enter() returns non-zero. Cheers, Jeff -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 0/2] block,scsi: fixup blk_get_request dead queue scenarios
On Thu, 26 Jun 2014, Jeff Moyer wrote: > Jens Axboe writes: > > > On 2014-06-26 10:08, Jeff Moyer wrote: > >> Joe Lawrence writes: > >> > >>> v1->v2: incorporate Jeff's feedback in bsg_map_hdr() and Reviewed-by > >>> tags. > >>> > >>> Joe Lawrence (2): > >>>block,scsi: verify return pointer from blk_get_request > >>>block,scsi: convert and handle ERR_PTR from blk_get_request > >> > >> Jens, > >> > >> Can you pick this series up? It actually fixes a NULL pointer > >> dereference that can happen if (for example) a usb optical drive is > >> removed while an application is using it. > > > > Yeah I'll pick it up, opening up the 3.17 branches soon. > > Thanks, Jens. Joe, the patches don't apply anymore... would you mind > sending an updated set so Jens doesn't have to do the fixups? I think > you also need to convert blk_mq_alloc_request, I didn't see that in your > patch. Hi Jeff, I have a new set that applies on top of 3.16-rc2... but before posting, I wasn't sure what needs to be converted w/regard to blk_mq_alloc_request. As far as I can tell, the new multi-queue block IO queueing implementation via blk_mq_alloc_request should be safe from this bug as it doesn't include any dead queue checks that introduce early exits. Regards, -- Joe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 0/2] block,scsi: fixup blk_get_request dead queue scenarios
Jens Axboe writes: > On 2014-06-26 10:08, Jeff Moyer wrote: >> Joe Lawrence writes: >> >>> v1->v2: incorporate Jeff's feedback in bsg_map_hdr() and Reviewed-by >>> tags. >>> >>> Joe Lawrence (2): >>>block,scsi: verify return pointer from blk_get_request >>>block,scsi: convert and handle ERR_PTR from blk_get_request >> >> Jens, >> >> Can you pick this series up? It actually fixes a NULL pointer >> dereference that can happen if (for example) a usb optical drive is >> removed while an application is using it. > > Yeah I'll pick it up, opening up the 3.17 branches soon. Thanks, Jens. Joe, the patches don't apply anymore... would you mind sending an updated set so Jens doesn't have to do the fixups? I think you also need to convert blk_mq_alloc_request, I didn't see that in your patch. Thanks! Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 0/2] block,scsi: fixup blk_get_request dead queue scenarios
On 2014-06-26 10:08, Jeff Moyer wrote: Joe Lawrence writes: v1->v2: incorporate Jeff's feedback in bsg_map_hdr() and Reviewed-by tags. Joe Lawrence (2): block,scsi: verify return pointer from blk_get_request block,scsi: convert and handle ERR_PTR from blk_get_request Jens, Can you pick this series up? It actually fixes a NULL pointer dereference that can happen if (for example) a usb optical drive is removed while an application is using it. Yeah I'll pick it up, opening up the 3.17 branches soon. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 0/2] block,scsi: fixup blk_get_request dead queue scenarios
Joe Lawrence writes: > v1->v2: incorporate Jeff's feedback in bsg_map_hdr() and Reviewed-by > tags. > > Joe Lawrence (2): > block,scsi: verify return pointer from blk_get_request > block,scsi: convert and handle ERR_PTR from blk_get_request Jens, Can you pick this series up? It actually fixes a NULL pointer dereference that can happen if (for example) a usb optical drive is removed while an application is using it. Thanks! Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 0/2] block,scsi: fixup blk_get_request dead queue scenarios
Joe Lawrence joe.lawre...@stratus.com writes: v1-v2: incorporate Jeff's feedback in bsg_map_hdr() and Reviewed-by tags. Joe Lawrence (2): block,scsi: verify return pointer from blk_get_request block,scsi: convert and handle ERR_PTR from blk_get_request Jens, Can you pick this series up? It actually fixes a NULL pointer dereference that can happen if (for example) a usb optical drive is removed while an application is using it. Thanks! Jeff -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 0/2] block,scsi: fixup blk_get_request dead queue scenarios
On 2014-06-26 10:08, Jeff Moyer wrote: Joe Lawrence joe.lawre...@stratus.com writes: v1-v2: incorporate Jeff's feedback in bsg_map_hdr() and Reviewed-by tags. Joe Lawrence (2): block,scsi: verify return pointer from blk_get_request block,scsi: convert and handle ERR_PTR from blk_get_request Jens, Can you pick this series up? It actually fixes a NULL pointer dereference that can happen if (for example) a usb optical drive is removed while an application is using it. Yeah I'll pick it up, opening up the 3.17 branches soon. -- Jens Axboe -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 0/2] block,scsi: fixup blk_get_request dead queue scenarios
Jens Axboe ax...@kernel.dk writes: On 2014-06-26 10:08, Jeff Moyer wrote: Joe Lawrence joe.lawre...@stratus.com writes: v1-v2: incorporate Jeff's feedback in bsg_map_hdr() and Reviewed-by tags. Joe Lawrence (2): block,scsi: verify return pointer from blk_get_request block,scsi: convert and handle ERR_PTR from blk_get_request Jens, Can you pick this series up? It actually fixes a NULL pointer dereference that can happen if (for example) a usb optical drive is removed while an application is using it. Yeah I'll pick it up, opening up the 3.17 branches soon. Thanks, Jens. Joe, the patches don't apply anymore... would you mind sending an updated set so Jens doesn't have to do the fixups? I think you also need to convert blk_mq_alloc_request, I didn't see that in your patch. Thanks! Jeff -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 0/2] block,scsi: fixup blk_get_request dead queue scenarios
On Thu, 26 Jun 2014, Jeff Moyer wrote: Jens Axboe ax...@kernel.dk writes: On 2014-06-26 10:08, Jeff Moyer wrote: Joe Lawrence joe.lawre...@stratus.com writes: v1-v2: incorporate Jeff's feedback in bsg_map_hdr() and Reviewed-by tags. Joe Lawrence (2): block,scsi: verify return pointer from blk_get_request block,scsi: convert and handle ERR_PTR from blk_get_request Jens, Can you pick this series up? It actually fixes a NULL pointer dereference that can happen if (for example) a usb optical drive is removed while an application is using it. Yeah I'll pick it up, opening up the 3.17 branches soon. Thanks, Jens. Joe, the patches don't apply anymore... would you mind sending an updated set so Jens doesn't have to do the fixups? I think you also need to convert blk_mq_alloc_request, I didn't see that in your patch. Hi Jeff, I have a new set that applies on top of 3.16-rc2... but before posting, I wasn't sure what needs to be converted w/regard to blk_mq_alloc_request. As far as I can tell, the new multi-queue block IO queueing implementation via blk_mq_alloc_request should be safe from this bug as it doesn't include any dead queue checks that introduce early exits. Regards, -- Joe -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 0/2] block,scsi: fixup blk_get_request dead queue scenarios
v1->v2: incorporate Jeff's feedback in bsg_map_hdr() and Reviewed-by tags. Joe Lawrence (2): block,scsi: verify return pointer from blk_get_request block,scsi: convert and handle ERR_PTR from blk_get_request block/blk-core.c| 34 ++--- block/bsg.c | 8 +++ block/scsi_ioctl.c | 13 --- drivers/block/paride/pd.c | 2 ++ drivers/block/pktcdvd.c | 2 ++ drivers/block/sx8.c | 2 +- drivers/cdrom/cdrom.c | 4 ++-- drivers/ide/ide-park.c | 2 +- drivers/scsi/device_handler/scsi_dh_alua.c | 2 +- drivers/scsi/device_handler/scsi_dh_emc.c | 2 +- drivers/scsi/device_handler/scsi_dh_hp_sw.c | 4 ++-- drivers/scsi/device_handler/scsi_dh_rdac.c | 2 +- drivers/scsi/osd/osd_initiator.c| 4 ++-- drivers/scsi/osst.c | 2 +- drivers/scsi/scsi_error.c | 2 ++ drivers/scsi/scsi_lib.c | 2 +- drivers/scsi/scsi_tgt_lib.c | 2 +- drivers/scsi/sg.c | 4 ++-- drivers/scsi/st.c | 2 +- drivers/target/target_core_pscsi.c | 2 +- 20 files changed, 55 insertions(+), 42 deletions(-) -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 0/2] block,scsi: fixup blk_get_request dead queue scenarios
v1-v2: incorporate Jeff's feedback in bsg_map_hdr() and Reviewed-by tags. Joe Lawrence (2): block,scsi: verify return pointer from blk_get_request block,scsi: convert and handle ERR_PTR from blk_get_request block/blk-core.c| 34 ++--- block/bsg.c | 8 +++ block/scsi_ioctl.c | 13 --- drivers/block/paride/pd.c | 2 ++ drivers/block/pktcdvd.c | 2 ++ drivers/block/sx8.c | 2 +- drivers/cdrom/cdrom.c | 4 ++-- drivers/ide/ide-park.c | 2 +- drivers/scsi/device_handler/scsi_dh_alua.c | 2 +- drivers/scsi/device_handler/scsi_dh_emc.c | 2 +- drivers/scsi/device_handler/scsi_dh_hp_sw.c | 4 ++-- drivers/scsi/device_handler/scsi_dh_rdac.c | 2 +- drivers/scsi/osd/osd_initiator.c| 4 ++-- drivers/scsi/osst.c | 2 +- drivers/scsi/scsi_error.c | 2 ++ drivers/scsi/scsi_lib.c | 2 +- drivers/scsi/scsi_tgt_lib.c | 2 +- drivers/scsi/sg.c | 4 ++-- drivers/scsi/st.c | 2 +- drivers/target/target_core_pscsi.c | 2 +- 20 files changed, 55 insertions(+), 42 deletions(-) -- 1.8.3.1 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
