Re: [PATCH v2 0/2] ipvs: speedup ipvs netns dismantle

[Simon Horman]

On Mon, Sep 30, 2019 at 10:08:23PM +0300, Julian Anastasov wrote:
> 
>   Hello,
> 
> On Fri, 27 Sep 2019, Haishuang Yan wrote:
> 
> > Implement exit_batch() method to dismantle more ipvs netns
> > per round.
> > 
> > Tested:
> > $  cat add_del_unshare.sh
> > #!/bin/bash
> > 
> > for i in `seq 1 100`
> > do
> >  (for j in `seq 1 40` ; do  unshare -n ipvsadm -A -t 172.16.$i.$j:80 
> > >/dev/null ; done) &
> > done
> > wait; grep net_namespace /proc/slabinfo
> > 
> > Befor patch:
> > $  time sh add_del_unshare.sh
> > net_namespace   4020   4020   473668 : tunables000 
> > : slabdata670670  0
> > 
> > real0m8.086s
> > user0m2.025s
> > sys 0m36.956s
> > 
> > After patch:
> > $  time sh add_del_unshare.sh
> > net_namespace   4020   4020   473668 : tunables000 
> > : slabdata670670  0
> > 
> > real0m7.623s
> > user0m2.003s
> > sys 0m32.935s
> > 
> > Haishuang Yan (2):
> >   ipvs: batch __ip_vs_cleanup
> >   ipvs: batch __ip_vs_dev_cleanup
> > 
> >  include/net/ip_vs.h |  2 +-
> >  net/netfilter/ipvs/ip_vs_core.c | 47 
> > -
> >  net/netfilter/ipvs/ip_vs_ctl.c  | 12 ---
> >  3 files changed, 38 insertions(+), 23 deletions(-)
> 
>   Both patches in v2 look good to me, thanks!
> 
> Acked-by: Julian Anastasov 
> 
>   This is for the -next kernels...

Thanks, applied to ipvs-next.

Re: [PATCH v2 0/2] ipvs: speedup ipvs netns dismantle

[Julian Anastasov]

Hello,

On Fri, 27 Sep 2019, Haishuang Yan wrote:

> Implement exit_batch() method to dismantle more ipvs netns
> per round.
> 
> Tested:
> $  cat add_del_unshare.sh
> #!/bin/bash
> 
> for i in `seq 1 100`
> do
>  (for j in `seq 1 40` ; do  unshare -n ipvsadm -A -t 172.16.$i.$j:80 
> >/dev/null ; done) &
> done
> wait; grep net_namespace /proc/slabinfo
> 
> Befor patch:
> $  time sh add_del_unshare.sh
> net_namespace   4020   4020   473668 : tunables000 : 
> slabdata670670  0
> 
> real0m8.086s
> user0m2.025s
> sys 0m36.956s
> 
> After patch:
> $  time sh add_del_unshare.sh
> net_namespace   4020   4020   473668 : tunables000 : 
> slabdata670670  0
> 
> real0m7.623s
> user0m2.003s
> sys 0m32.935s
> 
> Haishuang Yan (2):
>   ipvs: batch __ip_vs_cleanup
>   ipvs: batch __ip_vs_dev_cleanup
> 
>  include/net/ip_vs.h |  2 +-
>  net/netfilter/ipvs/ip_vs_core.c | 47 
> -
>  net/netfilter/ipvs/ip_vs_ctl.c  | 12 ---
>  3 files changed, 38 insertions(+), 23 deletions(-)

Both patches in v2 look good to me, thanks!

Acked-by: Julian Anastasov 

This is for the -next kernels...

Regards

--
Julian Anastasov 

[PATCH v2 0/2] ipvs: speedup ipvs netns dismantle

[Haishuang Yan]

Implement exit_batch() method to dismantle more ipvs netns
per round.

Tested:
$  cat add_del_unshare.sh
#!/bin/bash

for i in `seq 1 100`
do
 (for j in `seq 1 40` ; do  unshare -n ipvsadm -A -t 172.16.$i.$j:80 
>/dev/null ; done) &
done
wait; grep net_namespace /proc/slabinfo

Befor patch:
$  time sh add_del_unshare.sh
net_namespace   4020   4020   473668 : tunables000 : 
slabdata670670  0

real0m8.086s
user0m2.025s
sys 0m36.956s

After patch:
$  time sh add_del_unshare.sh
net_namespace   4020   4020   473668 : tunables000 : 
slabdata670670  0

real0m7.623s
user0m2.003s
sys 0m32.935s

Haishuang Yan (2):
  ipvs: batch __ip_vs_cleanup
  ipvs: batch __ip_vs_dev_cleanup

 include/net/ip_vs.h |  2 +-
 net/netfilter/ipvs/ip_vs_core.c | 47 -
 net/netfilter/ipvs/ip_vs_ctl.c  | 12 ---
 3 files changed, 38 insertions(+), 23 deletions(-)

-- 
1.8.3.1