Re: [PATCH v2 0/3] pwm: sun4i: switch to atomic PWM
On Thu, 6 Jul 2017 09:00:16 +0200 Alexandre Belloni wrote: > On 06/07/2017 at 08:49:22 +0200, Thierry Reding wrote: > > On Tue, May 30, 2017 at 09:32:06PM +0200, Alexandre Belloni wrote: > > > Switch to atomic PWM. The main goal is to properly wait for a period > > > before > > > disabling a channel to ensure the correct level is set on the output. > > > > > > Changes in v2: > > > - fixed remaining checkpatch warnings > > > - split the series to ease reviews > > > - changed the delay handling to ensure the proper amount of time has > > > elapsed > > >before disabling a channel > > > - dropped RDY bit handling as it doesn't have any real effect. > > > > > > Alexandre Belloni (3): > > > pwm: sun4i: improve hardware read out > > > pwm: sun4i: switch to atomic PWM > > > pwm: sun4i: drop legacy callbacks > > > > > > drivers/pwm/pwm-sun4i.c | 263 > > > +++- > > > 1 file changed, 148 insertions(+), 115 deletions(-) > > > > Series applied, though you could've just squashed together patches 2 and > > 3 because they don't make sense apart. > > > > Ok, thanks. IIRC, Boris suggested the split ;) Yes, I did it because the diff was really hard to review.
Re: [PATCH v2 0/3] pwm: sun4i: switch to atomic PWM
On 06/07/2017 at 08:49:22 +0200, Thierry Reding wrote: > On Tue, May 30, 2017 at 09:32:06PM +0200, Alexandre Belloni wrote: > > Switch to atomic PWM. The main goal is to properly wait for a period before > > disabling a channel to ensure the correct level is set on the output. > > > > Changes in v2: > > - fixed remaining checkpatch warnings > > - split the series to ease reviews > > - changed the delay handling to ensure the proper amount of time has > > elapsed > >before disabling a channel > > - dropped RDY bit handling as it doesn't have any real effect. > > > > Alexandre Belloni (3): > > pwm: sun4i: improve hardware read out > > pwm: sun4i: switch to atomic PWM > > pwm: sun4i: drop legacy callbacks > > > > drivers/pwm/pwm-sun4i.c | 263 > > +++- > > 1 file changed, 148 insertions(+), 115 deletions(-) > > Series applied, though you could've just squashed together patches 2 and > 3 because they don't make sense apart. > Ok, thanks. IIRC, Boris suggested the split ;) > Thierry -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Re: [PATCH v2 0/3] pwm: sun4i: switch to atomic PWM
On Tue, May 30, 2017 at 09:32:06PM +0200, Alexandre Belloni wrote: > Switch to atomic PWM. The main goal is to properly wait for a period before > disabling a channel to ensure the correct level is set on the output. > > Changes in v2: > - fixed remaining checkpatch warnings > - split the series to ease reviews > - changed the delay handling to ensure the proper amount of time has elapsed >before disabling a channel > - dropped RDY bit handling as it doesn't have any real effect. > > Alexandre Belloni (3): > pwm: sun4i: improve hardware read out > pwm: sun4i: switch to atomic PWM > pwm: sun4i: drop legacy callbacks > > drivers/pwm/pwm-sun4i.c | 263 > +++- > 1 file changed, 148 insertions(+), 115 deletions(-) Series applied, though you could've just squashed together patches 2 and 3 because they don't make sense apart. Thierry signature.asc Description: PGP signature
Re: [PATCH v2 0/3] pwm: sun4i: switch to atomic PWM
On Tue, May 30, 2017 at 09:32:06PM +0200, Alexandre Belloni wrote: > Switch to atomic PWM. The main goal is to properly wait for a period before > disabling a channel to ensure the correct level is set on the output. > > Changes in v2: > - fixed remaining checkpatch warnings > - split the series to ease reviews > - changed the delay handling to ensure the proper amount of time has elapsed >before disabling a channel > - dropped RDY bit handling as it doesn't have any real effect. Acked-by: Maxime Ripard Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com signature.asc Description: PGP signature
[PATCH v2 0/3] pwm: sun4i: switch to atomic PWM
Switch to atomic PWM. The main goal is to properly wait for a period before disabling a channel to ensure the correct level is set on the output. Changes in v2: - fixed remaining checkpatch warnings - split the series to ease reviews - changed the delay handling to ensure the proper amount of time has elapsed before disabling a channel - dropped RDY bit handling as it doesn't have any real effect. Alexandre Belloni (3): pwm: sun4i: improve hardware read out pwm: sun4i: switch to atomic PWM pwm: sun4i: drop legacy callbacks drivers/pwm/pwm-sun4i.c | 263 +++- 1 file changed, 148 insertions(+), 115 deletions(-) -- 2.11.0