Re: [PATCH v2 0/3] tracing: a few simplifying patches
On Mon, 29 Oct 2018 23:35:39 +0100 Rasmus Villemoes wrote: Hi Rasmus, I'm currently traveling. I'll try to take a look at these later. If you don't hear from me by next week, feel free to send me a gentle reminder ;-) -- Steve > Playing around with -Wformat-nonliteral, I stumbled on two instances > in trace_output.c. Looking at the code a bit, turns out one can remove > the use of the non-constant format string and eliminate some code > duplication at the same time. > > v2: Include cover letter, rename argument with_offset -> offset. > > Rasmus Villemoes (3): > tracing: merge seq_print_sym_short() and seq_print_sym_offset() > tracing: avoid -Wformat-nonliteral warning > tracing: simplify printf'ing in seq_print_sym > > kernel/trace/trace_output.c | 38 - > 1 file changed, 8 insertions(+), 30 deletions(-) >
Re: [PATCH v2 0/3] tracing: a few simplifying patches
On Mon, 29 Oct 2018 23:35:39 +0100 Rasmus Villemoes wrote: Hi Rasmus, I'm currently traveling. I'll try to take a look at these later. If you don't hear from me by next week, feel free to send me a gentle reminder ;-) -- Steve > Playing around with -Wformat-nonliteral, I stumbled on two instances > in trace_output.c. Looking at the code a bit, turns out one can remove > the use of the non-constant format string and eliminate some code > duplication at the same time. > > v2: Include cover letter, rename argument with_offset -> offset. > > Rasmus Villemoes (3): > tracing: merge seq_print_sym_short() and seq_print_sym_offset() > tracing: avoid -Wformat-nonliteral warning > tracing: simplify printf'ing in seq_print_sym > > kernel/trace/trace_output.c | 38 - > 1 file changed, 8 insertions(+), 30 deletions(-) >
[PATCH v2 0/3] tracing: a few simplifying patches
Playing around with -Wformat-nonliteral, I stumbled on two instances in trace_output.c. Looking at the code a bit, turns out one can remove the use of the non-constant format string and eliminate some code duplication at the same time. v2: Include cover letter, rename argument with_offset -> offset. Rasmus Villemoes (3): tracing: merge seq_print_sym_short() and seq_print_sym_offset() tracing: avoid -Wformat-nonliteral warning tracing: simplify printf'ing in seq_print_sym kernel/trace/trace_output.c | 38 - 1 file changed, 8 insertions(+), 30 deletions(-) -- 2.19.1.6.gbde171bbf5
[PATCH v2 0/3] tracing: a few simplifying patches
Playing around with -Wformat-nonliteral, I stumbled on two instances in trace_output.c. Looking at the code a bit, turns out one can remove the use of the non-constant format string and eliminate some code duplication at the same time. v2: Include cover letter, rename argument with_offset -> offset. Rasmus Villemoes (3): tracing: merge seq_print_sym_short() and seq_print_sym_offset() tracing: avoid -Wformat-nonliteral warning tracing: simplify printf'ing in seq_print_sym kernel/trace/trace_output.c | 38 - 1 file changed, 8 insertions(+), 30 deletions(-) -- 2.19.1.6.gbde171bbf5
