Re: [PATCH v2 0/4] cppc_cpufreq: fix, clarify and improve support
On Tuesday 15 Dec 2020 at 19:21:01 (+0100), Rafael J. Wysocki wrote: > On Mon, Dec 14, 2020 at 5:14 PM Mian Yousaf Kaukab wrote: > > > > On Mon, Dec 14, 2020 at 12:38:19PM +, Ionela Voinescu wrote: > > > Hi guys, > > > > > > I'm sending v2 of some of the patches at [1] in light of the discussions > > > at [2]. > > > > > > v2: > > > - Patches 1-3 are trivial rebase on linux next 20201211, with conflicts > > >fixed after eliminating what previously was "[PATCH 4/8] cppc_cpufreq: > > >replace per-cpu structures with lists." Therefore, I have kept > > >Viresh's acks. > > > > > > - Patch 4 is a merge between: > > > - [PATCH 4/8] cppc_cpufreq: replace per-cpu structures with lists > > > - [PATCH] cppc_cpufreq: optimise memory allocation for HW and NONE > > >coordination > > >both found at [1]. > > > > > >This functionality was introducing the problem at [2] and it's fixed > > >in this version by bailing out of driver registration if a _CPC entry > > >is not found for a CPU. > > > > > >Yousaf, it would be great if you can test this and make sure it > > >matches your expectations. > > > > > >Rafael, Viresh if you think this last patch introduces too many > > >changes, you can skip it for 5.11 which is around the corner and > > >have more time for review for 5.12. I've added more eyes in the review > > >list. > > > > > > > > > All patches are based on linux next 20201211 after patch at [3] is > > > applied. > > > > > > [1] > > > https://lore.kernel.org/linux-pm/20201105125524.4409-1-ionela.voine...@arm.com/#t > > > [2] > > > https://lore.kernel.org/linux-pm/20201210142139.20490-1-yousaf.kau...@suse.com/ > > > [3] > > > https://lore.kernel.org/linux-pm/20201214120740.10948-1-ionela.voine...@arm.com/ > > > > > > Ionela Voinescu (4): > > > cppc_cpufreq: use policy->cpu as driver of frequency setting > > > cppc_cpufreq: clarify support for coordination types > > > cppc_cpufreq: expose information on frequency domains > > > cppc_cpufreq: replace per-cpu data array with a list > > > > > > .../ABI/testing/sysfs-devices-system-cpu | 3 +- > > > drivers/acpi/cppc_acpi.c | 141 ++-- > > > drivers/cpufreq/cppc_cpufreq.c| 204 ++ > > > include/acpi/cppc_acpi.h | 6 +- > > > 4 files changed, 181 insertions(+), 173 deletions(-) > > > > For the whole series: > > Tested-by: Mian Yousaf Kaukab > > All patches applied as 5.11-rc material, thanks! Many thanks, guys! Ionela.
Re: [PATCH v2 0/4] cppc_cpufreq: fix, clarify and improve support
On Mon, Dec 14, 2020 at 5:14 PM Mian Yousaf Kaukab wrote: > > On Mon, Dec 14, 2020 at 12:38:19PM +, Ionela Voinescu wrote: > > Hi guys, > > > > I'm sending v2 of some of the patches at [1] in light of the discussions > > at [2]. > > > > v2: > > - Patches 1-3 are trivial rebase on linux next 20201211, with conflicts > >fixed after eliminating what previously was "[PATCH 4/8] cppc_cpufreq: > >replace per-cpu structures with lists." Therefore, I have kept > >Viresh's acks. > > > > - Patch 4 is a merge between: > > - [PATCH 4/8] cppc_cpufreq: replace per-cpu structures with lists > > - [PATCH] cppc_cpufreq: optimise memory allocation for HW and NONE > >coordination > >both found at [1]. > > > >This functionality was introducing the problem at [2] and it's fixed > >in this version by bailing out of driver registration if a _CPC entry > >is not found for a CPU. > > > >Yousaf, it would be great if you can test this and make sure it > >matches your expectations. > > > >Rafael, Viresh if you think this last patch introduces too many > >changes, you can skip it for 5.11 which is around the corner and > >have more time for review for 5.12. I've added more eyes in the review > >list. > > > > > > All patches are based on linux next 20201211 after patch at [3] is > > applied. > > > > [1] > > https://lore.kernel.org/linux-pm/20201105125524.4409-1-ionela.voine...@arm.com/#t > > [2] > > https://lore.kernel.org/linux-pm/20201210142139.20490-1-yousaf.kau...@suse.com/ > > [3] > > https://lore.kernel.org/linux-pm/20201214120740.10948-1-ionela.voine...@arm.com/ > > > > Ionela Voinescu (4): > > cppc_cpufreq: use policy->cpu as driver of frequency setting > > cppc_cpufreq: clarify support for coordination types > > cppc_cpufreq: expose information on frequency domains > > cppc_cpufreq: replace per-cpu data array with a list > > > > .../ABI/testing/sysfs-devices-system-cpu | 3 +- > > drivers/acpi/cppc_acpi.c | 141 ++-- > > drivers/cpufreq/cppc_cpufreq.c| 204 ++ > > include/acpi/cppc_acpi.h | 6 +- > > 4 files changed, 181 insertions(+), 173 deletions(-) > > For the whole series: > Tested-by: Mian Yousaf Kaukab All patches applied as 5.11-rc material, thanks!
Re: [PATCH v2 0/4] cppc_cpufreq: fix, clarify and improve support
On Mon, Dec 14, 2020 at 12:38:19PM +, Ionela Voinescu wrote: > Hi guys, > > I'm sending v2 of some of the patches at [1] in light of the discussions > at [2]. > > v2: > - Patches 1-3 are trivial rebase on linux next 20201211, with conflicts >fixed after eliminating what previously was "[PATCH 4/8] cppc_cpufreq: >replace per-cpu structures with lists." Therefore, I have kept >Viresh's acks. > > - Patch 4 is a merge between: > - [PATCH 4/8] cppc_cpufreq: replace per-cpu structures with lists > - [PATCH] cppc_cpufreq: optimise memory allocation for HW and NONE >coordination >both found at [1]. > >This functionality was introducing the problem at [2] and it's fixed >in this version by bailing out of driver registration if a _CPC entry >is not found for a CPU. > >Yousaf, it would be great if you can test this and make sure it >matches your expectations. > >Rafael, Viresh if you think this last patch introduces too many >changes, you can skip it for 5.11 which is around the corner and >have more time for review for 5.12. I've added more eyes in the review >list. > > > All patches are based on linux next 20201211 after patch at [3] is > applied. > > [1] > https://lore.kernel.org/linux-pm/20201105125524.4409-1-ionela.voine...@arm.com/#t > [2] > https://lore.kernel.org/linux-pm/20201210142139.20490-1-yousaf.kau...@suse.com/ > [3] > https://lore.kernel.org/linux-pm/20201214120740.10948-1-ionela.voine...@arm.com/ > > Ionela Voinescu (4): > cppc_cpufreq: use policy->cpu as driver of frequency setting > cppc_cpufreq: clarify support for coordination types > cppc_cpufreq: expose information on frequency domains > cppc_cpufreq: replace per-cpu data array with a list > > .../ABI/testing/sysfs-devices-system-cpu | 3 +- > drivers/acpi/cppc_acpi.c | 141 ++-- > drivers/cpufreq/cppc_cpufreq.c| 204 ++ > include/acpi/cppc_acpi.h | 6 +- > 4 files changed, 181 insertions(+), 173 deletions(-) For the whole series: Tested-by: Mian Yousaf Kaukab
[PATCH v2 0/4] cppc_cpufreq: fix, clarify and improve support
Hi guys, I'm sending v2 of some of the patches at [1] in light of the discussions at [2]. v2: - Patches 1-3 are trivial rebase on linux next 20201211, with conflicts fixed after eliminating what previously was "[PATCH 4/8] cppc_cpufreq: replace per-cpu structures with lists." Therefore, I have kept Viresh's acks. - Patch 4 is a merge between: - [PATCH 4/8] cppc_cpufreq: replace per-cpu structures with lists - [PATCH] cppc_cpufreq: optimise memory allocation for HW and NONE coordination both found at [1]. This functionality was introducing the problem at [2] and it's fixed in this version by bailing out of driver registration if a _CPC entry is not found for a CPU. Yousaf, it would be great if you can test this and make sure it matches your expectations. Rafael, Viresh if you think this last patch introduces too many changes, you can skip it for 5.11 which is around the corner and have more time for review for 5.12. I've added more eyes in the review list. All patches are based on linux next 20201211 after patch at [3] is applied. [1] https://lore.kernel.org/linux-pm/20201105125524.4409-1-ionela.voine...@arm.com/#t [2] https://lore.kernel.org/linux-pm/20201210142139.20490-1-yousaf.kau...@suse.com/ [3] https://lore.kernel.org/linux-pm/20201214120740.10948-1-ionela.voine...@arm.com/ Ionela Voinescu (4): cppc_cpufreq: use policy->cpu as driver of frequency setting cppc_cpufreq: clarify support for coordination types cppc_cpufreq: expose information on frequency domains cppc_cpufreq: replace per-cpu data array with a list .../ABI/testing/sysfs-devices-system-cpu | 3 +- drivers/acpi/cppc_acpi.c | 141 ++-- drivers/cpufreq/cppc_cpufreq.c| 204 ++ include/acpi/cppc_acpi.h | 6 +- 4 files changed, 181 insertions(+), 173 deletions(-) -- 2.29.2.dirty
