Re: [PATCH v2 0/4] RCU fixes for rcu_assign_pointer() usage
On Wed, Mar 20, 2019 at 08:34:22PM -0400, Joel Fernandes (Google) wrote: > This is just a resend with scheduler patches split from the driver fixes and > Paul's Reviewed-by(s) added. > > These patches fix various sparse errors ccaused as a result of the recent > check > to add rcu_check_sparse() to rcu_assign_pointer(). The errors are due to > missing annotations. The annotations added in the series can also help avoid > future incorrect usages and bugs so it is a good idea to do in any case. > > RFC v1 -> Patch v2: > Made changes based on Peter Zijlstra review. > > Joel Fernandes (Google) (4): > sched/cpufreq: Annotate cpufreq_update_util_data pointer with __rcu > sched_domain: Annotate RCU pointers properly > rcuwait: Annotate task_struct with __rcu > sched: Annotate perf_domain pointer with __rcu > > include/linux/rcuwait.h| 2 +- > include/linux/sched/topology.h | 4 ++-- > kernel/sched/cpufreq.c | 2 +- > kernel/sched/sched.h | 18 +- > kernel/sched/topology.c| 10 +- > 5 files changed, 18 insertions(+), 18 deletions(-) Looks good to me. -- Luc
Re: [PATCH v2 0/4] RCU fixes for rcu_assign_pointer() usage
On Wed, Mar 20, 2019 at 08:34:22PM -0400, Joel Fernandes (Google) wrote: > This is just a resend with scheduler patches split from the driver fixes and > Paul's Reviewed-by(s) added. > > These patches fix various sparse errors ccaused as a result of the recent > check > to add rcu_check_sparse() to rcu_assign_pointer(). The errors are due to > missing annotations. The annotations added in the series can also help avoid > future incorrect usages and bugs so it is a good idea to do in any case. > > RFC v1 -> Patch v2: > Made changes based on Peter Zijlstra review. > > Joel Fernandes (Google) (4): > sched/cpufreq: Annotate cpufreq_update_util_data pointer with __rcu > sched_domain: Annotate RCU pointers properly > rcuwait: Annotate task_struct with __rcu > sched: Annotate perf_domain pointer with __rcu > > include/linux/rcuwait.h| 2 +- > include/linux/sched/topology.h | 4 ++-- > kernel/sched/cpufreq.c | 2 +- > kernel/sched/sched.h | 18 +- > kernel/sched/topology.c| 10 +- > 5 files changed, 18 insertions(+), 18 deletions(-) Thanks Joel
[PATCH v2 0/4] RCU fixes for rcu_assign_pointer() usage
This is just a resend with scheduler patches split from the driver fixes and Paul's Reviewed-by(s) added. These patches fix various sparse errors ccaused as a result of the recent check to add rcu_check_sparse() to rcu_assign_pointer(). The errors are due to missing annotations. The annotations added in the series can also help avoid future incorrect usages and bugs so it is a good idea to do in any case. RFC v1 -> Patch v2: Made changes based on Peter Zijlstra review. Joel Fernandes (Google) (4): sched/cpufreq: Annotate cpufreq_update_util_data pointer with __rcu sched_domain: Annotate RCU pointers properly rcuwait: Annotate task_struct with __rcu sched: Annotate perf_domain pointer with __rcu include/linux/rcuwait.h| 2 +- include/linux/sched/topology.h | 4 ++-- kernel/sched/cpufreq.c | 2 +- kernel/sched/sched.h | 18 +- kernel/sched/topology.c| 10 +- 5 files changed, 18 insertions(+), 18 deletions(-) -- 2.21.0.225.g810b269d1ac-goog
