Re: [PATCH v2 0/4] clocksource: rockchip/timer: Support rktimer for rk3399

[Caesar Wang]

On 2016年06月16日 22:26, Daniel Lezcano wrote:

On 06/07/2016 06:54 AM, Caesar Wang wrote:

This series patches had been tested on rockchip inside kernel.
In order to support the rk3399 SoC timer and turn off interrupts and 
IPIs to

save power in idle.
Okay, it still works bootup on rk3288/other SoCs, even though many 
socs hasn't used

the broadcast timer.

History version:
v1:
https://lkml.org/lkml/2016/5/25/186

Easy to test for my borad.
localhost / # cat /proc/interrupts
CPU0   CPU1   CPU2   CPU3   CPU4   CPU5
1:  0  0  0  0 0  0 
GICv3  29 Edge  arch_timer

...
5:  0  0  0  0 0  0 GICv3 
113 Level rk_timer

..

localhost / # cat /proc/timer_list | grep event_handler
get "event_handler:  hrtimer_interrupt"
event_handler:  tick_handle_oneshot_broadcast
event_handler:  hrtimer_interrupt

That should work for my board.


Hi Caesar,

I applied the patches on my tree. I humbly reworded the changelog, if 
you disagree with the content, let me know.


Have a look at your tree. 
(https://git.linaro.org/people/daniel.lezcano/linux.git/shortlog/refs/heads/clockevents/next)

That's LGTM.




Please, in the future, take care of the following:

 - patch prefix is 'clocksource/driver/: [A-Z].*'

 - the change log is important, it deserves some love.



Thanks for pointing out, I will keep in mind it.

-
Caesar


Thanks.

  -- Daniel




--
caesar wang | software engineer | w...@rock-chip.com

Re: [PATCH v2 0/4] clocksource: rockchip/timer: Support rktimer for rk3399

[Caesar Wang]

On 2016年06月16日 22:26, Daniel Lezcano wrote:

On 06/07/2016 06:54 AM, Caesar Wang wrote:

This series patches had been tested on rockchip inside kernel.
In order to support the rk3399 SoC timer and turn off interrupts and 
IPIs to

save power in idle.
Okay, it still works bootup on rk3288/other SoCs, even though many 
socs hasn't used

the broadcast timer.

History version:
v1:
https://lkml.org/lkml/2016/5/25/186

Easy to test for my borad.
localhost / # cat /proc/interrupts
CPU0   CPU1   CPU2   CPU3   CPU4   CPU5
1:  0  0  0  0 0  0 
GICv3  29 Edge  arch_timer

...
5:  0  0  0  0 0  0 GICv3 
113 Level rk_timer

..

localhost / # cat /proc/timer_list | grep event_handler
get "event_handler:  hrtimer_interrupt"
event_handler:  tick_handle_oneshot_broadcast
event_handler:  hrtimer_interrupt

That should work for my board.


Hi Caesar,

I applied the patches on my tree. I humbly reworded the changelog, if 
you disagree with the content, let me know.


Have a look at your tree. 
(https://git.linaro.org/people/daniel.lezcano/linux.git/shortlog/refs/heads/clockevents/next)

That's LGTM.




Please, in the future, take care of the following:

 - patch prefix is 'clocksource/driver/: [A-Z].*'

 - the change log is important, it deserves some love.



Thanks for pointing out, I will keep in mind it.

-
Caesar


Thanks.

  -- Daniel




--
caesar wang | software engineer | w...@rock-chip.com

Re: [PATCH v2 0/4] clocksource: rockchip/timer: Support rktimer for rk3399

[Daniel Lezcano]

On 06/07/2016 06:54 AM, Caesar Wang wrote:

This series patches had been tested on rockchip inside kernel.
In order to support the rk3399 SoC timer and turn off interrupts and IPIs to
save power in idle.
Okay, it still works bootup on rk3288/other SoCs, even though many socs hasn't 
used
the broadcast timer.

History version:
v1:
https://lkml.org/lkml/2016/5/25/186

Easy to test for my borad.
localhost / # cat /proc/interrupts
CPU0   CPU1   CPU2   CPU3   CPU4   CPU5
1:  0  0  0  0  0  0 GICv3  
29 Edge  arch_timer
...
5:  0  0  0  0  0  0 GICv3 
113 Level rk_timer
..

localhost / # cat /proc/timer_list | grep event_handler
get "event_handler:  hrtimer_interrupt"
event_handler:  tick_handle_oneshot_broadcast
event_handler:  hrtimer_interrupt

That should work for my board.


Hi Caesar,

I applied the patches on my tree. I humbly reworded the changelog, if 
you disagree with the content, let me know.


Please, in the future, take care of the following:

 - patch prefix is 'clocksource/driver/: [A-Z].*'

 - the change log is important, it deserves some love.

Thanks.

  -- Daniel


--
  Linaro.org │ Open source software for ARM SoCs

Follow Linaro:   Facebook |
 Twitter |
 Blog

Re: [PATCH v2 0/4] clocksource: rockchip/timer: Support rktimer for rk3399

[Daniel Lezcano]

On 06/07/2016 06:54 AM, Caesar Wang wrote:

This series patches had been tested on rockchip inside kernel.
In order to support the rk3399 SoC timer and turn off interrupts and IPIs to
save power in idle.
Okay, it still works bootup on rk3288/other SoCs, even though many socs hasn't 
used
the broadcast timer.

History version:
v1:
https://lkml.org/lkml/2016/5/25/186

Easy to test for my borad.
localhost / # cat /proc/interrupts
CPU0   CPU1   CPU2   CPU3   CPU4   CPU5
1:  0  0  0  0  0  0 GICv3  
29 Edge  arch_timer
...
5:  0  0  0  0  0  0 GICv3 
113 Level rk_timer
..

localhost / # cat /proc/timer_list | grep event_handler
get "event_handler:  hrtimer_interrupt"
event_handler:  tick_handle_oneshot_broadcast
event_handler:  hrtimer_interrupt

That should work for my board.


Hi Caesar,

I applied the patches on my tree. I humbly reworded the changelog, if 
you disagree with the content, let me know.


Please, in the future, take care of the following:

 - patch prefix is 'clocksource/driver/: [A-Z].*'

 - the change log is important, it deserves some love.

Thanks.

  -- Daniel


--
  Linaro.org │ Open source software for ARM SoCs

Follow Linaro:   Facebook |
 Twitter |
 Blog

Re: [PATCH v2 0/4] clocksource: rockchip/timer: Support rktimer for rk3399

[Caesar Wang]

On 2016年06月14日 12:00, Huang, Tao wrote:

Hi Daniel:
On 2016年06月13日 21:06, Daniel Lezcano wrote:

On Tue, Jun 07, 2016 at 12:54:29PM +0800, Caesar Wang wrote:

This series patches had been tested on rockchip inside kernel.
In order to support the rk3399 SoC timer and turn off interrupts and IPIs to
save power in idle.

For my personnal information, are the arch_timer in the same power domain
than the CPU ? IOW, what is the 'always-on' property in the DT ?

Yes. In our SoC design, all arch (generic) timer in the same power
domain of CPU core. So if one CPU core power down, the arch (generic)
timer will lose it's state and stop working.
While rk timer maybe in peri power domain or pmu power domain, so the
timer will still work when CPU power down.

But before RK3399, all SoCs with CPU power domain, do not support auto
power down while cpu idle. So the arch timer can be seem as always on,
i.e. we don't need a broadcast timer at all.


Okay, it still works bootup on rk3288/other SoCs, even though many socs
hasn't used
the broadcast timer.

Yes, unfortunately the SoC design on rk3288 and the previous ones do not
allow to use a cpuidle driver with cpu/cluster power down, so obviously the
broadcast timer is pointless on these boards :)


You are right.


History version:
v1:
https://lkml.org/lkml/2016/5/25/186

Easy to test for my borad.
localhost / # cat /proc/interrupts
CPU0   CPU1   CPU2   CPU3   CPU4   CPU5
1:  0  0  0  0  0  0 GICv3  
29 Edge  arch_timer
...
5:  0  0  0  0  0  0 GICv3 
113 Level rk_timer
..

localhost / # cat /proc/timer_list | grep event_handler
get "event_handler:  hrtimer_interrupt"
event_handler:  tick_handle_oneshot_broadcast
event_handler:  hrtimer_interrupt

What are you trying to demonstrate here ? There are no interrupts for both
arch_timer and rk_timer.


My god!! let's forget it now!
Sorry for forgetting what happened.
---

Re-picked them up for my board since I'm doing other things to run a 
single cpu.


localhost / # cat /proc/interrupts
   CPU0
  1:  0 GICv3  29 Edge  arch_timer
  2:807 GICv3  30 Edge  arch_timer
  5:712 GICv3 113 Level rk_timer




I don't know. Maybe Caesar do something wrong :(
This is my output:
CPU0   CPU1   CPU2   CPU3   CPU4   CPU5

...
   2:   2911   1967   1588   1608   1295   1606
GICv3  30 Edge  arch_timer
   5:578637684626161165
GICv3 113 Level rk_timer





--
caesar wang | software engineer | w...@rock-chip.com

Re: [PATCH v2 0/4] clocksource: rockchip/timer: Support rktimer for rk3399

[Caesar Wang]

On 2016年06月14日 12:00, Huang, Tao wrote:

Hi Daniel:
On 2016年06月13日 21:06, Daniel Lezcano wrote:

On Tue, Jun 07, 2016 at 12:54:29PM +0800, Caesar Wang wrote:

This series patches had been tested on rockchip inside kernel.
In order to support the rk3399 SoC timer and turn off interrupts and IPIs to
save power in idle.

For my personnal information, are the arch_timer in the same power domain
than the CPU ? IOW, what is the 'always-on' property in the DT ?

Yes. In our SoC design, all arch (generic) timer in the same power
domain of CPU core. So if one CPU core power down, the arch (generic)
timer will lose it's state and stop working.
While rk timer maybe in peri power domain or pmu power domain, so the
timer will still work when CPU power down.

But before RK3399, all SoCs with CPU power domain, do not support auto
power down while cpu idle. So the arch timer can be seem as always on,
i.e. we don't need a broadcast timer at all.


Okay, it still works bootup on rk3288/other SoCs, even though many socs
hasn't used
the broadcast timer.

Yes, unfortunately the SoC design on rk3288 and the previous ones do not
allow to use a cpuidle driver with cpu/cluster power down, so obviously the
broadcast timer is pointless on these boards :)


You are right.


History version:
v1:
https://lkml.org/lkml/2016/5/25/186

Easy to test for my borad.
localhost / # cat /proc/interrupts
CPU0   CPU1   CPU2   CPU3   CPU4   CPU5
1:  0  0  0  0  0  0 GICv3  
29 Edge  arch_timer
...
5:  0  0  0  0  0  0 GICv3 
113 Level rk_timer
..

localhost / # cat /proc/timer_list | grep event_handler
get "event_handler:  hrtimer_interrupt"
event_handler:  tick_handle_oneshot_broadcast
event_handler:  hrtimer_interrupt

What are you trying to demonstrate here ? There are no interrupts for both
arch_timer and rk_timer.


My god!! let's forget it now!
Sorry for forgetting what happened.
---

Re-picked them up for my board since I'm doing other things to run a 
single cpu.


localhost / # cat /proc/interrupts
   CPU0
  1:  0 GICv3  29 Edge  arch_timer
  2:807 GICv3  30 Edge  arch_timer
  5:712 GICv3 113 Level rk_timer




I don't know. Maybe Caesar do something wrong :(
This is my output:
CPU0   CPU1   CPU2   CPU3   CPU4   CPU5

...
   2:   2911   1967   1588   1608   1295   1606
GICv3  30 Edge  arch_timer
   5:578637684626161165
GICv3 113 Level rk_timer





--
caesar wang | software engineer | w...@rock-chip.com

Re: [PATCH v2 0/4] clocksource: rockchip/timer: Support rktimer for rk3399

[Huang, Tao]

Hi Daniel:
On 2016年06月13日 21:06, Daniel Lezcano wrote:
> On Tue, Jun 07, 2016 at 12:54:29PM +0800, Caesar Wang wrote:
>> This series patches had been tested on rockchip inside kernel.
>> In order to support the rk3399 SoC timer and turn off interrupts and IPIs to
>> save power in idle.
> 
> For my personnal information, are the arch_timer in the same power domain 
> than the CPU ? IOW, what is the 'always-on' property in the DT ?

Yes. In our SoC design, all arch (generic) timer in the same power
domain of CPU core. So if one CPU core power down, the arch (generic)
timer will lose it's state and stop working.
While rk timer maybe in peri power domain or pmu power domain, so the
timer will still work when CPU power down.

But before RK3399, all SoCs with CPU power domain, do not support auto
power down while cpu idle. So the arch timer can be seem as always on,
i.e. we don't need a broadcast timer at all.

> 
>> Okay, it still works bootup on rk3288/other SoCs, even though many socs 
>> hasn't used
>> the broadcast timer.
> 
> Yes, unfortunately the SoC design on rk3288 and the previous ones do not 
> allow to use a cpuidle driver with cpu/cluster power down, so obviously the 
> broadcast timer is pointless on these boards :)
> 

You are right.

>> History version:
>> v1:
>> https://lkml.org/lkml/2016/5/25/186
>>
>> Easy to test for my borad.
>> localhost / # cat /proc/interrupts
>> CPU0   CPU1   CPU2   CPU3   CPU4   CPU5
>> 1:  0  0  0  0  0  0 
>> GICv3  29 Edge  arch_timer
>> ...
>> 5:  0  0  0  0  0  0 
>> GICv3 113 Level rk_timer
>> ..
>>
>> localhost / # cat /proc/timer_list | grep event_handler
>> get "event_handler:  hrtimer_interrupt"
>> event_handler:  tick_handle_oneshot_broadcast
>> event_handler:  hrtimer_interrupt
> 
> What are you trying to demonstrate here ? There are no interrupts for both 
> arch_timer and rk_timer.

I don't know. Maybe Caesar do something wrong :(
This is my output:
   CPU0   CPU1   CPU2   CPU3   CPU4   CPU5

...
  2:   2911   1967   1588   1608   1295   1606
   GICv3  30 Edge  arch_timer
  5:578637684626161165
   GICv3 113 Level rk_timer

Re: [PATCH v2 0/4] clocksource: rockchip/timer: Support rktimer for rk3399

[Huang, Tao]

Hi Daniel:
On 2016年06月13日 21:06, Daniel Lezcano wrote:
> On Tue, Jun 07, 2016 at 12:54:29PM +0800, Caesar Wang wrote:
>> This series patches had been tested on rockchip inside kernel.
>> In order to support the rk3399 SoC timer and turn off interrupts and IPIs to
>> save power in idle.
> 
> For my personnal information, are the arch_timer in the same power domain 
> than the CPU ? IOW, what is the 'always-on' property in the DT ?

Yes. In our SoC design, all arch (generic) timer in the same power
domain of CPU core. So if one CPU core power down, the arch (generic)
timer will lose it's state and stop working.
While rk timer maybe in peri power domain or pmu power domain, so the
timer will still work when CPU power down.

But before RK3399, all SoCs with CPU power domain, do not support auto
power down while cpu idle. So the arch timer can be seem as always on,
i.e. we don't need a broadcast timer at all.

> 
>> Okay, it still works bootup on rk3288/other SoCs, even though many socs 
>> hasn't used
>> the broadcast timer.
> 
> Yes, unfortunately the SoC design on rk3288 and the previous ones do not 
> allow to use a cpuidle driver with cpu/cluster power down, so obviously the 
> broadcast timer is pointless on these boards :)
> 

You are right.

>> History version:
>> v1:
>> https://lkml.org/lkml/2016/5/25/186
>>
>> Easy to test for my borad.
>> localhost / # cat /proc/interrupts
>> CPU0   CPU1   CPU2   CPU3   CPU4   CPU5
>> 1:  0  0  0  0  0  0 
>> GICv3  29 Edge  arch_timer
>> ...
>> 5:  0  0  0  0  0  0 
>> GICv3 113 Level rk_timer
>> ..
>>
>> localhost / # cat /proc/timer_list | grep event_handler
>> get "event_handler:  hrtimer_interrupt"
>> event_handler:  tick_handle_oneshot_broadcast
>> event_handler:  hrtimer_interrupt
> 
> What are you trying to demonstrate here ? There are no interrupts for both 
> arch_timer and rk_timer.

I don't know. Maybe Caesar do something wrong :(
This is my output:
   CPU0   CPU1   CPU2   CPU3   CPU4   CPU5

...
  2:   2911   1967   1588   1608   1295   1606
   GICv3  30 Edge  arch_timer
  5:578637684626161165
   GICv3 113 Level rk_timer

Re: [PATCH v2 0/4] clocksource: rockchip/timer: Support rktimer for rk3399

[Daniel Lezcano]

On Tue, Jun 07, 2016 at 12:54:29PM +0800, Caesar Wang wrote:
> This series patches had been tested on rockchip inside kernel.
> In order to support the rk3399 SoC timer and turn off interrupts and IPIs to
> save power in idle.

For my personnal information, are the arch_timer in the same power domain 
than the CPU ? IOW, what is the 'always-on' property in the DT ?

> Okay, it still works bootup on rk3288/other SoCs, even though many socs 
> hasn't used
> the broadcast timer.

Yes, unfortunately the SoC design on rk3288 and the previous ones do not 
allow to use a cpuidle driver with cpu/cluster power down, so obviously the 
broadcast timer is pointless on these boards :)

> History version:
> v1:
> https://lkml.org/lkml/2016/5/25/186
> 
> Easy to test for my borad.
> localhost / # cat /proc/interrupts
> CPU0   CPU1   CPU2   CPU3   CPU4   CPU5
> 1:  0  0  0  0  0  0 
> GICv3  29 Edge  arch_timer
> ...
> 5:  0  0  0  0  0  0 
> GICv3 113 Level rk_timer
> ..
> 
> localhost / # cat /proc/timer_list | grep event_handler
> get "event_handler:  hrtimer_interrupt"
> event_handler:  tick_handle_oneshot_broadcast
> event_handler:  hrtimer_interrupt

What are you trying to demonstrate here ? There are no interrupts for both 
arch_timer and rk_timer.

> That should work for my board.

What do you mean ?

Re: [PATCH v2 0/4] clocksource: rockchip/timer: Support rktimer for rk3399

[Daniel Lezcano]

On Tue, Jun 07, 2016 at 12:54:29PM +0800, Caesar Wang wrote:
> This series patches had been tested on rockchip inside kernel.
> In order to support the rk3399 SoC timer and turn off interrupts and IPIs to
> save power in idle.

For my personnal information, are the arch_timer in the same power domain 
than the CPU ? IOW, what is the 'always-on' property in the DT ?

> Okay, it still works bootup on rk3288/other SoCs, even though many socs 
> hasn't used
> the broadcast timer.

Yes, unfortunately the SoC design on rk3288 and the previous ones do not 
allow to use a cpuidle driver with cpu/cluster power down, so obviously the 
broadcast timer is pointless on these boards :)

> History version:
> v1:
> https://lkml.org/lkml/2016/5/25/186
> 
> Easy to test for my borad.
> localhost / # cat /proc/interrupts
> CPU0   CPU1   CPU2   CPU3   CPU4   CPU5
> 1:  0  0  0  0  0  0 
> GICv3  29 Edge  arch_timer
> ...
> 5:  0  0  0  0  0  0 
> GICv3 113 Level rk_timer
> ..
> 
> localhost / # cat /proc/timer_list | grep event_handler
> get "event_handler:  hrtimer_interrupt"
> event_handler:  tick_handle_oneshot_broadcast
> event_handler:  hrtimer_interrupt

What are you trying to demonstrate here ? There are no interrupts for both 
arch_timer and rk_timer.

> That should work for my board.

What do you mean ?

[PATCH v2 0/4] clocksource: rockchip/timer: Support rktimer for rk3399

[Caesar Wang]

This series patches had been tested on rockchip inside kernel.
In order to support the rk3399 SoC timer and turn off interrupts and IPIs to
save power in idle.
Okay, it still works bootup on rk3288/other SoCs, even though many socs hasn't 
used
the broadcast timer.

History version:
v1:
https://lkml.org/lkml/2016/5/25/186

Easy to test for my borad.
localhost / # cat /proc/interrupts
CPU0   CPU1   CPU2   CPU3   CPU4   CPU5
1:  0  0  0  0  0  0 GICv3  
29 Edge  arch_timer
...
5:  0  0  0  0  0  0 GICv3 
113 Level rk_timer
..

localhost / # cat /proc/timer_list | grep event_handler
get "event_handler:  hrtimer_interrupt"
event_handler:  tick_handle_oneshot_broadcast
event_handler:  hrtimer_interrupt

That should work for my board.


Changes in v2:
- Add the Rob' Ack.
- s/cpu_all_mask/cpu_possible_mask/, As Daniel comments on
  https://patchwork.kernel.org/patch/9135053/.
- As the Daniel suggests on https://patchwork.kernel.org/patch/9135061/,
  That will be better for the rockchip timer driver.
- %s/ARM64/arm64.

Huang Tao (2):
  dt-bindings: document rk3399 rk-timer bindings
  arm64: dts: rockchip: add rktimer device node for rk3399

Huang, Tao (2):
  clocksource: rockchip: add dynamic irq flag to the timer
  clocksource: rockchip: add support for rk3399 SoC

 ...chip,rk3288-timer.txt => rockchip,rk-timer.txt} |  6 ++--
 arch/arm64/boot/dts/rockchip/rk3399.dtsi   |  8 +
 drivers/clocksource/rockchip_timer.c   | 36 +-
 3 files changed, 41 insertions(+), 9 deletions(-)
 rename Documentation/devicetree/bindings/timer/{rockchip,rk3288-timer.txt => 
rockchip,rk-timer.txt} (75%)

-- 
1.9.1

[PATCH v2 0/4] clocksource: rockchip/timer: Support rktimer for rk3399

[Caesar Wang]

This series patches had been tested on rockchip inside kernel.
In order to support the rk3399 SoC timer and turn off interrupts and IPIs to
save power in idle.
Okay, it still works bootup on rk3288/other SoCs, even though many socs hasn't 
used
the broadcast timer.

History version:
v1:
https://lkml.org/lkml/2016/5/25/186

Easy to test for my borad.
localhost / # cat /proc/interrupts
CPU0   CPU1   CPU2   CPU3   CPU4   CPU5
1:  0  0  0  0  0  0 GICv3  
29 Edge  arch_timer
...
5:  0  0  0  0  0  0 GICv3 
113 Level rk_timer
..

localhost / # cat /proc/timer_list | grep event_handler
get "event_handler:  hrtimer_interrupt"
event_handler:  tick_handle_oneshot_broadcast
event_handler:  hrtimer_interrupt

That should work for my board.


Changes in v2:
- Add the Rob' Ack.
- s/cpu_all_mask/cpu_possible_mask/, As Daniel comments on
  https://patchwork.kernel.org/patch/9135053/.
- As the Daniel suggests on https://patchwork.kernel.org/patch/9135061/,
  That will be better for the rockchip timer driver.
- %s/ARM64/arm64.

Huang Tao (2):
  dt-bindings: document rk3399 rk-timer bindings
  arm64: dts: rockchip: add rktimer device node for rk3399

Huang, Tao (2):
  clocksource: rockchip: add dynamic irq flag to the timer
  clocksource: rockchip: add support for rk3399 SoC

 ...chip,rk3288-timer.txt => rockchip,rk-timer.txt} |  6 ++--
 arch/arm64/boot/dts/rockchip/rk3399.dtsi   |  8 +
 drivers/clocksource/rockchip_timer.c   | 36 +-
 3 files changed, 41 insertions(+), 9 deletions(-)
 rename Documentation/devicetree/bindings/timer/{rockchip,rk3288-timer.txt => 
rockchip,rk-timer.txt} (75%)

-- 
1.9.1