Re: [PATCH v2 0/8] Fix error message and present UFS variant

[ygardi]

> Hi Yaniv,
>
> 2015-08-23 22:09 GMT+09:00 Yaniv Gardi :
>> V3: fixes a few minor issues.
>>
>> V2: fixes a few issues of unnecessary EXPORT_SYMBOL,
>> types of parameters in routine definition,
>> build errors in case CONFIG_PM is not defined and some
>> other minor fixes.
>
> I've checked outstanding issues I reported for v1 and v2 are fixed
> in this version of series.  So please feel free to add:
>
> Reviewed-by: Akinobu Mita 
>
> I still think that we should introduce print_hex_dump_io() or
> something simpler for dumping __iomem pointer instead of casting
> 'void __force *'.  But it is only used for debug dump function, so
> I don't too much worry about it.
>

Thanks, Mita,
as you say, since this is mainly for debug dump functions, so i agree that
for now, we may keep it as is.

Yaniv

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 0/8] Fix error message and present UFS variant

[ygardi]

> Hi Yaniv,
>
> 2015-08-23 22:09 GMT+09:00 Yaniv Gardi :
>> V3: fixes a few minor issues.
>>
>> V2: fixes a few issues of unnecessary EXPORT_SYMBOL,
>> types of parameters in routine definition,
>> build errors in case CONFIG_PM is not defined and some
>> other minor fixes.
>
> I've checked outstanding issues I reported for v1 and v2 are fixed
> in this version of series.  So please feel free to add:
>
> Reviewed-by: Akinobu Mita 
>
> I still think that we should introduce print_hex_dump_io() or
> something simpler for dumping __iomem pointer instead of casting
> 'void __force *'.  But it is only used for debug dump function, so
> I don't too much worry about it.
>

Thanks, Mita,
as you say, since this is mainly for debug dump functions, so i agree that
for now, we may keep it as is.

Yaniv

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 0/8] Fix error message and present UFS variant

[ygardi]

Thank you Mita,
We appreciate your comments and your time.

will add "Reviewed-by".

regards,
Yaniv


> Hi Yaniv,
>
> 2015-08-23 22:09 GMT+09:00 Yaniv Gardi :
>> V3: fixes a few minor issues.
>>
>> V2: fixes a few issues of unnecessary EXPORT_SYMBOL,
>> types of parameters in routine definition,
>> build errors in case CONFIG_PM is not defined and some
>> other minor fixes.
>
> I've checked outstanding issues I reported for v1 and v2 are fixed
> in this version of series.  So please feel free to add:
>
> Reviewed-by: Akinobu Mita 
>
> I still think that we should introduce print_hex_dump_io() or
> something simpler for dumping __iomem pointer instead of casting
> 'void __force *'.  But it is only used for debug dump function, so
> I don't too much worry about it.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 0/8] Fix error message and present UFS variant

[ygardi]

Thank you Mita,
We appreciate your comments and your time.

will add Reviewed-by.

regards,
Yaniv


 Hi Yaniv,

 2015-08-23 22:09 GMT+09:00 Yaniv Gardi yga...@codeaurora.org:
 V3: fixes a few minor issues.

 V2: fixes a few issues of unnecessary EXPORT_SYMBOL,
 types of parameters in routine definition,
 build errors in case CONFIG_PM is not defined and some
 other minor fixes.

 I've checked outstanding issues I reported for v1 and v2 are fixed
 in this version of series.  So please feel free to add:

 Reviewed-by: Akinobu Mita akinobu.m...@gmail.com

 I still think that we should introduce print_hex_dump_io() or
 something simpler for dumping __iomem pointer instead of casting
 'void __force *'.  But it is only used for debug dump function, so
 I don't too much worry about it.
 --
 To unsubscribe from this list: send the line unsubscribe linux-scsi in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html



--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 0/8] Fix error message and present UFS variant

[Akinobu Mita]

Hi Yaniv,

2015-08-23 22:09 GMT+09:00 Yaniv Gardi :
> V3: fixes a few minor issues.
>
> V2: fixes a few issues of unnecessary EXPORT_SYMBOL,
> types of parameters in routine definition,
> build errors in case CONFIG_PM is not defined and some
> other minor fixes.

I've checked outstanding issues I reported for v1 and v2 are fixed
in this version of series.  So please feel free to add:

Reviewed-by: Akinobu Mita 

I still think that we should introduce print_hex_dump_io() or
something simpler for dumping __iomem pointer instead of casting
'void __force *'.  But it is only used for debug dump function, so
I don't too much worry about it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 0/8] Fix error message and present UFS variant

[Akinobu Mita]

Hi Yaniv,

2015-08-23 22:09 GMT+09:00 Yaniv Gardi yga...@codeaurora.org:
 V3: fixes a few minor issues.

 V2: fixes a few issues of unnecessary EXPORT_SYMBOL,
 types of parameters in routine definition,
 build errors in case CONFIG_PM is not defined and some
 other minor fixes.

I've checked outstanding issues I reported for v1 and v2 are fixed
in this version of series.  So please feel free to add:

Reviewed-by: Akinobu Mita akinobu.m...@gmail.com

I still think that we should introduce print_hex_dump_io() or
something simpler for dumping __iomem pointer instead of casting
'void __force *'.  But it is only used for debug dump function, so
I don't too much worry about it.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2 0/8] Fix error message and present UFS variant

[Yaniv Gardi]

V3: fixes a few minor issues.

V2: fixes a few issues of unnecessary EXPORT_SYMBOL,
types of parameters in routine definition, 
build errors in case CONFIG_PM is not defined and some
other minor fixes.

Yaniv Gardi (8):
  phy: qcom-ufs: fix build error when the component is built as a module
  scsi: ufs-qcom: fix compilation warning if compiled as a module
  scsi: ufs-qcom: update configuration option of SCSI_UFS_QCOM component
  add ufshcd_get_variant ufshcd_set_variant
  scsi: ufs: creates wrapper functions for vops
  scsi: ufs: make the UFS variant a platform device
  scsi: ufs-qcom: add debug prints for test bus
  scsi: ufs-qcom: add QUniPro hardware support and power optimizations

 .../devicetree/bindings/ufs/ufshcd-pltfrm.txt  |   2 +-
 drivers/phy/phy-qcom-ufs.c |  11 +
 drivers/scsi/ufs/Kconfig   |   2 +-
 drivers/scsi/ufs/ufs-qcom.c| 921 -
 drivers/scsi/ufs/ufs-qcom.h|  68 +-
 drivers/scsi/ufs/ufshcd-pltfrm.c   |  92 +-
 drivers/scsi/ufs/ufshcd-pltfrm.h   |  41 +
 drivers/scsi/ufs/ufshcd.c  | 122 ++-
 drivers/scsi/ufs/ufshcd.h  | 149 +++-
 9 files changed, 1072 insertions(+), 336 deletions(-)
 create mode 100644 drivers/scsi/ufs/ufshcd-pltfrm.h

-- 
1.8.5.2

-- 
QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of 
Code Aurora Forum, hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2 0/8] Fix error message and present UFS variant

[Yaniv Gardi]

V3: fixes a few minor issues.

V2: fixes a few issues of unnecessary EXPORT_SYMBOL,
types of parameters in routine definition, 
build errors in case CONFIG_PM is not defined and some
other minor fixes.

Yaniv Gardi (8):
  phy: qcom-ufs: fix build error when the component is built as a module
  scsi: ufs-qcom: fix compilation warning if compiled as a module
  scsi: ufs-qcom: update configuration option of SCSI_UFS_QCOM component
  add ufshcd_get_variant ufshcd_set_variant
  scsi: ufs: creates wrapper functions for vops
  scsi: ufs: make the UFS variant a platform device
  scsi: ufs-qcom: add debug prints for test bus
  scsi: ufs-qcom: add QUniPro hardware support and power optimizations

 .../devicetree/bindings/ufs/ufshcd-pltfrm.txt  |   2 +-
 drivers/phy/phy-qcom-ufs.c |  11 +
 drivers/scsi/ufs/Kconfig   |   2 +-
 drivers/scsi/ufs/ufs-qcom.c| 921 -
 drivers/scsi/ufs/ufs-qcom.h|  68 +-
 drivers/scsi/ufs/ufshcd-pltfrm.c   |  92 +-
 drivers/scsi/ufs/ufshcd-pltfrm.h   |  41 +
 drivers/scsi/ufs/ufshcd.c  | 122 ++-
 drivers/scsi/ufs/ufshcd.h  | 149 +++-
 9 files changed, 1072 insertions(+), 336 deletions(-)
 create mode 100644 drivers/scsi/ufs/ufshcd-pltfrm.h

-- 
1.8.5.2

-- 
QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of 
Code Aurora Forum, hosted by The Linux Foundation
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2 0/8] Fix error message and present UFS variant

[Yaniv Gardi]

V2 fixes a few issues of unnecessary EXPORT_SYMBOL,
types of parameters in routine definition, 
build errors in case CONFIG_PM is not defined and some
other minor fixes.

Yaniv Gardi (8):
  phy: qcom-ufs: fix build error when the component is built as a module
  scsi: ufs-qcom: fix compilation warning if compiled as a module
  scsi: ufs-qcom: update configuration option of SCSI_UFS_QCOM component
  add ufshcd_get_variant ufshcd_set_variant
  scsi: ufs: creates wrapper functions for vops
  scsi: ufs: make the UFS variant a platform device
  scsi: ufs-qcom: add debug prints for test bus
  scsi: ufs-qcom: add QUniPro hardware support and power optimizations

 drivers/phy/phy-qcom-ufs.c   |  11 +
 drivers/scsi/ufs/Kconfig |   2 +-
 drivers/scsi/ufs/ufs-qcom.c  | 917 +++
 drivers/scsi/ufs/ufs-qcom.h  |  68 ++-
 drivers/scsi/ufs/ufshcd-pltfrm.c |  92 +---
 drivers/scsi/ufs/ufshcd-pltfrm.h |  41 ++
 drivers/scsi/ufs/ufshcd.c| 122 +++---
 drivers/scsi/ufs/ufshcd.h| 149 ++-
 8 files changed, 1070 insertions(+), 332 deletions(-)
 create mode 100644 drivers/scsi/ufs/ufshcd-pltfrm.h

-- 
1.8.5.2

-- 
QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of 
Code Aurora Forum, hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2 0/8] Fix error message and present UFS variant

[Yaniv Gardi]

V2 fixes a few issues of unnecessary EXPORT_SYMBOL,
types of parameters in routine definition, 
build errors in case CONFIG_PM is not defined and some
other minor fixes.

Yaniv Gardi (8):
  phy: qcom-ufs: fix build error when the component is built as a module
  scsi: ufs-qcom: fix compilation warning if compiled as a module
  scsi: ufs-qcom: update configuration option of SCSI_UFS_QCOM component
  add ufshcd_get_variant ufshcd_set_variant
  scsi: ufs: creates wrapper functions for vops
  scsi: ufs: make the UFS variant a platform device
  scsi: ufs-qcom: add debug prints for test bus
  scsi: ufs-qcom: add QUniPro hardware support and power optimizations

 drivers/phy/phy-qcom-ufs.c   |  11 +
 drivers/scsi/ufs/Kconfig |   2 +-
 drivers/scsi/ufs/ufs-qcom.c  | 917 +++
 drivers/scsi/ufs/ufs-qcom.h  |  68 ++-
 drivers/scsi/ufs/ufshcd-pltfrm.c |  92 +---
 drivers/scsi/ufs/ufshcd-pltfrm.h |  41 ++
 drivers/scsi/ufs/ufshcd.c| 122 +++---
 drivers/scsi/ufs/ufshcd.h| 149 ++-
 8 files changed, 1070 insertions(+), 332 deletions(-)
 create mode 100644 drivers/scsi/ufs/ufshcd-pltfrm.h

-- 
1.8.5.2

-- 
QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of 
Code Aurora Forum, hosted by The Linux Foundation
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/