Re: [PATCH v2 00/13] PCI: Simplify PCIe port driver
On Fri, Mar 09, 2018 at 12:59:49PM -0600, Bjorn Helgaas wrote: > This is an attempt to move a few things out of the port driver. > > I added these new patches since v1: > > Merge pcieport_if.h into portdrv.h > Merge pcieport_if.h and portdrv.h to reduce clutter > > Remove unnecessary "pcie_ports=auto" parameter > This is the default setting anyway, so specifying the parameter doesn't > do anything. > > Encapsulate pcie_ports_auto inside the port driver > "pcie_ports_auto" was declared in linux/pci.h even though nobody > outside the port driver used it. > > Rename and reverse sense of pcie_ports_auto > "pcie_ports_auto" is connected with the "pcie_ports=native" parameter, > so rename it to match. > > Other changes since v1: > - Rebase onto my pci/portdrv branch. > - Rename pcie_resume_early() to pcie_pme_root_status_cleanup() as > suggested by Rafael. > - Add Rafael's Reviewed-by tags. > > v1: > https://lkml.kernel.org/r/152040297576.240786.1532465558381209070.st...@bhelgaas-glaptop.roam.corp.google.com > > --- > > Bjorn Helgaas (13): > PCI/portdrv: Merge pcieport_if.h into portdrv.h > PCI/PM: Move pcie_clear_root_pme_status() to core > PCI/PM: Clear PCIe PME Status bit in core, not PCIe port driver > PCI/PM: Clear PCIe PME Status bit for Root Complex Event Collectors > PCI/portdrv: Disable port driver in compat mode > PCI/portdrv: Remove pcie_port_bus_type link order dependency > PCI/portdrv: Remove unused PCIE_PORT_SERVICE_VC > PCI/portdrv: Simplify PCIe feature permission checking > PCI/portdrv: Remove unnecessary include of > PCI/portdrv: Remove "pcie_hp=nomsi" kernel parameter > PCI/portdrv: Remove unnecessary "pcie_ports=auto" parameter > PCI/portdrv: Encapsulate pcie_ports_auto inside the port driver > PCI/portdrv: Rename and reverse sense of pcie_ports_auto I applied these with Christoph's acks and Lukas' renaming suggestion to pci/portdrv for v4.17.
[PATCH v2 00/13] PCI: Simplify PCIe port driver
This is an attempt to move a few things out of the port driver. I added these new patches since v1: Merge pcieport_if.h into portdrv.h Merge pcieport_if.h and portdrv.h to reduce clutter Remove unnecessary "pcie_ports=auto" parameter This is the default setting anyway, so specifying the parameter doesn't do anything. Encapsulate pcie_ports_auto inside the port driver "pcie_ports_auto" was declared in linux/pci.h even though nobody outside the port driver used it. Rename and reverse sense of pcie_ports_auto "pcie_ports_auto" is connected with the "pcie_ports=native" parameter, so rename it to match. Other changes since v1: - Rebase onto my pci/portdrv branch. - Rename pcie_resume_early() to pcie_pme_root_status_cleanup() as suggested by Rafael. - Add Rafael's Reviewed-by tags. v1: https://lkml.kernel.org/r/152040297576.240786.1532465558381209070.st...@bhelgaas-glaptop.roam.corp.google.com --- Bjorn Helgaas (13): PCI/portdrv: Merge pcieport_if.h into portdrv.h PCI/PM: Move pcie_clear_root_pme_status() to core PCI/PM: Clear PCIe PME Status bit in core, not PCIe port driver PCI/PM: Clear PCIe PME Status bit for Root Complex Event Collectors PCI/portdrv: Disable port driver in compat mode PCI/portdrv: Remove pcie_port_bus_type link order dependency PCI/portdrv: Remove unused PCIE_PORT_SERVICE_VC PCI/portdrv: Simplify PCIe feature permission checking PCI/portdrv: Remove unnecessary include of PCI/portdrv: Remove "pcie_hp=nomsi" kernel parameter PCI/portdrv: Remove unnecessary "pcie_ports=auto" parameter PCI/portdrv: Encapsulate pcie_ports_auto inside the port driver PCI/portdrv: Rename and reverse sense of pcie_ports_auto Documentation/admin-guide/kernel-parameters.txt | 19 ++--- drivers/acpi/pci_root.c | 13 +++ drivers/pci/hotplug/pciehp.h|2 - drivers/pci/pci-driver.c| 59 +++ drivers/pci/pci.c |9 ++ drivers/pci/pci.h |1 drivers/pci/pcie/Makefile |3 - drivers/pci/pcie/aer/aerdrv.h |2 - drivers/pci/pcie/pcie-dpc.c |2 - drivers/pci/pcie/pcieport_if.h | 71 --- drivers/pci/pcie/pme.c |1 drivers/pci/pcie/portdrv.h | 88 --- drivers/pci/pcie/portdrv_acpi.c |3 - drivers/pci/pcie/portdrv_bus.c | 56 --- drivers/pci/pcie/portdrv_core.c | 73 +++ drivers/pci/pcie/portdrv_pci.c | 54 ++ drivers/pci/probe.c | 10 +++ include/linux/pci.h |5 + 18 files changed, 198 insertions(+), 273 deletions(-) delete mode 100644 drivers/pci/pcie/pcieport_if.h delete mode 100644 drivers/pci/pcie/portdrv_bus.c
