Re: [PATCH v2 01/16] dmaengine: bcm-sba-raid: Minor improvments in comments

2017-08-17 Thread Anup Patel 
On Thu, Aug 17, 2017 at 9:14 AM, Vinod Koul  wrote:
> On Tue, Aug 01, 2017 at 04:07:45PM +0530, Anup Patel wrote:
>> Make section comments consistent across the Broadcom SBA RAID driver
>> by avoiding " SBA " in some of the comments.
>
> and you add more comments..

OK, I will add this to commit description.

>
>>
>> Signed-off-by: Anup Patel 
>> ---
>>  drivers/dma/bcm-sba-raid.c | 9 ++---
>>  1 file changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/dma/bcm-sba-raid.c b/drivers/dma/bcm-sba-raid.c
>> index e41bbc7..76999b7 100644
>> --- a/drivers/dma/bcm-sba-raid.c
>> +++ b/drivers/dma/bcm-sba-raid.c
>> @@ -48,7 +48,8 @@
>>
>>  #include "dmaengine.h"
>>
>> -/* SBA command related defines */
>> +/* == Driver macros and defines = */
>> +
>>  #define SBA_TYPE_SHIFT   48
>>  #define SBA_TYPE_MASKGENMASK(1, 0)
>>  #define SBA_TYPE_A   0x0
>> @@ -88,6 +89,8 @@
>>  #define to_sba_device(dchan) \
>>   container_of(dchan, struct sba_device, dma_chan)
>>
>> +/* = Driver data structures = */
>
> like this!!
>
>> +
>>  enum sba_request_state {
>>   SBA_REQUEST_STATE_FREE = 1,
>>   SBA_REQUEST_STATE_ALLOCED = 2,
>> @@ -164,7 +167,7 @@ struct sba_device {
>>   int reqs_free_count;
>>  };
>>
>> -/* == SBA command helper routines = */
>> +/* == Command helper routines = */
>>
>>  static inline u64 __pure sba_cmd_enc(u64 cmd, u32 val, u32 shift, u32 mask)
>>  {
>> @@ -196,7 +199,7 @@ static inline u32 __pure sba_cmd_pq_c_mdata(u32 d, u32 
>> b1, u32 b0)
>>  ((d & SBA_C_MDATA_DNUM_MASK) << SBA_C_MDATA_DNUM_SHIFT);
>>  }
>>
>> -/* == Channel resource management routines = */
>> +/* == General helper routines = */
>>

Regards,
Anup

Re: [PATCH v2 01/16] dmaengine: bcm-sba-raid: Minor improvments in comments

2017-08-17 Thread Anup Patel 
On Thu, Aug 17, 2017 at 9:14 AM, Vinod Koul  wrote:
> On Tue, Aug 01, 2017 at 04:07:45PM +0530, Anup Patel wrote:
>> Make section comments consistent across the Broadcom SBA RAID driver
>> by avoiding " SBA " in some of the comments.
>
> and you add more comments..

OK, I will add this to commit description.

>
>>
>> Signed-off-by: Anup Patel 
>> ---
>>  drivers/dma/bcm-sba-raid.c | 9 ++---
>>  1 file changed, 6 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/dma/bcm-sba-raid.c b/drivers/dma/bcm-sba-raid.c
>> index e41bbc7..76999b7 100644
>> --- a/drivers/dma/bcm-sba-raid.c
>> +++ b/drivers/dma/bcm-sba-raid.c
>> @@ -48,7 +48,8 @@
>>
>>  #include "dmaengine.h"
>>
>> -/* SBA command related defines */
>> +/* == Driver macros and defines = */
>> +
>>  #define SBA_TYPE_SHIFT   48
>>  #define SBA_TYPE_MASKGENMASK(1, 0)
>>  #define SBA_TYPE_A   0x0
>> @@ -88,6 +89,8 @@
>>  #define to_sba_device(dchan) \
>>   container_of(dchan, struct sba_device, dma_chan)
>>
>> +/* = Driver data structures = */
>
> like this!!
>
>> +
>>  enum sba_request_state {
>>   SBA_REQUEST_STATE_FREE = 1,
>>   SBA_REQUEST_STATE_ALLOCED = 2,
>> @@ -164,7 +167,7 @@ struct sba_device {
>>   int reqs_free_count;
>>  };
>>
>> -/* == SBA command helper routines = */
>> +/* == Command helper routines = */
>>
>>  static inline u64 __pure sba_cmd_enc(u64 cmd, u32 val, u32 shift, u32 mask)
>>  {
>> @@ -196,7 +199,7 @@ static inline u32 __pure sba_cmd_pq_c_mdata(u32 d, u32 
>> b1, u32 b0)
>>  ((d & SBA_C_MDATA_DNUM_MASK) << SBA_C_MDATA_DNUM_SHIFT);
>>  }
>>
>> -/* == Channel resource management routines = */
>> +/* == General helper routines = */
>>

Regards,
Anup

Re: [PATCH v2 01/16] dmaengine: bcm-sba-raid: Minor improvments in comments

2017-08-16 Thread Vinod Koul 
On Tue, Aug 01, 2017 at 04:07:45PM +0530, Anup Patel wrote:
> Make section comments consistent across the Broadcom SBA RAID driver
> by avoiding " SBA " in some of the comments.

and you add more comments..

> 
> Signed-off-by: Anup Patel 
> ---
>  drivers/dma/bcm-sba-raid.c | 9 ++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/bcm-sba-raid.c b/drivers/dma/bcm-sba-raid.c
> index e41bbc7..76999b7 100644
> --- a/drivers/dma/bcm-sba-raid.c
> +++ b/drivers/dma/bcm-sba-raid.c
> @@ -48,7 +48,8 @@
>  
>  #include "dmaengine.h"
>  
> -/* SBA command related defines */
> +/* == Driver macros and defines = */
> +
>  #define SBA_TYPE_SHIFT   48
>  #define SBA_TYPE_MASKGENMASK(1, 0)
>  #define SBA_TYPE_A   0x0
> @@ -88,6 +89,8 @@
>  #define to_sba_device(dchan) \
>   container_of(dchan, struct sba_device, dma_chan)
>  
> +/* = Driver data structures = */

like this!!

> +
>  enum sba_request_state {
>   SBA_REQUEST_STATE_FREE = 1,
>   SBA_REQUEST_STATE_ALLOCED = 2,
> @@ -164,7 +167,7 @@ struct sba_device {
>   int reqs_free_count;
>  };
>  
> -/* == SBA command helper routines = */
> +/* == Command helper routines = */
>  
>  static inline u64 __pure sba_cmd_enc(u64 cmd, u32 val, u32 shift, u32 mask)
>  {
> @@ -196,7 +199,7 @@ static inline u32 __pure sba_cmd_pq_c_mdata(u32 d, u32 
> b1, u32 b0)
>  ((d & SBA_C_MDATA_DNUM_MASK) << SBA_C_MDATA_DNUM_SHIFT);
>  }
>  
> -/* == Channel resource management routines = */
> +/* == General helper routines = */
>  
>  static struct sba_request *sba_alloc_request(struct sba_device *sba)
>  {
> -- 
> 2.7.4
> 

-- 
~Vinod

Re: [PATCH v2 01/16] dmaengine: bcm-sba-raid: Minor improvments in comments

2017-08-16 Thread Vinod Koul 
On Tue, Aug 01, 2017 at 04:07:45PM +0530, Anup Patel wrote:
> Make section comments consistent across the Broadcom SBA RAID driver
> by avoiding " SBA " in some of the comments.

and you add more comments..

> 
> Signed-off-by: Anup Patel 
> ---
>  drivers/dma/bcm-sba-raid.c | 9 ++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/bcm-sba-raid.c b/drivers/dma/bcm-sba-raid.c
> index e41bbc7..76999b7 100644
> --- a/drivers/dma/bcm-sba-raid.c
> +++ b/drivers/dma/bcm-sba-raid.c
> @@ -48,7 +48,8 @@
>  
>  #include "dmaengine.h"
>  
> -/* SBA command related defines */
> +/* == Driver macros and defines = */
> +
>  #define SBA_TYPE_SHIFT   48
>  #define SBA_TYPE_MASKGENMASK(1, 0)
>  #define SBA_TYPE_A   0x0
> @@ -88,6 +89,8 @@
>  #define to_sba_device(dchan) \
>   container_of(dchan, struct sba_device, dma_chan)
>  
> +/* = Driver data structures = */

like this!!

> +
>  enum sba_request_state {
>   SBA_REQUEST_STATE_FREE = 1,
>   SBA_REQUEST_STATE_ALLOCED = 2,
> @@ -164,7 +167,7 @@ struct sba_device {
>   int reqs_free_count;
>  };
>  
> -/* == SBA command helper routines = */
> +/* == Command helper routines = */
>  
>  static inline u64 __pure sba_cmd_enc(u64 cmd, u32 val, u32 shift, u32 mask)
>  {
> @@ -196,7 +199,7 @@ static inline u32 __pure sba_cmd_pq_c_mdata(u32 d, u32 
> b1, u32 b0)
>  ((d & SBA_C_MDATA_DNUM_MASK) << SBA_C_MDATA_DNUM_SHIFT);
>  }
>  
> -/* == Channel resource management routines = */
> +/* == General helper routines = */
>  
>  static struct sba_request *sba_alloc_request(struct sba_device *sba)
>  {
> -- 
> 2.7.4
> 

-- 
~Vinod

[PATCH v2 01/16] dmaengine: bcm-sba-raid: Minor improvments in comments

2017-08-01 Thread Anup Patel 
Make section comments consistent across the Broadcom SBA RAID driver
by avoiding " SBA " in some of the comments.

Signed-off-by: Anup Patel 
---
 drivers/dma/bcm-sba-raid.c | 9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/dma/bcm-sba-raid.c b/drivers/dma/bcm-sba-raid.c
index e41bbc7..76999b7 100644
--- a/drivers/dma/bcm-sba-raid.c
+++ b/drivers/dma/bcm-sba-raid.c
@@ -48,7 +48,8 @@
 
 #include "dmaengine.h"
 
-/* SBA command related defines */
+/* == Driver macros and defines = */
+
 #define SBA_TYPE_SHIFT 48
 #define SBA_TYPE_MASK  GENMASK(1, 0)
 #define SBA_TYPE_A 0x0
@@ -88,6 +89,8 @@
 #define to_sba_device(dchan)   \
container_of(dchan, struct sba_device, dma_chan)
 
+/* = Driver data structures = */
+
 enum sba_request_state {
SBA_REQUEST_STATE_FREE = 1,
SBA_REQUEST_STATE_ALLOCED = 2,
@@ -164,7 +167,7 @@ struct sba_device {
int reqs_free_count;
 };
 
-/* == SBA command helper routines = */
+/* == Command helper routines = */
 
 static inline u64 __pure sba_cmd_enc(u64 cmd, u32 val, u32 shift, u32 mask)
 {
@@ -196,7 +199,7 @@ static inline u32 __pure sba_cmd_pq_c_mdata(u32 d, u32 b1, 
u32 b0)
   ((d & SBA_C_MDATA_DNUM_MASK) << SBA_C_MDATA_DNUM_SHIFT);
 }
 
-/* == Channel resource management routines = */
+/* == General helper routines = */
 
 static struct sba_request *sba_alloc_request(struct sba_device *sba)
 {
-- 
2.7.4

[PATCH v2 01/16] dmaengine: bcm-sba-raid: Minor improvments in comments

2017-08-01 Thread Anup Patel 
Make section comments consistent across the Broadcom SBA RAID driver
by avoiding " SBA " in some of the comments.

Signed-off-by: Anup Patel 
---
 drivers/dma/bcm-sba-raid.c | 9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/dma/bcm-sba-raid.c b/drivers/dma/bcm-sba-raid.c
index e41bbc7..76999b7 100644
--- a/drivers/dma/bcm-sba-raid.c
+++ b/drivers/dma/bcm-sba-raid.c
@@ -48,7 +48,8 @@
 
 #include "dmaengine.h"
 
-/* SBA command related defines */
+/* == Driver macros and defines = */
+
 #define SBA_TYPE_SHIFT 48
 #define SBA_TYPE_MASK  GENMASK(1, 0)
 #define SBA_TYPE_A 0x0
@@ -88,6 +89,8 @@
 #define to_sba_device(dchan)   \
container_of(dchan, struct sba_device, dma_chan)
 
+/* = Driver data structures = */
+
 enum sba_request_state {
SBA_REQUEST_STATE_FREE = 1,
SBA_REQUEST_STATE_ALLOCED = 2,
@@ -164,7 +167,7 @@ struct sba_device {
int reqs_free_count;
 };
 
-/* == SBA command helper routines = */
+/* == Command helper routines = */
 
 static inline u64 __pure sba_cmd_enc(u64 cmd, u32 val, u32 shift, u32 mask)
 {
@@ -196,7 +199,7 @@ static inline u32 __pure sba_cmd_pq_c_mdata(u32 d, u32 b1, 
u32 b0)
   ((d & SBA_C_MDATA_DNUM_MASK) << SBA_C_MDATA_DNUM_SHIFT);
 }
 
-/* == Channel resource management routines = */
+/* == General helper routines = */
 
 static struct sba_request *sba_alloc_request(struct sba_device *sba)
 {
-- 
2.7.4