Re: [PATCH v2 02/11] cpuidle: Fixup IRQ state
On Fri, Aug 21, 2020 at 07:36:43PM +0200, Rafael J. Wysocki wrote: > On Friday, August 21, 2020 10:47:40 AM CEST Peter Zijlstra wrote: > > Match the pattern elsewhere in this file. > > > > Signed-off-by: Peter Zijlstra (Intel) > > Reviewed-by: Steven Rostedt (VMware) > > Tested-by: Marco Elver > > For all patches in the series: > > Acked-by: Rafael J. Wysocki Reviewed-by: Joel Fernandes (Google) thanks, - Joel > > > --- > > drivers/cpuidle/cpuidle.c |3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > --- a/drivers/cpuidle/cpuidle.c > > +++ b/drivers/cpuidle/cpuidle.c > > @@ -153,7 +153,8 @@ static void enter_s2idle_proper(struct c > > */ > > stop_critical_timings(); > > drv->states[index].enter_s2idle(dev, drv, index); > > - WARN_ON(!irqs_disabled()); > > + if (WARN_ON_ONCE(!irqs_disabled())) > > + local_irq_disable(); > > /* > > * timekeeping_resume() that will be called by tick_unfreeze() for the > > * first CPU executing it calls functions containing RCU read-side > > > > > > > > > >
Re: [PATCH v2 02/11] cpuidle: Fixup IRQ state
On Friday, August 21, 2020 10:47:40 AM CEST Peter Zijlstra wrote: > Match the pattern elsewhere in this file. > > Signed-off-by: Peter Zijlstra (Intel) > Reviewed-by: Steven Rostedt (VMware) > Tested-by: Marco Elver For all patches in the series: Acked-by: Rafael J. Wysocki > --- > drivers/cpuidle/cpuidle.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > --- a/drivers/cpuidle/cpuidle.c > +++ b/drivers/cpuidle/cpuidle.c > @@ -153,7 +153,8 @@ static void enter_s2idle_proper(struct c >*/ > stop_critical_timings(); > drv->states[index].enter_s2idle(dev, drv, index); > - WARN_ON(!irqs_disabled()); > + if (WARN_ON_ONCE(!irqs_disabled())) > + local_irq_disable(); > /* >* timekeeping_resume() that will be called by tick_unfreeze() for the >* first CPU executing it calls functions containing RCU read-side > > >
[PATCH v2 02/11] cpuidle: Fixup IRQ state
Match the pattern elsewhere in this file. Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Steven Rostedt (VMware) Tested-by: Marco Elver --- drivers/cpuidle/cpuidle.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/cpuidle/cpuidle.c +++ b/drivers/cpuidle/cpuidle.c @@ -153,7 +153,8 @@ static void enter_s2idle_proper(struct c */ stop_critical_timings(); drv->states[index].enter_s2idle(dev, drv, index); - WARN_ON(!irqs_disabled()); + if (WARN_ON_ONCE(!irqs_disabled())) + local_irq_disable(); /* * timekeeping_resume() that will be called by tick_unfreeze() for the * first CPU executing it calls functions containing RCU read-side
