Re: [PATCH v2 02/25] mfd: axp20x: correct name of temperature data ADC registers

2017-02-08 Thread Lee Jones 
On Fri, 27 Jan 2017, Quentin Schulz wrote:

> The registers 0x56 and 0x57 of AXP22X PMIC store the value of the
> internal temperature of the PMIC.
> 
> This patch modifies the name of these registers from AXP22X_PMIC_ADC_H/L
> to AXP22X_PMIC_TEMP_H/L so their purpose is clearer.
> 
> Signed-off-by: Quentin Schulz 
> ---
> 
> added in v2
> 
>  drivers/mfd/axp20x.c   | 2 +-
>  include/linux/mfd/axp20x.h | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)

For my own reference:
  Acked-for-MFD-by: Lee Jones 
  
> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index 619a83e..9c2fd37 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -102,7 +102,7 @@ static const struct regmap_range axp22x_volatile_ranges[] 
> = {
>   regmap_reg_range(AXP20X_VBUS_IPSOUT_MGMT, AXP20X_VBUS_IPSOUT_MGMT),
>   regmap_reg_range(AXP20X_IRQ1_EN, AXP20X_IRQ5_STATE),
>   regmap_reg_range(AXP22X_GPIO_STATE, AXP22X_GPIO_STATE),
> - regmap_reg_range(AXP22X_PMIC_ADC_H, AXP20X_IPSOUT_V_HIGH_L),
> + regmap_reg_range(AXP22X_PMIC_TEMP_H, AXP20X_IPSOUT_V_HIGH_L),
>   regmap_reg_range(AXP20X_FG_RES, AXP20X_FG_RES),
>  };
>  
> diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h
> index a4860bc..5ecadbb 100644
> --- a/include/linux/mfd/axp20x.h
> +++ b/include/linux/mfd/axp20x.h
> @@ -228,8 +228,8 @@ enum {
>  #define AXP20X_OCV_MAX   0xf
>  
>  /* AXP22X specific registers */
> -#define AXP22X_PMIC_ADC_H0x56
> -#define AXP22X_PMIC_ADC_L0x57
> +#define AXP22X_PMIC_TEMP_H   0x56
> +#define AXP22X_PMIC_TEMP_L   0x57
>  #define AXP22X_TS_ADC_H  0x58
>  #define AXP22X_TS_ADC_L  0x59
>  #define AXP22X_BATLOW_THRES1 0xe6

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v2 02/25] mfd: axp20x: correct name of temperature data ADC registers

2017-02-08 Thread Lee Jones 
On Fri, 27 Jan 2017, Quentin Schulz wrote:

> The registers 0x56 and 0x57 of AXP22X PMIC store the value of the
> internal temperature of the PMIC.
> 
> This patch modifies the name of these registers from AXP22X_PMIC_ADC_H/L
> to AXP22X_PMIC_TEMP_H/L so their purpose is clearer.
> 
> Signed-off-by: Quentin Schulz 
> ---
> 
> added in v2
> 
>  drivers/mfd/axp20x.c   | 2 +-
>  include/linux/mfd/axp20x.h | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)

For my own reference:
  Acked-for-MFD-by: Lee Jones 
  
> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index 619a83e..9c2fd37 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -102,7 +102,7 @@ static const struct regmap_range axp22x_volatile_ranges[] 
> = {
>   regmap_reg_range(AXP20X_VBUS_IPSOUT_MGMT, AXP20X_VBUS_IPSOUT_MGMT),
>   regmap_reg_range(AXP20X_IRQ1_EN, AXP20X_IRQ5_STATE),
>   regmap_reg_range(AXP22X_GPIO_STATE, AXP22X_GPIO_STATE),
> - regmap_reg_range(AXP22X_PMIC_ADC_H, AXP20X_IPSOUT_V_HIGH_L),
> + regmap_reg_range(AXP22X_PMIC_TEMP_H, AXP20X_IPSOUT_V_HIGH_L),
>   regmap_reg_range(AXP20X_FG_RES, AXP20X_FG_RES),
>  };
>  
> diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h
> index a4860bc..5ecadbb 100644
> --- a/include/linux/mfd/axp20x.h
> +++ b/include/linux/mfd/axp20x.h
> @@ -228,8 +228,8 @@ enum {
>  #define AXP20X_OCV_MAX   0xf
>  
>  /* AXP22X specific registers */
> -#define AXP22X_PMIC_ADC_H0x56
> -#define AXP22X_PMIC_ADC_L0x57
> +#define AXP22X_PMIC_TEMP_H   0x56
> +#define AXP22X_PMIC_TEMP_L   0x57
>  #define AXP22X_TS_ADC_H  0x58
>  #define AXP22X_TS_ADC_L  0x59
>  #define AXP22X_BATLOW_THRES1 0xe6

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v2 02/25] mfd: axp20x: correct name of temperature data ADC registers

2017-01-27 Thread Chen-Yu Tsai 
On Fri, Jan 27, 2017 at 4:54 PM, Quentin Schulz
 wrote:
> The registers 0x56 and 0x57 of AXP22X PMIC store the value of the
> internal temperature of the PMIC.
>
> This patch modifies the name of these registers from AXP22X_PMIC_ADC_H/L
> to AXP22X_PMIC_TEMP_H/L so their purpose is clearer.
>
> Signed-off-by: Quentin Schulz 

Acked-by: Chen-Yu Tsai

Re: [PATCH v2 02/25] mfd: axp20x: correct name of temperature data ADC registers

2017-01-27 Thread Chen-Yu Tsai 
On Fri, Jan 27, 2017 at 4:54 PM, Quentin Schulz
 wrote:
> The registers 0x56 and 0x57 of AXP22X PMIC store the value of the
> internal temperature of the PMIC.
>
> This patch modifies the name of these registers from AXP22X_PMIC_ADC_H/L
> to AXP22X_PMIC_TEMP_H/L so their purpose is clearer.
>
> Signed-off-by: Quentin Schulz 

Acked-by: Chen-Yu Tsai

[PATCH v2 02/25] mfd: axp20x: correct name of temperature data ADC registers

2017-01-27 Thread Quentin Schulz 
The registers 0x56 and 0x57 of AXP22X PMIC store the value of the
internal temperature of the PMIC.

This patch modifies the name of these registers from AXP22X_PMIC_ADC_H/L
to AXP22X_PMIC_TEMP_H/L so their purpose is clearer.

Signed-off-by: Quentin Schulz 
---

added in v2

 drivers/mfd/axp20x.c   | 2 +-
 include/linux/mfd/axp20x.h | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
index 619a83e..9c2fd37 100644
--- a/drivers/mfd/axp20x.c
+++ b/drivers/mfd/axp20x.c
@@ -102,7 +102,7 @@ static const struct regmap_range axp22x_volatile_ranges[] = 
{
regmap_reg_range(AXP20X_VBUS_IPSOUT_MGMT, AXP20X_VBUS_IPSOUT_MGMT),
regmap_reg_range(AXP20X_IRQ1_EN, AXP20X_IRQ5_STATE),
regmap_reg_range(AXP22X_GPIO_STATE, AXP22X_GPIO_STATE),
-   regmap_reg_range(AXP22X_PMIC_ADC_H, AXP20X_IPSOUT_V_HIGH_L),
+   regmap_reg_range(AXP22X_PMIC_TEMP_H, AXP20X_IPSOUT_V_HIGH_L),
regmap_reg_range(AXP20X_FG_RES, AXP20X_FG_RES),
 };
 
diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h
index a4860bc..5ecadbb 100644
--- a/include/linux/mfd/axp20x.h
+++ b/include/linux/mfd/axp20x.h
@@ -228,8 +228,8 @@ enum {
 #define AXP20X_OCV_MAX 0xf
 
 /* AXP22X specific registers */
-#define AXP22X_PMIC_ADC_H  0x56
-#define AXP22X_PMIC_ADC_L  0x57
+#define AXP22X_PMIC_TEMP_H 0x56
+#define AXP22X_PMIC_TEMP_L 0x57
 #define AXP22X_TS_ADC_H0x58
 #define AXP22X_TS_ADC_L0x59
 #define AXP22X_BATLOW_THRES1   0xe6
-- 
2.9.3

[PATCH v2 02/25] mfd: axp20x: correct name of temperature data ADC registers

2017-01-27 Thread Quentin Schulz 
The registers 0x56 and 0x57 of AXP22X PMIC store the value of the
internal temperature of the PMIC.

This patch modifies the name of these registers from AXP22X_PMIC_ADC_H/L
to AXP22X_PMIC_TEMP_H/L so their purpose is clearer.

Signed-off-by: Quentin Schulz 
---

added in v2

 drivers/mfd/axp20x.c   | 2 +-
 include/linux/mfd/axp20x.h | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
index 619a83e..9c2fd37 100644
--- a/drivers/mfd/axp20x.c
+++ b/drivers/mfd/axp20x.c
@@ -102,7 +102,7 @@ static const struct regmap_range axp22x_volatile_ranges[] = 
{
regmap_reg_range(AXP20X_VBUS_IPSOUT_MGMT, AXP20X_VBUS_IPSOUT_MGMT),
regmap_reg_range(AXP20X_IRQ1_EN, AXP20X_IRQ5_STATE),
regmap_reg_range(AXP22X_GPIO_STATE, AXP22X_GPIO_STATE),
-   regmap_reg_range(AXP22X_PMIC_ADC_H, AXP20X_IPSOUT_V_HIGH_L),
+   regmap_reg_range(AXP22X_PMIC_TEMP_H, AXP20X_IPSOUT_V_HIGH_L),
regmap_reg_range(AXP20X_FG_RES, AXP20X_FG_RES),
 };
 
diff --git a/include/linux/mfd/axp20x.h b/include/linux/mfd/axp20x.h
index a4860bc..5ecadbb 100644
--- a/include/linux/mfd/axp20x.h
+++ b/include/linux/mfd/axp20x.h
@@ -228,8 +228,8 @@ enum {
 #define AXP20X_OCV_MAX 0xf
 
 /* AXP22X specific registers */
-#define AXP22X_PMIC_ADC_H  0x56
-#define AXP22X_PMIC_ADC_L  0x57
+#define AXP22X_PMIC_TEMP_H 0x56
+#define AXP22X_PMIC_TEMP_L 0x57
 #define AXP22X_TS_ADC_H0x58
 #define AXP22X_TS_ADC_L0x59
 #define AXP22X_BATLOW_THRES1   0xe6
-- 
2.9.3