Re: [PATCH v2 03/18] AT91: G45: DT: Declare a second ram controller
Hi, On 07/07/2014 at 16:25:16 +0200, Maxime Ripard wrote : > The G45 has two identical ram controller, that are defined as a single one, > with two reg cells. > > The proper way to support such a case is to have two separate DT nodes. > This is also the case for the sam9263, please fix it there too. > Signed-off-by: Maxime Ripard > --- > arch/arm/boot/dts/at91sam9g45.dtsi | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi > b/arch/arm/boot/dts/at91sam9g45.dtsi > index ace6bf197b70..6f648b85b725 100644 > --- a/arch/arm/boot/dts/at91sam9g45.dtsi > +++ b/arch/arm/boot/dts/at91sam9g45.dtsi > @@ -75,8 +75,12 @@ > > ramc0: ramc@e400 { > compatible = "atmel,at91sam9g45-ddramc"; > - reg = <0xe400 0x200 > -0xe600 0x200>; > + reg = <0xe400 0x200>; > + }; > + > + ramc1: ramc@e600 { > + compatible = "atmel,at91sam9g45-ddramc"; > + reg = <0xe600 0x200>; > }; > > pmc: pmc@fc00 { > -- > 2.0.1 > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 03/18] AT91: G45: DT: Declare a second ram controller
The G45 has two identical ram controller, that are defined as a single one, with two reg cells. The proper way to support such a case is to have two separate DT nodes. Signed-off-by: Maxime Ripard --- arch/arm/boot/dts/at91sam9g45.dtsi | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi b/arch/arm/boot/dts/at91sam9g45.dtsi index ace6bf197b70..6f648b85b725 100644 --- a/arch/arm/boot/dts/at91sam9g45.dtsi +++ b/arch/arm/boot/dts/at91sam9g45.dtsi @@ -75,8 +75,12 @@ ramc0: ramc@e400 { compatible = "atmel,at91sam9g45-ddramc"; - reg = <0xe400 0x200 - 0xe600 0x200>; + reg = <0xe400 0x200>; + }; + + ramc1: ramc@e600 { + compatible = "atmel,at91sam9g45-ddramc"; + reg = <0xe600 0x200>; }; pmc: pmc@fc00 { -- 2.0.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 03/18] AT91: G45: DT: Declare a second ram controller
The G45 has two identical ram controller, that are defined as a single one, with two reg cells. The proper way to support such a case is to have two separate DT nodes. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com --- arch/arm/boot/dts/at91sam9g45.dtsi | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi b/arch/arm/boot/dts/at91sam9g45.dtsi index ace6bf197b70..6f648b85b725 100644 --- a/arch/arm/boot/dts/at91sam9g45.dtsi +++ b/arch/arm/boot/dts/at91sam9g45.dtsi @@ -75,8 +75,12 @@ ramc0: ramc@e400 { compatible = atmel,at91sam9g45-ddramc; - reg = 0xe400 0x200 - 0xe600 0x200; + reg = 0xe400 0x200; + }; + + ramc1: ramc@e600 { + compatible = atmel,at91sam9g45-ddramc; + reg = 0xe600 0x200; }; pmc: pmc@fc00 { -- 2.0.1 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 03/18] AT91: G45: DT: Declare a second ram controller
Hi, On 07/07/2014 at 16:25:16 +0200, Maxime Ripard wrote : The G45 has two identical ram controller, that are defined as a single one, with two reg cells. The proper way to support such a case is to have two separate DT nodes. This is also the case for the sam9263, please fix it there too. Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com --- arch/arm/boot/dts/at91sam9g45.dtsi | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/at91sam9g45.dtsi b/arch/arm/boot/dts/at91sam9g45.dtsi index ace6bf197b70..6f648b85b725 100644 --- a/arch/arm/boot/dts/at91sam9g45.dtsi +++ b/arch/arm/boot/dts/at91sam9g45.dtsi @@ -75,8 +75,12 @@ ramc0: ramc@e400 { compatible = atmel,at91sam9g45-ddramc; - reg = 0xe400 0x200 -0xe600 0x200; + reg = 0xe400 0x200; + }; + + ramc1: ramc@e600 { + compatible = atmel,at91sam9g45-ddramc; + reg = 0xe600 0x200; }; pmc: pmc@fc00 { -- 2.0.1 -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/