Re: [PATCH v2 05/11] block: sed-opal: print failed function address

[Christoph Hellwig]

On Mon, Mar 19, 2018 at 07:36:47PM +0100, Jonas Rabenstein wrote:
> Add function address (and if available its symbol) to the message if a
> step function fails.

Looks good:

Reviewed-by: Christoph Hellwig 

Re: [PATCH v2 05/11] block: sed-opal: print failed function address

[Christoph Hellwig]

On Mon, Mar 19, 2018 at 07:36:47PM +0100, Jonas Rabenstein wrote:
> Add function address (and if available its symbol) to the message if a
> step function fails.

Looks good:

Reviewed-by: Christoph Hellwig 

[PATCH v2 05/11] block: sed-opal: print failed function address

[Jonas Rabenstein]

Add function address (and if available its symbol) to the message if a
step function fails.

Signed-off-by: Jonas Rabenstein 

diff --git a/block/sed-opal.c b/block/sed-opal.c
index 30f6e46518a6..9b6f14e7aeb1 100644
--- a/block/sed-opal.c
+++ b/block/sed-opal.c
@@ -394,8 +394,8 @@ static int next(struct opal_dev *dev)
 
error = step->fn(dev, step->data);
if (error) {
-   pr_debug("Error on step function: %d with error %d: 
%s\n",
-state, error,
+   pr_debug("Step %d (%pS) failed wit error %d: %s\n",
+state, step->fn, error,
 opal_error_to_human(error));
 
/* For each OPAL command we do a discovery0 then we
-- 
2.16.1

[PATCH v2 05/11] block: sed-opal: print failed function address

[Jonas Rabenstein]

Add function address (and if available its symbol) to the message if a
step function fails.

Signed-off-by: Jonas Rabenstein 

diff --git a/block/sed-opal.c b/block/sed-opal.c
index 30f6e46518a6..9b6f14e7aeb1 100644
--- a/block/sed-opal.c
+++ b/block/sed-opal.c
@@ -394,8 +394,8 @@ static int next(struct opal_dev *dev)
 
error = step->fn(dev, step->data);
if (error) {
-   pr_debug("Error on step function: %d with error %d: 
%s\n",
-state, error,
+   pr_debug("Step %d (%pS) failed wit error %d: %s\n",
+state, step->fn, error,
 opal_error_to_human(error));
 
/* For each OPAL command we do a discovery0 then we
-- 
2.16.1