Re: [PATCH v2 05/11] dt-bindings: mmc: arasan: Update Documentation for the input clock

2019-07-22 Thread Rob Herring
On Mon, Jul 01, 2019 at 10:59:45AM +0530, Manish Narani wrote:
> Add documentation for an optional input clock which is essentially used
> in sampling the input data coming from the card.
> 
> Signed-off-by: Manish Narani 
> ---
>  Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 14 +++---
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt 
> b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> index 15c6397..7c79496 100644
> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
> @@ -23,10 +23,10 @@ Required Properties:
>- reg: From mmc bindings: Register location and length.
>- clocks: From clock bindings: Handles to clock inputs.
>- clock-names: From clock bindings: Tuple including "clk_xin" and "clk_ahb"
> -  Apart from these two there is one more optional clock which
> -  is "clk_sdcard". This clock represents output clock from
> -  controller and card. This must be specified when #clock-cells
> -  is specified.
> +  Apart from these two there are two more optional clocks which
> +  are "clk_sdcard" and "clk_sample". These two clocks represent
> +  output and input clocks between controller and card. These
> +  must be specified when #clock-cells is specified.
>- interrupts: Interrupt specifier
>  
>  Required Properties for "arasan,sdhci-5.1":
> @@ -40,9 +40,9 @@ Optional Properties:
>- clock-output-names: If specified, this will be the name of the card clock
>  which will be exposed by this device.  Required if #clock-cells is
>  specified.
> -  - #clock-cells: If specified this should be the value <0>. With this
> -property in place we will export one clock representing the Card
> -Clock. This clock is expected to be consumed by our PHY. You must also
> +  - #clock-cells: If specified this should be the value <0> or <1>. With this
> +property in place we will export one or two clocks representing the Card
> +Clock. These clocks are expected to be consumed by our PHY. You must also

What are the 2 clocks?

>  specify
>- xlnx,fails-without-test-cd: when present, the controller doesn't work 
> when
>  the CD line is not connected properly, and the line is not connected
> -- 
> 2.1.1
> 


[PATCH v2 05/11] dt-bindings: mmc: arasan: Update Documentation for the input clock

2019-06-30 Thread Manish Narani
Add documentation for an optional input clock which is essentially used
in sampling the input data coming from the card.

Signed-off-by: Manish Narani 
---
 Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt 
b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
index 15c6397..7c79496 100644
--- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
+++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt
@@ -23,10 +23,10 @@ Required Properties:
   - reg: From mmc bindings: Register location and length.
   - clocks: From clock bindings: Handles to clock inputs.
   - clock-names: From clock bindings: Tuple including "clk_xin" and "clk_ahb"
-Apart from these two there is one more optional clock which
-is "clk_sdcard". This clock represents output clock from
-controller and card. This must be specified when #clock-cells
-is specified.
+Apart from these two there are two more optional clocks which
+are "clk_sdcard" and "clk_sample". These two clocks represent
+output and input clocks between controller and card. These
+must be specified when #clock-cells is specified.
   - interrupts: Interrupt specifier
 
 Required Properties for "arasan,sdhci-5.1":
@@ -40,9 +40,9 @@ Optional Properties:
   - clock-output-names: If specified, this will be the name of the card clock
 which will be exposed by this device.  Required if #clock-cells is
 specified.
-  - #clock-cells: If specified this should be the value <0>. With this
-property in place we will export one clock representing the Card
-Clock. This clock is expected to be consumed by our PHY. You must also
+  - #clock-cells: If specified this should be the value <0> or <1>. With this
+property in place we will export one or two clocks representing the Card
+Clock. These clocks are expected to be consumed by our PHY. You must also
 specify
   - xlnx,fails-without-test-cd: when present, the controller doesn't work when
 the CD line is not connected properly, and the line is not connected
-- 
2.1.1