Re: [PATCH v2 06/18] arm64: dts: hisi: Harmonize EHCI/OHCI DT nodes name

2020-11-24 Thread Wei Xu
Hi Serge,

On 2020/11/11 17:15, Serge Semin wrote:
> In accordance with the Generic EHCI/OHCI bindings the corresponding node
> name is suppose to comply with the Generic USB HCD DT schema, which
> requires the USB nodes to have the name acceptable by the regexp:
> "^usb(@.*)?" . Make sure the "generic-ehci" and "generic-ohci"-compatible
> nodes are correctly named.
> 
> Signed-off-by: Serge Semin 
> Acked-by: Krzysztof Kozlowski 
> ---
>  arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi | 4 ++--
>  arch/arm64/boot/dts/hisilicon/hip06.dtsi   | 4 ++--
>  arch/arm64/boot/dts/hisilicon/hip07.dtsi   | 4 ++--
>  3 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi 
> b/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi
> index 12bc1d3ed424..a4acecb75c89 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi
> @@ -585,7 +585,7 @@ pcie: pcie@986 {
>   status = "disabled";
>   };
>  
> - ohci: ohci@988 {
> + ohci: usb@988 {
>   compatible = "generic-ohci";
>   reg = <0x988 0x1>;
>   interrupts = ;
> @@ -600,7 +600,7 @@ ohci: ohci@988 {
>   status = "disabled";
>   };
>  
> - ehci: ehci@989 {
> + ehci: usb@989 {
>   compatible = "generic-ehci";
>   reg = <0x989 0x1>;
>   interrupts = ;
> diff --git a/arch/arm64/boot/dts/hisilicon/hip06.dtsi 
> b/arch/arm64/boot/dts/hisilicon/hip06.dtsi
> index 50ceaa959bdc..1226440d54ad 100644
> --- a/arch/arm64/boot/dts/hisilicon/hip06.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hip06.dtsi
> @@ -373,7 +373,7 @@ refclk: refclk {
>   #clock-cells = <0>;
>   };
>  
> - usb_ohci: ohci@a703 {
> + usb_ohci: usb@a703 {
>   compatible = "generic-ohci";
>   reg = <0x0 0xa703 0x0 0x1>;
>   interrupt-parent = <_usb>;
> @@ -382,7 +382,7 @@ usb_ohci: ohci@a703 {
>   status = "disabled";
>   };
>  
> - usb_ehci: ehci@a702 {
> + usb_ehci: usb@a702 {
>   compatible = "generic-ehci";
>   reg = <0x0 0xa702 0x0 0x1>;
>   interrupt-parent = <_usb>;
> diff --git a/arch/arm64/boot/dts/hisilicon/hip07.dtsi 
> b/arch/arm64/boot/dts/hisilicon/hip07.dtsi
> index 4773a533fce5..93f99a5255ac 100644
> --- a/arch/arm64/boot/dts/hisilicon/hip07.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hip07.dtsi
> @@ -1253,7 +1253,7 @@ uart0: uart@602b {
>   status = "disabled";
>   };
>  
> - usb_ohci: ohci@a703 {
> + usb_ohci: usb@a703 {
>   compatible = "generic-ohci";
>   reg = <0x0 0xa703 0x0 0x1>;
>   interrupt-parent = <_usb>;
> @@ -1262,7 +1262,7 @@ usb_ohci: ohci@a703 {
>   status = "disabled";
>   };
>  
> - usb_ehci: ehci@a702 {
> + usb_ehci: usb@a702 {
>   compatible = "generic-ehci";
>   reg = <0x0 0xa702 0x0 0x1>;
>   interrupt-parent = <_usb>;
> 

Thanks!
But a similar patch has been sent out earlier:
https://patchwork.kernel.org/project/linux-arm-kernel/patch/20201012131739.1655-8-thunder.leiz...@huawei.com/

Best Regards,
Wei


[PATCH v2 06/18] arm64: dts: hisi: Harmonize EHCI/OHCI DT nodes name

2020-11-11 Thread Serge Semin
In accordance with the Generic EHCI/OHCI bindings the corresponding node
name is suppose to comply with the Generic USB HCD DT schema, which
requires the USB nodes to have the name acceptable by the regexp:
"^usb(@.*)?" . Make sure the "generic-ehci" and "generic-ohci"-compatible
nodes are correctly named.

Signed-off-by: Serge Semin 
Acked-by: Krzysztof Kozlowski 
---
 arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi | 4 ++--
 arch/arm64/boot/dts/hisilicon/hip06.dtsi   | 4 ++--
 arch/arm64/boot/dts/hisilicon/hip07.dtsi   | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi 
b/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi
index 12bc1d3ed424..a4acecb75c89 100644
--- a/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi
@@ -585,7 +585,7 @@ pcie: pcie@986 {
status = "disabled";
};
 
-   ohci: ohci@988 {
+   ohci: usb@988 {
compatible = "generic-ohci";
reg = <0x988 0x1>;
interrupts = ;
@@ -600,7 +600,7 @@ ohci: ohci@988 {
status = "disabled";
};
 
-   ehci: ehci@989 {
+   ehci: usb@989 {
compatible = "generic-ehci";
reg = <0x989 0x1>;
interrupts = ;
diff --git a/arch/arm64/boot/dts/hisilicon/hip06.dtsi 
b/arch/arm64/boot/dts/hisilicon/hip06.dtsi
index 50ceaa959bdc..1226440d54ad 100644
--- a/arch/arm64/boot/dts/hisilicon/hip06.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hip06.dtsi
@@ -373,7 +373,7 @@ refclk: refclk {
#clock-cells = <0>;
};
 
-   usb_ohci: ohci@a703 {
+   usb_ohci: usb@a703 {
compatible = "generic-ohci";
reg = <0x0 0xa703 0x0 0x1>;
interrupt-parent = <_usb>;
@@ -382,7 +382,7 @@ usb_ohci: ohci@a703 {
status = "disabled";
};
 
-   usb_ehci: ehci@a702 {
+   usb_ehci: usb@a702 {
compatible = "generic-ehci";
reg = <0x0 0xa702 0x0 0x1>;
interrupt-parent = <_usb>;
diff --git a/arch/arm64/boot/dts/hisilicon/hip07.dtsi 
b/arch/arm64/boot/dts/hisilicon/hip07.dtsi
index 4773a533fce5..93f99a5255ac 100644
--- a/arch/arm64/boot/dts/hisilicon/hip07.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hip07.dtsi
@@ -1253,7 +1253,7 @@ uart0: uart@602b {
status = "disabled";
};
 
-   usb_ohci: ohci@a703 {
+   usb_ohci: usb@a703 {
compatible = "generic-ohci";
reg = <0x0 0xa703 0x0 0x1>;
interrupt-parent = <_usb>;
@@ -1262,7 +1262,7 @@ usb_ohci: ohci@a703 {
status = "disabled";
};
 
-   usb_ehci: ehci@a702 {
+   usb_ehci: usb@a702 {
compatible = "generic-ehci";
reg = <0x0 0xa702 0x0 0x1>;
interrupt-parent = <_usb>;
-- 
2.28.0