Re: [PATCH v2 09/10] ARM: STi: DT: STiH415: 415 DT Entry for clockgen A9

2014-05-20 Thread Olof Johansson 
On Wed, May 14, 2014 at 6:24 AM, Gabriel FERNANDEZ
 wrote:
> Patch adds DT entries for clockgen A9
>
> Signed-off-by: Pankaj Dev 
> Signed-off-by: Gabriel Fernandez 
> ---
>  arch/arm/boot/dts/stih415-clock.dtsi | 48 
> +---
>  1 file changed, 39 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm/boot/dts/stih415-clock.dtsi 
> b/arch/arm/boot/dts/stih415-clock.dtsi
> index 8618851..5d161ee 100644
> --- a/arch/arm/boot/dts/stih415-clock.dtsi
> +++ b/arch/arm/boot/dts/stih415-clock.dtsi
> @@ -24,15 +24,6 @@
> };
>
> /*
> -* ARM Peripheral clock for timers
> -*/
> -   arm_periph_clk: arm_periph_clk {
> -   #clock-cells = <0>;
> -   compatible = "fixed-clock";
> -   clock-frequency = <5>;
> -   };
> -
> -   /*
>  * ClockGenAs on SASG1
>  */
> clockgenA@fee62000 {
> @@ -499,5 +490,44 @@
> /* Remaining outputs unused */
> };
> };
> +
> +   /*
> +* A9 PLL
> +*/
> +   clockgenA9 {

This is a somewhat odd node name. We usually don't use caps mixed like
this. Also, the node should have a unit address (same as the address
portion of the reg value).

clockgen-a9 would be a more natural one.

> +   reg = <0xfdde00d8 0x70>;
> +
> +   CLOCKGEN_A9_PLL: CLOCKGEN_A9_PLL {

I'm really not a fan of the all-caps node names you guys are using.
Please switch to lower case like most other platforms. Just as in C,
we tend to keep all-caps to be used for constants and preprocessor
stuff.


-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 09/10] ARM: STi: DT: STiH415: 415 DT Entry for clockgen A9

2014-05-20 Thread Olof Johansson 
On Wed, May 14, 2014 at 6:24 AM, Gabriel FERNANDEZ
gabriel.fernan...@st.com wrote:
 Patch adds DT entries for clockgen A9

 Signed-off-by: Pankaj Dev pankaj@st.com
 Signed-off-by: Gabriel Fernandez gabriel.fernan...@linaro.org
 ---
  arch/arm/boot/dts/stih415-clock.dtsi | 48 
 +---
  1 file changed, 39 insertions(+), 9 deletions(-)

 diff --git a/arch/arm/boot/dts/stih415-clock.dtsi 
 b/arch/arm/boot/dts/stih415-clock.dtsi
 index 8618851..5d161ee 100644
 --- a/arch/arm/boot/dts/stih415-clock.dtsi
 +++ b/arch/arm/boot/dts/stih415-clock.dtsi
 @@ -24,15 +24,6 @@
 };

 /*
 -* ARM Peripheral clock for timers
 -*/
 -   arm_periph_clk: arm_periph_clk {
 -   #clock-cells = 0;
 -   compatible = fixed-clock;
 -   clock-frequency = 5;
 -   };
 -
 -   /*
  * ClockGenAs on SASG1
  */
 clockgenA@fee62000 {
 @@ -499,5 +490,44 @@
 /* Remaining outputs unused */
 };
 };
 +
 +   /*
 +* A9 PLL
 +*/
 +   clockgenA9 {

This is a somewhat odd node name. We usually don't use caps mixed like
this. Also, the node should have a unit address (same as the address
portion of the reg value).

clockgen-a9 would be a more natural one.

 +   reg = 0xfdde00d8 0x70;
 +
 +   CLOCKGEN_A9_PLL: CLOCKGEN_A9_PLL {

I'm really not a fan of the all-caps node names you guys are using.
Please switch to lower case like most other platforms. Just as in C,
we tend to keep all-caps to be used for constants and preprocessor
stuff.


-Olof
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2 09/10] ARM: STi: DT: STiH415: 415 DT Entry for clockgen A9

2014-05-14 Thread Gabriel FERNANDEZ 
Patch adds DT entries for clockgen A9

Signed-off-by: Pankaj Dev 
Signed-off-by: Gabriel Fernandez 
---
 arch/arm/boot/dts/stih415-clock.dtsi | 48 +---
 1 file changed, 39 insertions(+), 9 deletions(-)

diff --git a/arch/arm/boot/dts/stih415-clock.dtsi 
b/arch/arm/boot/dts/stih415-clock.dtsi
index 8618851..5d161ee 100644
--- a/arch/arm/boot/dts/stih415-clock.dtsi
+++ b/arch/arm/boot/dts/stih415-clock.dtsi
@@ -24,15 +24,6 @@
};
 
/*
-* ARM Peripheral clock for timers
-*/
-   arm_periph_clk: arm_periph_clk {
-   #clock-cells = <0>;
-   compatible = "fixed-clock";
-   clock-frequency = <5>;
-   };
-
-   /*
 * ClockGenAs on SASG1
 */
clockgenA@fee62000 {
@@ -499,5 +490,44 @@
/* Remaining outputs unused */
};
};
+
+   /*
+* A9 PLL
+*/
+   clockgenA9 {
+   reg = <0xfdde00d8 0x70>;
+
+   CLOCKGEN_A9_PLL: CLOCKGEN_A9_PLL {
+   #clock-cells = <1>;
+   compatible = "st,stih415-plls-c32-a9", 
"st,clkgen-plls-c32";
+
+   clocks = <_SYSIN>;
+   clock-output-names = "CLOCKGEN_A9_PLL_ODF";
+   };
+   };
+
+   /*
+* ARM CPU related clocks
+*/
+   CLK_M_A9: CLK_M_A9 {
+   #clock-cells = <0>;
+   compatible = "st,stih415-clkgen-a9-mux", 
"st,clkgen-mux";
+   reg = <0xfdde00d8 0x4>;
+   clocks = <_A9_PLL 0>,
+<_A9_PLL 0>,
+<_M_A0_DIV1 2>,
+<_M_A9_EXT2F_DIV2>;
+   };
+
+   /*
+* ARM Peripheral clock for timers
+*/
+   arm_periph_clk: CLK_M_A9_PERIPHS {
+   #clock-cells = <0>;
+   compatible = "fixed-factor-clock";
+   clocks = <_M_A9>;
+   clock-div = <2>;
+   clock-mult = <1>;
+   };
};
 };
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2 09/10] ARM: STi: DT: STiH415: 415 DT Entry for clockgen A9

2014-05-14 Thread Gabriel FERNANDEZ 
Patch adds DT entries for clockgen A9

Signed-off-by: Pankaj Dev pankaj@st.com
Signed-off-by: Gabriel Fernandez gabriel.fernan...@linaro.org
---
 arch/arm/boot/dts/stih415-clock.dtsi | 48 +---
 1 file changed, 39 insertions(+), 9 deletions(-)

diff --git a/arch/arm/boot/dts/stih415-clock.dtsi 
b/arch/arm/boot/dts/stih415-clock.dtsi
index 8618851..5d161ee 100644
--- a/arch/arm/boot/dts/stih415-clock.dtsi
+++ b/arch/arm/boot/dts/stih415-clock.dtsi
@@ -24,15 +24,6 @@
};
 
/*
-* ARM Peripheral clock for timers
-*/
-   arm_periph_clk: arm_periph_clk {
-   #clock-cells = 0;
-   compatible = fixed-clock;
-   clock-frequency = 5;
-   };
-
-   /*
 * ClockGenAs on SASG1
 */
clockgenA@fee62000 {
@@ -499,5 +490,44 @@
/* Remaining outputs unused */
};
};
+
+   /*
+* A9 PLL
+*/
+   clockgenA9 {
+   reg = 0xfdde00d8 0x70;
+
+   CLOCKGEN_A9_PLL: CLOCKGEN_A9_PLL {
+   #clock-cells = 1;
+   compatible = st,stih415-plls-c32-a9, 
st,clkgen-plls-c32;
+
+   clocks = CLK_SYSIN;
+   clock-output-names = CLOCKGEN_A9_PLL_ODF;
+   };
+   };
+
+   /*
+* ARM CPU related clocks
+*/
+   CLK_M_A9: CLK_M_A9 {
+   #clock-cells = 0;
+   compatible = st,stih415-clkgen-a9-mux, 
st,clkgen-mux;
+   reg = 0xfdde00d8 0x4;
+   clocks = CLOCKGEN_A9_PLL 0,
+CLOCKGEN_A9_PLL 0,
+CLK_M_A0_DIV1 2,
+CLK_M_A9_EXT2F_DIV2;
+   };
+
+   /*
+* ARM Peripheral clock for timers
+*/
+   arm_periph_clk: CLK_M_A9_PERIPHS {
+   #clock-cells = 0;
+   compatible = fixed-factor-clock;
+   clocks = CLK_M_A9;
+   clock-div = 2;
+   clock-mult = 1;
+   };
};
 };
-- 
1.9.1

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/