Re: [PATCH v2 09/16] driver core: add iommu device fault reporting data
On Fri, 6 Oct 2017 10:39:31 +0200 Joerg Roedel wrote: > On Fri, Oct 06, 2017 at 12:11:45AM -0700, Christoph Hellwig wrote: > > This is the 3rd iommu field, in addition to 8 dma-specific fields > > that we carry around for each struct device. > > Agreed, consolidating the iommu-fields in 'struct device' into a > single 'struct iommu_data' is on my todo-list. > > Jacob, can you add that 'struct iommu_data' to 'struct device' and put > your fault-data into it? We can then move on and migrate the other > fields into that struct too. > sounds good.
Re: [PATCH v2 09/16] driver core: add iommu device fault reporting data
On Fri, Oct 06, 2017 at 12:11:45AM -0700, Christoph Hellwig wrote: > This is the 3rd iommu field, in addition to 8 dma-specific fields > that we carry around for each struct device. Agreed, consolidating the iommu-fields in 'struct device' into a single 'struct iommu_data' is on my todo-list. Jacob, can you add that 'struct iommu_data' to 'struct device' and put your fault-data into it? We can then move on and migrate the other fields into that struct too. Regards, Joerg
Re: [PATCH v2 09/16] driver core: add iommu device fault reporting data
On Fri, Oct 06, 2017 at 12:11:45AM -0700, Christoph Hellwig wrote: > On Thu, Oct 05, 2017 at 04:03:37PM -0700, Jacob Pan wrote: > > DMA faults can be detected by IOMMU at device level. Adding a pointer > > to struct device allows IOMMU subsystem to report relevant faults > > back to the device driver for further handling. > > For direct assigned device (or user space drivers), guest OS holds > > responsibility to handle and respond per device IOMMU fault. > > Therefore we need fault reporting mechanism to propagate faults beyond > > IOMMU subsystem. > > We use struct device all over the system, and I don't think we should > bloat it for fringe case IOMMU bits. > > Someone really needs to take a step back and figure out how to move > this into a structure that's only allocated for device that actually > can do physical DMA (and/or have an iommu attached) > > This is the 3rd iommu field, in addition to 8 dma-specific fields > that we carry around for each struct device. Ick, 8? Yeah, it's getting big... How about just a single pointer for iommu and dma-specific stuff that you all can hang crap like this off of if needed? thanks, greg k-h
Re: [PATCH v2 09/16] driver core: add iommu device fault reporting data
On Thu, Oct 05, 2017 at 04:03:37PM -0700, Jacob Pan wrote: > DMA faults can be detected by IOMMU at device level. Adding a pointer > to struct device allows IOMMU subsystem to report relevant faults > back to the device driver for further handling. > For direct assigned device (or user space drivers), guest OS holds > responsibility to handle and respond per device IOMMU fault. > Therefore we need fault reporting mechanism to propagate faults beyond > IOMMU subsystem. We use struct device all over the system, and I don't think we should bloat it for fringe case IOMMU bits. Someone really needs to take a step back and figure out how to move this into a structure that's only allocated for device that actually can do physical DMA (and/or have an iommu attached) This is the 3rd iommu field, in addition to 8 dma-specific fields that we carry around for each struct device.
Re: [PATCH v2 09/16] driver core: add iommu device fault reporting data
On Thu, Oct 05, 2017 at 04:03:37PM -0700, Jacob Pan wrote: > DMA faults can be detected by IOMMU at device level. Adding a pointer > to struct device allows IOMMU subsystem to report relevant faults > back to the device driver for further handling. > For direct assigned device (or user space drivers), guest OS holds > responsibility to handle and respond per device IOMMU fault. > Therefore we need fault reporting mechanism to propagate faults beyond > IOMMU subsystem. > > Signed-off-by: Jacob Pan Acked-by: Greg Kroah-Hartman
[PATCH v2 09/16] driver core: add iommu device fault reporting data
DMA faults can be detected by IOMMU at device level. Adding a pointer
to struct device allows IOMMU subsystem to report relevant faults
back to the device driver for further handling.
For direct assigned device (or user space drivers), guest OS holds
responsibility to handle and respond per device IOMMU fault.
Therefore we need fault reporting mechanism to propagate faults beyond
IOMMU subsystem.
Signed-off-by: Jacob Pan
---
include/linux/device.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/linux/device.h b/include/linux/device.h
index 1d26079..4e3d543 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -42,6 +42,7 @@ struct fwnode_handle;
struct iommu_ops;
struct iommu_group;
struct iommu_fwspec;
+struct iommu_fault_param;
struct bus_attribute {
struct attributeattr;
@@ -873,6 +874,7 @@ struct dev_links_info {
* device (i.e. the bus driver that discovered the device).
* @iommu_group: IOMMU group the device belongs to.
* @iommu_fwspec: IOMMU-specific properties supplied by firmware.
+ * @iommu_fault_param: Per device generic IOMMU runtime parameters
*
* @offline_disabled: If set, the device is permanently online.
* @offline: Set after successful invocation of bus type's .offline().
@@ -962,6 +964,7 @@ struct device {
void(*release)(struct device *dev);
struct iommu_group *iommu_group;
struct iommu_fwspec *iommu_fwspec;
+ struct iommu_fault_param*iommu_fault_param;
booloffline_disabled:1;
booloffline:1;
--
2.7.4
