Re: [PATCH v2 1/2] dt-bindings: media: renesas-ceu: Add R-Mobile R8A7740
On Thu, Apr 26, 2018 at 08:24:42PM +0200, Jacopo Mondi wrote: > Add R-Mobile A1 R8A7740 SoC to the list of compatible values for the CEU > unit. > > Signed-off-by: Jacopo Mondi Reviewed-by: Simon Horman > --- > Documentation/devicetree/bindings/media/renesas,ceu.txt | 7 --- > drivers/media/platform/renesas-ceu.c| 1 + > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/renesas,ceu.txt > b/Documentation/devicetree/bindings/media/renesas,ceu.txt > index 3fc66df..8a7a616 100644 > --- a/Documentation/devicetree/bindings/media/renesas,ceu.txt > +++ b/Documentation/devicetree/bindings/media/renesas,ceu.txt > @@ -2,14 +2,15 @@ Renesas Capture Engine Unit (CEU) > -- > > The Capture Engine Unit is the image capture interface found in the Renesas > -SH Mobile and RZ SoCs. > +SH Mobile, R-Mobile and RZ SoCs. > > The interface supports a single parallel input with data bus width of 8 or 16 > bits. > > Required properties: > -- compatible: Shall be "renesas,r7s72100-ceu" for CEU units found in RZ/A1H > - and RZ/A1M SoCs. > +- compatible: Shall be one of the following values: > + "renesas,r7s72100-ceu" for CEU units found in RZ/A1H and RZ/A1M SoCs > + "renesas,r8a7740-ceu" for CEU units found in R-Mobile A1 R8A7740 SoCs Nit: I think you can drop R8A7740 as I believe that by adding it to R-Mobile A1 you have constructed a tautology (I mean "R-Mobile A1" = "R8A7740" as far as I know). > - reg: Registers address base and size. > - interrupts: The interrupt specifier. > > diff --git a/drivers/media/platform/renesas-ceu.c > b/drivers/media/platform/renesas-ceu.c > index 6599dba..c964a56 100644 > --- a/drivers/media/platform/renesas-ceu.c > +++ b/drivers/media/platform/renesas-ceu.c > @@ -1545,6 +1545,7 @@ static const struct ceu_data ceu_data_sh4 = { > #if IS_ENABLED(CONFIG_OF) > static const struct of_device_id ceu_of_match[] = { > { .compatible = "renesas,r7s72100-ceu", .data = &ceu_data_rz }, > + { .compatible = "renesas,r8a7740-ceu", .data = &ceu_data_rz }, > { } > }; > MODULE_DEVICE_TABLE(of, ceu_of_match); > -- > 2.7.4 >
Re: [PATCH v2 1/2] dt-bindings: media: renesas-ceu: Add R-Mobile R8A7740
On Thu, Apr 26, 2018 at 08:24:42PM +0200, Jacopo Mondi wrote: > Add R-Mobile A1 R8A7740 SoC to the list of compatible values for the CEU > unit. > > Signed-off-by: Jacopo Mondi > --- > Documentation/devicetree/bindings/media/renesas,ceu.txt | 7 --- > drivers/media/platform/renesas-ceu.c| 1 + > 2 files changed, 5 insertions(+), 3 deletions(-) Reviewed-by: Rob Herring
[PATCH v2 1/2] dt-bindings: media: renesas-ceu: Add R-Mobile R8A7740
Add R-Mobile A1 R8A7740 SoC to the list of compatible values for the CEU unit. Signed-off-by: Jacopo Mondi --- Documentation/devicetree/bindings/media/renesas,ceu.txt | 7 --- drivers/media/platform/renesas-ceu.c| 1 + 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/media/renesas,ceu.txt b/Documentation/devicetree/bindings/media/renesas,ceu.txt index 3fc66df..8a7a616 100644 --- a/Documentation/devicetree/bindings/media/renesas,ceu.txt +++ b/Documentation/devicetree/bindings/media/renesas,ceu.txt @@ -2,14 +2,15 @@ Renesas Capture Engine Unit (CEU) -- The Capture Engine Unit is the image capture interface found in the Renesas -SH Mobile and RZ SoCs. +SH Mobile, R-Mobile and RZ SoCs. The interface supports a single parallel input with data bus width of 8 or 16 bits. Required properties: -- compatible: Shall be "renesas,r7s72100-ceu" for CEU units found in RZ/A1H - and RZ/A1M SoCs. +- compatible: Shall be one of the following values: + "renesas,r7s72100-ceu" for CEU units found in RZ/A1H and RZ/A1M SoCs + "renesas,r8a7740-ceu" for CEU units found in R-Mobile A1 R8A7740 SoCs - reg: Registers address base and size. - interrupts: The interrupt specifier. diff --git a/drivers/media/platform/renesas-ceu.c b/drivers/media/platform/renesas-ceu.c index 6599dba..c964a56 100644 --- a/drivers/media/platform/renesas-ceu.c +++ b/drivers/media/platform/renesas-ceu.c @@ -1545,6 +1545,7 @@ static const struct ceu_data ceu_data_sh4 = { #if IS_ENABLED(CONFIG_OF) static const struct of_device_id ceu_of_match[] = { { .compatible = "renesas,r7s72100-ceu", .data = &ceu_data_rz }, + { .compatible = "renesas,r8a7740-ceu", .data = &ceu_data_rz }, { } }; MODULE_DEVICE_TABLE(of, ceu_of_match); -- 2.7.4