Re: [PATCH v2 1/2] gpio: sprd: Fix the incorrect data register

[Bartosz Golaszewski]

śr., 16 sty 2019 o 06:06 Baolin Wang  napisał(a):
>
> From: Neo Hou 
>
> Since differnt type EICs have its own data register to read, thus fix the
> incorrect data register.
>
> Fixes: 25518e024e3a ("gpio: Add Spreadtrum EIC driver support")
> Cc: 
> Signed-off-by: Neo Hou 
> Signed-off-by: Baolin Wang 
> ---
> Changes from v1:
>  - Add fix tag and CC stable.
> ---
>  drivers/gpio/gpio-eic-sprd.c |   13 -
>  1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.c
> index e0d6a0a..257df59 100644
> --- a/drivers/gpio/gpio-eic-sprd.c
> +++ b/drivers/gpio/gpio-eic-sprd.c
> @@ -180,7 +180,18 @@ static void sprd_eic_free(struct gpio_chip *chip, 
> unsigned int offset)
>
>  static int sprd_eic_get(struct gpio_chip *chip, unsigned int offset)
>  {
> -   return sprd_eic_read(chip, offset, SPRD_EIC_DBNC_DATA);
> +   struct sprd_eic *sprd_eic = gpiochip_get_data(chip);
> +
> +   switch (sprd_eic->type) {
> +   case SPRD_EIC_DEBOUNCE:
> +   return sprd_eic_read(chip, offset, SPRD_EIC_DBNC_DATA);
> +   case SPRD_EIC_ASYNC:
> +   return sprd_eic_read(chip, offset, SPRD_EIC_ASYNC_DATA);
> +   case SPRD_EIC_SYNC:
> +   return sprd_eic_read(chip, offset, SPRD_EIC_SYNC_DATA);
> +   default:
> +   return -ENOTSUPP;
> +   }
>  }
>
>  static int sprd_eic_direction_input(struct gpio_chip *chip, unsigned int 
> offset)
> --
> 1.7.9.5
>

Both applied for fixes, thanks!

Bartosz

[PATCH v2 1/2] gpio: sprd: Fix the incorrect data register

[Baolin Wang]

From: Neo Hou 

Since differnt type EICs have its own data register to read, thus fix the
incorrect data register.

Fixes: 25518e024e3a ("gpio: Add Spreadtrum EIC driver support")
Cc: 
Signed-off-by: Neo Hou 
Signed-off-by: Baolin Wang 
---
Changes from v1:
 - Add fix tag and CC stable.
---
 drivers/gpio/gpio-eic-sprd.c |   13 -
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-eic-sprd.c b/drivers/gpio/gpio-eic-sprd.c
index e0d6a0a..257df59 100644
--- a/drivers/gpio/gpio-eic-sprd.c
+++ b/drivers/gpio/gpio-eic-sprd.c
@@ -180,7 +180,18 @@ static void sprd_eic_free(struct gpio_chip *chip, unsigned 
int offset)
 
 static int sprd_eic_get(struct gpio_chip *chip, unsigned int offset)
 {
-   return sprd_eic_read(chip, offset, SPRD_EIC_DBNC_DATA);
+   struct sprd_eic *sprd_eic = gpiochip_get_data(chip);
+
+   switch (sprd_eic->type) {
+   case SPRD_EIC_DEBOUNCE:
+   return sprd_eic_read(chip, offset, SPRD_EIC_DBNC_DATA);
+   case SPRD_EIC_ASYNC:
+   return sprd_eic_read(chip, offset, SPRD_EIC_ASYNC_DATA);
+   case SPRD_EIC_SYNC:
+   return sprd_eic_read(chip, offset, SPRD_EIC_SYNC_DATA);
+   default:
+   return -ENOTSUPP;
+   }
 }
 
 static int sprd_eic_direction_input(struct gpio_chip *chip, unsigned int 
offset)
-- 
1.7.9.5