Re: [PATCH v2 1/2] kcsan: selftest: Ensure that address is at least PAGE_SIZE

2020-10-22 Thread Dmitry Vyukov
On Thu, Oct 22, 2020 at 1:45 PM Marco Elver  wrote:
>
> In preparation of supporting only addresses not within the NULL page,
> change the selftest to never use addresses that are less than PAGE_SIZE.
>
> Signed-off-by: Marco Elver 

Reviewed-by: Dmitry Vyukov 

> ---
> v2:
> * Introduce patch to series.
> ---
>  kernel/kcsan/selftest.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/kernel/kcsan/selftest.c b/kernel/kcsan/selftest.c
> index d98bc208d06d..9014a3a82cf9 100644
> --- a/kernel/kcsan/selftest.c
> +++ b/kernel/kcsan/selftest.c
> @@ -33,6 +33,9 @@ static bool test_encode_decode(void)
> unsigned long addr;
>
> prandom_bytes(&addr, sizeof(addr));
> +   if (addr < PAGE_SIZE)
> +   addr = PAGE_SIZE;
> +
> if (WARN_ON(!check_encodable(addr, size)))
> return false;
>
> --
> 2.29.0.rc1.297.gfa9743e501-goog
>


[PATCH v2 1/2] kcsan: selftest: Ensure that address is at least PAGE_SIZE

2020-10-22 Thread Marco Elver
In preparation of supporting only addresses not within the NULL page,
change the selftest to never use addresses that are less than PAGE_SIZE.

Signed-off-by: Marco Elver 
---
v2:
* Introduce patch to series.
---
 kernel/kcsan/selftest.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/kernel/kcsan/selftest.c b/kernel/kcsan/selftest.c
index d98bc208d06d..9014a3a82cf9 100644
--- a/kernel/kcsan/selftest.c
+++ b/kernel/kcsan/selftest.c
@@ -33,6 +33,9 @@ static bool test_encode_decode(void)
unsigned long addr;
 
prandom_bytes(&addr, sizeof(addr));
+   if (addr < PAGE_SIZE)
+   addr = PAGE_SIZE;
+
if (WARN_ON(!check_encodable(addr, size)))
return false;
 
-- 
2.29.0.rc1.297.gfa9743e501-goog