Re: [PATCH v2 1/3] mm: highmem: export kmap_to_page for modules
On Tue, Oct 23, 2012 at 12:55:57AM +0100, Rusty Russell wrote: > Will Deacon writes: > > > Some virtio device drivers (9p) need to translate high virtual addresses > > to physical addresses, which are inserted into the virtqueue for > > processing by userspace. > > > > This patch exports the kmap_to_page symbol, so that the affected drivers > > can be compiled as modules. > > Thanks Will! > > I've applied these, and add cc:stable. I'll push them to Linus after a > little time in linux-next. Cheers Rusty. Andrew's right about this affecting highmem on x86 too (I guess that's what Sasha saw with the 9p memory issues), so stable makes sense. Will -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 1/3] mm: highmem: export kmap_to_page for modules
Will Deacon writes: > Some virtio device drivers (9p) need to translate high virtual addresses > to physical addresses, which are inserted into the virtqueue for > processing by userspace. > > This patch exports the kmap_to_page symbol, so that the affected drivers > can be compiled as modules. Thanks Will! I've applied these, and add cc:stable. I'll push them to Linus after a little time in linux-next. Cheers, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v2 1/3] mm: highmem: export kmap_to_page for modules
On Fri, 19 Oct 2012 14:03:31 +0100 Will Deacon wrote: > Some virtio device drivers (9p) need to translate high virtual addresses > to physical addresses, which are inserted into the virtqueue for > processing by userspace. > > This patch exports the kmap_to_page symbol, so that the affected drivers > can be compiled as modules. > > Signed-off-by: Will Deacon > --- > mm/highmem.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/mm/highmem.c b/mm/highmem.c > index d517cd1..2a07f97 100644 > --- a/mm/highmem.c > +++ b/mm/highmem.c > @@ -105,6 +105,7 @@ struct page *kmap_to_page(void *vaddr) > > return virt_to_page(addr); > } > +EXPORT_SYMBOL(kmap_to_page); > Looks OK to me. Would generally prefer that an exported-to-modules symbol have some documentation, but I guess this one is obvious enough. Rusty, please include this if you grab the rest of the series. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH v2 1/3] mm: highmem: export kmap_to_page for modules
Some virtio device drivers (9p) need to translate high virtual addresses to physical addresses, which are inserted into the virtqueue for processing by userspace. This patch exports the kmap_to_page symbol, so that the affected drivers can be compiled as modules. Signed-off-by: Will Deacon --- mm/highmem.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/mm/highmem.c b/mm/highmem.c index d517cd1..2a07f97 100644 --- a/mm/highmem.c +++ b/mm/highmem.c @@ -105,6 +105,7 @@ struct page *kmap_to_page(void *vaddr) return virt_to_page(addr); } +EXPORT_SYMBOL(kmap_to_page); static void flush_all_zero_pkmaps(void) { -- 1.7.4.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/