Re: [PATCH v2 1/4] fix style of block comments

2020-07-26 Thread Rohit K Bharadwaj
On 26/07/20 2:18 pm, Rohit K Bharadwaj wrote:
> this patch fixes the coding style of block comments.
> 
> Signed-off-by: Rohit K Bharadwaj 
> ---
> v2: split patch into sequence of patches 
> v1: fix all coding style issues in single patch
> 
>  .../media/atomisp/pci/sh_css_firmware.c   | 28 +--
>  1 file changed, 19 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/sh_css_firmware.c 
> b/drivers/staging/media/atomisp/pci/sh_css_firmware.c
> index d4ab15b6d1ac..2907aead98b7 100644
> --- a/drivers/staging/media/atomisp/pci/sh_css_firmware.c
> +++ b/drivers/staging/media/atomisp/pci/sh_css_firmware.c
> @@ -51,9 +51,12 @@ struct fw_param {
>  
>  static struct firmware_header *firmware_header;
>  
> -/* The string STR is a place holder
> +/*
> + * The string STR is a place holder
>   * which will be replaced with the actual RELEASE_VERSION
> - * during package generation. Please do not modify  */
> + * during package generation. Please do not modify
> + */
> +
>  static const char *isp2400_release_version = 
> STR(irci_stable_candrpv_0415_20150521_0458);
>  static const char *isp2401_release_version = STR(irci_ecr - 
> master_20150911_0724);
>  
> @@ -276,10 +279,11 @@ sh_css_load_firmware(struct device *dev, const char 
> *fw_data,
>   for (i = 0; i < sh_css_num_binaries; i++)
>   {
>   struct ia_css_fw_info *bi = [i];
> - /* note: the var below is made static as it is quite large;
> -if it is not static it ends up on the stack which could
> -cause issues for drivers
> - */
> + /*
> +  * note: the var below is made static as it is quite large;
> +  * if it is not static it ends up on the stack which could
> +  * cause issues for drivers
> +  */
>   static struct ia_css_blob_descr bd;
>   int err;
>  
> @@ -333,7 +337,11 @@ sh_css_load_firmware(struct device *dev, const char 
> *fw_data,
>   return err;
>  
>   } else {
> - /* All subsequent binaries (including bootloaders) 
> (i>NUM_OF_SPS) are ISP firmware */
> + /*
> +  * All subsequent binaries
> +  * (including bootloaders) (i>NUM_OF_SPS)
> +  * are ISP firmware
> +  */
>   if (i < NUM_OF_SPS)
>   return -EINVAL;
>  
> @@ -374,8 +382,10 @@ ia_css_ptr
>  sh_css_load_blob(const unsigned char *blob, unsigned int size)
>  {
>   ia_css_ptr target_addr = hmm_alloc(size, HMM_BO_PRIVATE, 0, NULL, 0);
> - /* this will allocate memory aligned to a DDR word boundary which
> -is required for the CSS DMA to read the instructions. */
> + /*
> +  * this will allocate memory aligned to a DDR word boundary which
> +  * is required for the CSS DMA to read the instructions.
> +  */
>  
>   assert(blob);
>   if (target_addr)
> 
I'm really sorry for the spam, please excuse me, I realized that I didn't 
change the subject prefix so will send another version, apologies for any 
inconvenience caused.


[PATCH v2 1/4] fix style of block comments

2020-07-26 Thread Rohit K Bharadwaj
this patch fixes the coding style of block comments.

Signed-off-by: Rohit K Bharadwaj 
---
v2: split patch into sequence of patches 
v1: fix all coding style issues in single patch

 .../media/atomisp/pci/sh_css_firmware.c   | 28 +--
 1 file changed, 19 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/sh_css_firmware.c 
b/drivers/staging/media/atomisp/pci/sh_css_firmware.c
index d4ab15b6d1ac..2907aead98b7 100644
--- a/drivers/staging/media/atomisp/pci/sh_css_firmware.c
+++ b/drivers/staging/media/atomisp/pci/sh_css_firmware.c
@@ -51,9 +51,12 @@ struct fw_param {
 
 static struct firmware_header *firmware_header;
 
-/* The string STR is a place holder
+/*
+ * The string STR is a place holder
  * which will be replaced with the actual RELEASE_VERSION
- * during package generation. Please do not modify  */
+ * during package generation. Please do not modify
+ */
+
 static const char *isp2400_release_version = 
STR(irci_stable_candrpv_0415_20150521_0458);
 static const char *isp2401_release_version = STR(irci_ecr - 
master_20150911_0724);
 
@@ -276,10 +279,11 @@ sh_css_load_firmware(struct device *dev, const char 
*fw_data,
for (i = 0; i < sh_css_num_binaries; i++)
{
struct ia_css_fw_info *bi = [i];
-   /* note: the var below is made static as it is quite large;
-  if it is not static it ends up on the stack which could
-  cause issues for drivers
-   */
+   /*
+* note: the var below is made static as it is quite large;
+* if it is not static it ends up on the stack which could
+* cause issues for drivers
+*/
static struct ia_css_blob_descr bd;
int err;
 
@@ -333,7 +337,11 @@ sh_css_load_firmware(struct device *dev, const char 
*fw_data,
return err;
 
} else {
-   /* All subsequent binaries (including bootloaders) 
(i>NUM_OF_SPS) are ISP firmware */
+   /*
+* All subsequent binaries
+* (including bootloaders) (i>NUM_OF_SPS)
+* are ISP firmware
+*/
if (i < NUM_OF_SPS)
return -EINVAL;
 
@@ -374,8 +382,10 @@ ia_css_ptr
 sh_css_load_blob(const unsigned char *blob, unsigned int size)
 {
ia_css_ptr target_addr = hmm_alloc(size, HMM_BO_PRIVATE, 0, NULL, 0);
-   /* this will allocate memory aligned to a DDR word boundary which
-  is required for the CSS DMA to read the instructions. */
+   /*
+* this will allocate memory aligned to a DDR word boundary which
+* is required for the CSS DMA to read the instructions.
+*/
 
assert(blob);
if (target_addr)
-- 
2.25.1