Re: [PATCH v2 1/4] staging: rtl8192u: fix comments

2015-01-10 Thread Greg KH 
On Wed, Dec 31, 2014 at 09:10:40PM +, Lorenzo Stoakes wrote:
> This patch fixes errors raised by checkpatch.pl relating to use of C99 
> comments
> in r8192U_dm.c and cleans up existing ANSI C comments.
> 
> Signed-off-by: Lorenzo Stoakes 
> ---
>  drivers/staging/rtl8192u/r8192U_dm.c | 811 
> ++-
>  1 file changed, 420 insertions(+), 391 deletions(-)

This patch series is confusing to me as to which ones are the "latest"
ones, can you resend the latest versions so that I have a chance to
figure it out easier?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2 1/4] staging: rtl8192u: fix comments

2014-12-31 Thread Lorenzo Stoakes 
This patch fixes errors raised by checkpatch.pl relating to use of C99 comments
in r8192U_dm.c and cleans up existing ANSI C comments.

Signed-off-by: Lorenzo Stoakes 
---
 drivers/staging/rtl8192u/r8192U_dm.c | 811 ++-
 1 file changed, 420 insertions(+), 391 deletions(-)

diff --git a/drivers/staging/rtl8192u/r8192U_dm.c 
b/drivers/staging/rtl8192u/r8192U_dm.c
index 936565d..cafc717 100644
--- a/drivers/staging/rtl8192u/r8192U_dm.c
+++ b/drivers/staging/rtl8192u/r8192U_dm.c
@@ -21,9 +21,7 @@ Major Change History:
 #include "r8190_rtl8256.h"
 #include "r819xU_cmdpkt.h"
 /*---Define Local Constant---*/
-//
-// Indicate different AP vendor for IOT issue.
-//
+/* Indicate different AP vendor for IOT issue. */
 static u32 edca_setting_DL[HT_IOT_PEER_MAX] =
{ 0x5e4322, 0x5e4322,   0x5e4322,   0x604322,   
0xa44f, 0x5ea44f};
 static u32 edca_setting_UL[HT_IOT_PEER_MAX] =
@@ -36,11 +34,11 @@ static u32 edca_setting_UL[HT_IOT_PEER_MAX] =


 /*Define global variable-*/
-// Debug variable ?
+/* Debug variable ? */
 dig_t  dm_digtable;
-// Store current software write register content for MAC PHY.
+/* Store current software write register content for MAC PHY. */
 u8 dm_shadow[16][256] = {{0}};
-// For Dynamic Rx Path Selection by Signal Strength
+/* For Dynamic Rx Path Selection by Signal Strength */
 DRxPathSel DM_RxPathSelTable;
 /*Define global variable-*/

@@ -56,24 +54,24 @@ extern  void dm_check_fsync(struct net_device *dev);


 /*-Define local function prototype---*/
-// DM --> Rate Adaptive
+/* DM --> Rate Adaptive */
 static voiddm_check_rate_adaptive(struct net_device *dev);

-// DM --> Bandwidth switch
+/* DM --> Bandwidth switch */
 static voiddm_init_bandwidth_autoswitch(struct net_device *dev);
 static voiddm_bandwidth_autoswitch(struct net_device *dev);

-// DM --> TX power control
-//static   voiddm_initialize_txpower_tracking(struct net_device *dev);
+/* DM --> TX power control */
+/*static   voiddm_initialize_txpower_tracking(struct net_device 
*dev);*/

 static voiddm_check_txpower_tracking(struct net_device *dev);



-//static   voiddm_txpower_reset_recovery(struct net_device *dev);
+/*static   voiddm_txpower_reset_recovery(struct net_device *dev);*/


-// DM --> Dynamic Init Gain by RSSI
+/* DM --> Dynamic Init Gain by RSSI */
 static voiddm_dig_init(struct net_device *dev);
 static voiddm_ctrl_initgain_byrssi(struct net_device *dev);
 static voiddm_ctrl_initgain_byrssi_highpwr(struct net_device *dev);
@@ -84,61 +82,61 @@ static  voiddm_pd_th(struct net_device *dev);
 static voiddm_cs_ratio(struct net_device *dev);

 static void dm_init_ctstoself(struct net_device *dev);
-// DM --> EDCA turbo mode control
+/* DM --> EDCA turbo mode control */
 static voiddm_check_edca_turbo(struct net_device *dev);

-//static   voiddm_gpio_change_rf(struct net_device *dev);
-// DM --> Check PBC
+/*static   voiddm_gpio_change_rf(struct net_device *dev);*/
+/* DM --> Check PBC */
 static void dm_check_pbc_gpio(struct net_device *dev);


-// DM --> Check current RX RF path state
+/* DM --> Check current RX RF path state */
 static voiddm_check_rx_path_selection(struct net_device *dev);
 static void dm_init_rxpath_selection(struct net_device *dev);
 static void dm_rxpath_sel_byrssi(struct net_device *dev);


-// DM --> Fsync for broadcom ap
+/* DM --> Fsync for broadcom ap */
 static void dm_init_fsync(struct net_device *dev);
 static void dm_deInit_fsync(struct net_device *dev);

-//Added by vivi, 20080522
+/* Added by vivi, 20080522 */
 static voiddm_check_txrateandretrycount(struct net_device *dev);

 /*-Define local function prototype---*/

-/*-Define of Tx Power Control For Near/Far Range 
*/   //Add by Jacken 2008/02/18
+/*-Define of Tx Power Control For Near/Far Range 
*/   /*Add by Jacken 2008/02/18 */
 static voiddm_init_dynamic_txpower(struct net_device *dev);
 static voiddm_dynamic_txpower(struct net_device *dev);


-// DM --> For rate adaptive and DIG, we must send RSSI to firmware
+/* DM --> For rate adaptive and DIG, we must send RSSI to firmware */
 static void dm_send_rssi_tofw(struct net_device *dev);
 static voiddm_ctstoself(struct net_device *dev);
 /*---Define function 
prototype*/
-//
-// HW Dynamic mechanism interface.
-//
-
-//
-// Description:
-// Prepare SW resource for HW dynamic mecha