Re: [PATCH v2 1/6] ASoC: atmel: enable SOC_SSC_PDC and SOC_SSC_DMA in Kconfig

2019-08-26 Thread Alexandre Belloni
On 24/08/2019 22:26:52+0200, Michał Mirosław wrote:
> Allow SSC to be used on platforms described using audio-graph-card
> in Device Tree.
> 
> Signed-off-by: Michał Mirosław 
Acked-by: Alexandre Belloni 

> 
> ---
>  v2: extended to PDC mode
>  reworked and fixed Kconfig option dependencies
> 
> ---
>  sound/soc/atmel/Kconfig | 30 ++
>  1 file changed, 18 insertions(+), 12 deletions(-)
> 
> diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig
> index 06c1d5ce642c..f118c229ed82 100644
> --- a/sound/soc/atmel/Kconfig
> +++ b/sound/soc/atmel/Kconfig
> @@ -12,25 +12,31 @@ if SND_ATMEL_SOC
>  config SND_ATMEL_SOC_PDC
>   tristate
>   depends on HAS_DMA
> - default m if SND_ATMEL_SOC_SSC_PDC=m && SND_ATMEL_SOC_SSC=m
> - default y if SND_ATMEL_SOC_SSC_PDC=y || (SND_ATMEL_SOC_SSC_PDC=m && 
> SND_ATMEL_SOC_SSC=y)
> -
> -config SND_ATMEL_SOC_SSC_PDC
> - tristate
>  
>  config SND_ATMEL_SOC_DMA
>   tristate
>   select SND_SOC_GENERIC_DMAENGINE_PCM
> - default m if SND_ATMEL_SOC_SSC_DMA=m && SND_ATMEL_SOC_SSC=m
> - default y if SND_ATMEL_SOC_SSC_DMA=y || (SND_ATMEL_SOC_SSC_DMA=m && 
> SND_ATMEL_SOC_SSC=y)
> -
> -config SND_ATMEL_SOC_SSC_DMA
> - tristate
>  
>  config SND_ATMEL_SOC_SSC
>   tristate
> - default y if SND_ATMEL_SOC_SSC_DMA=y || SND_ATMEL_SOC_SSC_PDC=y
> - default m if SND_ATMEL_SOC_SSC_DMA=m || SND_ATMEL_SOC_SSC_PDC=m
> +
> +config SND_ATMEL_SOC_SSC_PDC
> + tristate "SoC PCM DAI support for AT91 SSC controller using PDC"
> + depends on ATMEL_SSC
> + select SND_ATMEL_SOC_PDC
> + select SND_ATMEL_SOC_SSC
> + help
> +   Say Y or M if you want to add support for Atmel SSC interface
> +   in PDC mode configured using audio-graph-card in device-tree.
> +
> +config SND_ATMEL_SOC_SSC_DMA
> + tristate "SoC PCM DAI support for AT91 SSC controller using DMA"
> + depends on ATMEL_SSC
> + select SND_ATMEL_SOC_DMA
> + select SND_ATMEL_SOC_SSC
> + help
> +   Say Y or M if you want to add support for Atmel SSC interface
> +   in DMA mode configured using audio-graph-card in device-tree.
>  
>  config SND_AT91_SOC_SAM9G20_WM8731
>   tristate "SoC Audio support for WM8731-based At91sam9g20 evaluation 
> board"
> -- 
> 2.20.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


Re: [PATCH v2 1/6] ASoC: atmel: enable SOC_SSC_PDC and SOC_SSC_DMA in Kconfig

2019-08-26 Thread Codrin.Ciubotariu
On 24.08.2019 23:26, Michał Mirosław wrote:
> Allow SSC to be used on platforms described using audio-graph-card
> in Device Tree.
> 
> Signed-off-by: Michał Mirosław 

Reviewed-by: Codrin Ciubotariu 

Thanks!

Best regards,
Codrin

> 
> ---
>   v2: extended to PDC mode
>   reworked and fixed Kconfig option dependencies
> 
> ---
>   sound/soc/atmel/Kconfig | 30 ++
>   1 file changed, 18 insertions(+), 12 deletions(-)
> 
> diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig
> index 06c1d5ce642c..f118c229ed82 100644
> --- a/sound/soc/atmel/Kconfig
> +++ b/sound/soc/atmel/Kconfig
> @@ -12,25 +12,31 @@ if SND_ATMEL_SOC
>   config SND_ATMEL_SOC_PDC
>   tristate
>   depends on HAS_DMA
> - default m if SND_ATMEL_SOC_SSC_PDC=m && SND_ATMEL_SOC_SSC=m
> - default y if SND_ATMEL_SOC_SSC_PDC=y || (SND_ATMEL_SOC_SSC_PDC=m && 
> SND_ATMEL_SOC_SSC=y)
> -
> -config SND_ATMEL_SOC_SSC_PDC
> - tristate
>   
>   config SND_ATMEL_SOC_DMA
>   tristate
>   select SND_SOC_GENERIC_DMAENGINE_PCM
> - default m if SND_ATMEL_SOC_SSC_DMA=m && SND_ATMEL_SOC_SSC=m
> - default y if SND_ATMEL_SOC_SSC_DMA=y || (SND_ATMEL_SOC_SSC_DMA=m && 
> SND_ATMEL_SOC_SSC=y)
> -
> -config SND_ATMEL_SOC_SSC_DMA
> - tristate
>   
>   config SND_ATMEL_SOC_SSC
>   tristate
> - default y if SND_ATMEL_SOC_SSC_DMA=y || SND_ATMEL_SOC_SSC_PDC=y
> - default m if SND_ATMEL_SOC_SSC_DMA=m || SND_ATMEL_SOC_SSC_PDC=m
> +
> +config SND_ATMEL_SOC_SSC_PDC
> + tristate "SoC PCM DAI support for AT91 SSC controller using PDC"
> + depends on ATMEL_SSC
> + select SND_ATMEL_SOC_PDC
> + select SND_ATMEL_SOC_SSC
> + help
> +   Say Y or M if you want to add support for Atmel SSC interface
> +   in PDC mode configured using audio-graph-card in device-tree.
> +
> +config SND_ATMEL_SOC_SSC_DMA
> + tristate "SoC PCM DAI support for AT91 SSC controller using DMA"
> + depends on ATMEL_SSC
> + select SND_ATMEL_SOC_DMA
> + select SND_ATMEL_SOC_SSC
> + help
> +   Say Y or M if you want to add support for Atmel SSC interface
> +   in DMA mode configured using audio-graph-card in device-tree.
>   
>   config SND_AT91_SOC_SAM9G20_WM8731
>   tristate "SoC Audio support for WM8731-based At91sam9g20 evaluation 
> board"
> 



[PATCH v2 1/6] ASoC: atmel: enable SOC_SSC_PDC and SOC_SSC_DMA in Kconfig

2019-08-24 Thread Michał Mirosław
Allow SSC to be used on platforms described using audio-graph-card
in Device Tree.

Signed-off-by: Michał Mirosław 

---
 v2: extended to PDC mode
 reworked and fixed Kconfig option dependencies

---
 sound/soc/atmel/Kconfig | 30 ++
 1 file changed, 18 insertions(+), 12 deletions(-)

diff --git a/sound/soc/atmel/Kconfig b/sound/soc/atmel/Kconfig
index 06c1d5ce642c..f118c229ed82 100644
--- a/sound/soc/atmel/Kconfig
+++ b/sound/soc/atmel/Kconfig
@@ -12,25 +12,31 @@ if SND_ATMEL_SOC
 config SND_ATMEL_SOC_PDC
tristate
depends on HAS_DMA
-   default m if SND_ATMEL_SOC_SSC_PDC=m && SND_ATMEL_SOC_SSC=m
-   default y if SND_ATMEL_SOC_SSC_PDC=y || (SND_ATMEL_SOC_SSC_PDC=m && 
SND_ATMEL_SOC_SSC=y)
-
-config SND_ATMEL_SOC_SSC_PDC
-   tristate
 
 config SND_ATMEL_SOC_DMA
tristate
select SND_SOC_GENERIC_DMAENGINE_PCM
-   default m if SND_ATMEL_SOC_SSC_DMA=m && SND_ATMEL_SOC_SSC=m
-   default y if SND_ATMEL_SOC_SSC_DMA=y || (SND_ATMEL_SOC_SSC_DMA=m && 
SND_ATMEL_SOC_SSC=y)
-
-config SND_ATMEL_SOC_SSC_DMA
-   tristate
 
 config SND_ATMEL_SOC_SSC
tristate
-   default y if SND_ATMEL_SOC_SSC_DMA=y || SND_ATMEL_SOC_SSC_PDC=y
-   default m if SND_ATMEL_SOC_SSC_DMA=m || SND_ATMEL_SOC_SSC_PDC=m
+
+config SND_ATMEL_SOC_SSC_PDC
+   tristate "SoC PCM DAI support for AT91 SSC controller using PDC"
+   depends on ATMEL_SSC
+   select SND_ATMEL_SOC_PDC
+   select SND_ATMEL_SOC_SSC
+   help
+ Say Y or M if you want to add support for Atmel SSC interface
+ in PDC mode configured using audio-graph-card in device-tree.
+
+config SND_ATMEL_SOC_SSC_DMA
+   tristate "SoC PCM DAI support for AT91 SSC controller using DMA"
+   depends on ATMEL_SSC
+   select SND_ATMEL_SOC_DMA
+   select SND_ATMEL_SOC_SSC
+   help
+ Say Y or M if you want to add support for Atmel SSC interface
+ in DMA mode configured using audio-graph-card in device-tree.
 
 config SND_AT91_SOC_SAM9G20_WM8731
tristate "SoC Audio support for WM8731-based At91sam9g20 evaluation 
board"
-- 
2.20.1