Re: [PATCH v2 11/15] wimax/i2400m: use new module_firmware_crashed()
On Fri, May 15, 2020 at 09:28:42PM +, Luis Chamberlain wrote:
> This makes use of the new module_firmware_crashed() to help
> annotate when firmware for device drivers crash. When firmware
> crashes devices can sometimes become unresponsive, and recovery
> sometimes requires a driver unload / reload and in the worst cases
> a reboot.
>
> Using a taint flag allows us to annotate when this happens clearly.
>
> Cc: linux-wi...@intel.com
> Cc: Inaky Perez-Gonzalez
> Signed-off-by: Luis Chamberlain
> ---
> drivers/net/wimax/i2400m/rx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wimax/i2400m/rx.c b/drivers/net/wimax/i2400m/rx.c
> index c9fb619a9e01..307a62ca183f 100644
> --- a/drivers/net/wimax/i2400m/rx.c
> +++ b/drivers/net/wimax/i2400m/rx.c
> @@ -712,6 +712,7 @@ void __i2400m_roq_queue(struct i2400m *i2400m, struct
> i2400m_roq *roq,
> dev_err(dev, "SW BUG? failed to insert packet\n");
> dev_err(dev, "ERX: roq %p [ws %u] skb %p nsn %d sn %u\n",
> roq, roq->ws, skb, nsn, roq_data->sn);
> + module_firmware_crashed();
> skb_queue_walk(>queue, skb_itr) {
> roq_data_itr = (struct i2400m_roq_data *) _itr->cb;
> nsn_itr = __i2400m_roq_nsn(roq, roq_data_itr->sn);
> --
> 2.26.2
>
Acked-by: Rafael Aquini
[PATCH v2 11/15] wimax/i2400m: use new module_firmware_crashed()
This makes use of the new module_firmware_crashed() to help
annotate when firmware for device drivers crash. When firmware
crashes devices can sometimes become unresponsive, and recovery
sometimes requires a driver unload / reload and in the worst cases
a reboot.
Using a taint flag allows us to annotate when this happens clearly.
Cc: linux-wi...@intel.com
Cc: Inaky Perez-Gonzalez
Signed-off-by: Luis Chamberlain
---
drivers/net/wimax/i2400m/rx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wimax/i2400m/rx.c b/drivers/net/wimax/i2400m/rx.c
index c9fb619a9e01..307a62ca183f 100644
--- a/drivers/net/wimax/i2400m/rx.c
+++ b/drivers/net/wimax/i2400m/rx.c
@@ -712,6 +712,7 @@ void __i2400m_roq_queue(struct i2400m *i2400m, struct
i2400m_roq *roq,
dev_err(dev, "SW BUG? failed to insert packet\n");
dev_err(dev, "ERX: roq %p [ws %u] skb %p nsn %d sn %u\n",
roq, roq->ws, skb, nsn, roq_data->sn);
+ module_firmware_crashed();
skb_queue_walk(>queue, skb_itr) {
roq_data_itr = (struct i2400m_roq_data *) _itr->cb;
nsn_itr = __i2400m_roq_nsn(roq, roq_data_itr->sn);
--
2.26.2
