Re: [PATCH v2 18/19] PM / devfreq: tegra: Enable COMPILE_TEST for the driver
On 19. 4. 17. 오전 12:52, Dmitry Osipenko wrote: > 16.04.2019 10:43, Chanwoo Choi пишет: >> On 19. 4. 15. 오후 11:55, Dmitry Osipenko wrote: >>> The driver's compilation doesn't have any specific dependencies, hence >>> the COMPILE_TEST option can be supported in Kconfig. >>> >>> Signed-off-by: Dmitry Osipenko >>> --- >>> drivers/devfreq/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig >>> index 78c33ddd4eea..bd6652863e7d 100644 >>> --- a/drivers/devfreq/Kconfig >>> +++ b/drivers/devfreq/Kconfig >>> @@ -93,7 +93,7 @@ config ARM_EXYNOS_BUS_DEVFREQ >>> >>> config ARM_TEGRA_DEVFREQ >>> tristate "NVIDIA Tegra30+ DEVFREQ Driver" >>> - depends on ARCH_TEGRA >>> + depends on ARCH_TEGRA || COMPILE_TEST >>> select PM_OPP >>> help >>> This adds the DEVFREQ driver for the Tegra family of SoCs. >>> >> >> I think that it doesn't need to make it a separate patch. >> You can merge this patch to patch17 and then drop this patch. >> > > I'd prefer to have this change as a separate patch because this is a > logically distinct change from the patch 17. > > OK. Reviewed-by: Chanwoo Choi -- Best Regards, Chanwoo Choi Samsung Electronics
Re: [PATCH v2 18/19] PM / devfreq: tegra: Enable COMPILE_TEST for the driver
16.04.2019 10:43, Chanwoo Choi пишет: > On 19. 4. 15. 오후 11:55, Dmitry Osipenko wrote: >> The driver's compilation doesn't have any specific dependencies, hence >> the COMPILE_TEST option can be supported in Kconfig. >> >> Signed-off-by: Dmitry Osipenko >> --- >> drivers/devfreq/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig >> index 78c33ddd4eea..bd6652863e7d 100644 >> --- a/drivers/devfreq/Kconfig >> +++ b/drivers/devfreq/Kconfig >> @@ -93,7 +93,7 @@ config ARM_EXYNOS_BUS_DEVFREQ >> >> config ARM_TEGRA_DEVFREQ >> tristate "NVIDIA Tegra30+ DEVFREQ Driver" >> -depends on ARCH_TEGRA >> +depends on ARCH_TEGRA || COMPILE_TEST >> select PM_OPP >> help >>This adds the DEVFREQ driver for the Tegra family of SoCs. >> > > I think that it doesn't need to make it a separate patch. > You can merge this patch to patch17 and then drop this patch. > I'd prefer to have this change as a separate patch because this is a logically distinct change from the patch 17.
Re: [PATCH v2 18/19] PM / devfreq: tegra: Enable COMPILE_TEST for the driver
On 19. 4. 15. 오후 11:55, Dmitry Osipenko wrote: > The driver's compilation doesn't have any specific dependencies, hence > the COMPILE_TEST option can be supported in Kconfig. > > Signed-off-by: Dmitry Osipenko > --- > drivers/devfreq/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig > index 78c33ddd4eea..bd6652863e7d 100644 > --- a/drivers/devfreq/Kconfig > +++ b/drivers/devfreq/Kconfig > @@ -93,7 +93,7 @@ config ARM_EXYNOS_BUS_DEVFREQ > > config ARM_TEGRA_DEVFREQ > tristate "NVIDIA Tegra30+ DEVFREQ Driver" > - depends on ARCH_TEGRA > + depends on ARCH_TEGRA || COMPILE_TEST > select PM_OPP > help > This adds the DEVFREQ driver for the Tegra family of SoCs. > I think that it doesn't need to make it a separate patch. You can merge this patch to patch17 and then drop this patch. -- Best Regards, Chanwoo Choi Samsung Electronics
[PATCH v2 18/19] PM / devfreq: tegra: Enable COMPILE_TEST for the driver
The driver's compilation doesn't have any specific dependencies, hence the COMPILE_TEST option can be supported in Kconfig. Signed-off-by: Dmitry Osipenko --- drivers/devfreq/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig index 78c33ddd4eea..bd6652863e7d 100644 --- a/drivers/devfreq/Kconfig +++ b/drivers/devfreq/Kconfig @@ -93,7 +93,7 @@ config ARM_EXYNOS_BUS_DEVFREQ config ARM_TEGRA_DEVFREQ tristate "NVIDIA Tegra30+ DEVFREQ Driver" - depends on ARCH_TEGRA + depends on ARCH_TEGRA || COMPILE_TEST select PM_OPP help This adds the DEVFREQ driver for the Tegra family of SoCs. -- 2.21.0
