Re: [PATCH v2 2/2] ARM: dts: Add exynos5422-odroidxu4 board

2015-09-02 Thread Javier Martinez Canillas 
Hello Krzysztof,

On 09/02/2015 03:30 AM, Krzysztof Kozlowski wrote:
> Add Hardkernel Odroid XU4 board Device Tree sources. The board differs
> from Odroid XU3 and XU3-Lite by:
> 1. No green and red leds (except standard red power led).
> 2. No audio codec.
> 3. Two USB3 ports in host mode (no micro USB3 connector for OTG).
> 4. Realtek RTL8153-CG gigabit network adapter (instead of SMSC9514).
> 5. Additional connector with IO ports (I2S_0, I2C_5).
> 6. No DisplayPort (like XU3-Lite).
> 7. No TI INA231 power measurement sensors (like XU3-Lite).
> 
> Signed-off-by: Krzysztof Kozlowski 
> 

Looks good to me.

Reviewed-by: Javier Martinez Canillas 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2 2/2] ARM: dts: Add exynos5422-odroidxu4 board

2015-09-02 Thread Javier Martinez Canillas 
Hello Krzysztof,

On 09/02/2015 03:30 AM, Krzysztof Kozlowski wrote:
> Add Hardkernel Odroid XU4 board Device Tree sources. The board differs
> from Odroid XU3 and XU3-Lite by:
> 1. No green and red leds (except standard red power led).
> 2. No audio codec.
> 3. Two USB3 ports in host mode (no micro USB3 connector for OTG).
> 4. Realtek RTL8153-CG gigabit network adapter (instead of SMSC9514).
> 5. Additional connector with IO ports (I2S_0, I2C_5).
> 6. No DisplayPort (like XU3-Lite).
> 7. No TI INA231 power measurement sensors (like XU3-Lite).
> 
> Signed-off-by: Krzysztof Kozlowski 
> 

Looks good to me.

Reviewed-by: Javier Martinez Canillas 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2 2/2] ARM: dts: Add exynos5422-odroidxu4 board

2015-09-01 Thread Krzysztof Kozlowski 
Add Hardkernel Odroid XU4 board Device Tree sources. The board differs
from Odroid XU3 and XU3-Lite by:
1. No green and red leds (except standard red power led).
2. No audio codec.
3. Two USB3 ports in host mode (no micro USB3 connector for OTG).
4. Realtek RTL8153-CG gigabit network adapter (instead of SMSC9514).
5. Additional connector with IO ports (I2S_0, I2C_5).
6. No DisplayPort (like XU3-Lite).
7. No TI INA231 power measurement sensors (like XU3-Lite).

Signed-off-by: Krzysztof Kozlowski 

---

Changes since v1:
1. hsi2c_5 and is20 are disabled on Odroid XU4 (after moving these nodes
   to the audio DTSI).
2. Update Samsung's copyright date for XU4 DTS.

I did not add Javier's reviewed-by tag because of splitting audio codec
to separate patch (1/2).
---
 arch/arm/boot/dts/Makefile |  1 +
 arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 51 +-
 arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts| 51 ++
 arch/arm/boot/dts/exynos5422-odroidxu3.dts | 51 ++
 arch/arm/boot/dts/exynos5422-odroidxu4.dts | 48 
 5 files changed, 152 insertions(+), 50 deletions(-)
 create mode 100644 arch/arm/boot/dts/exynos5422-odroidxu4.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 233159d2eaab..3d27fe34647f 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -123,6 +123,7 @@ dtb-$(CONFIG_ARCH_EXYNOS5) += \
exynos5420-smdk5420.dtb \
exynos5422-odroidxu3.dtb \
exynos5422-odroidxu3-lite.dtb \
+   exynos5422-odroidxu4.dtb \
exynos5440-sd5v1.dtb \
exynos5440-ssdk5440.dtb \
exynos5800-peach-pi.dtb
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi 
b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
index 987c15d8ebe5..a83d569baea8 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
@@ -46,40 +46,6 @@
reset-gpios = < 0 1>;
};
 
-   pwmleds {
-   compatible = "pwm-leds";
-
-   greenled {
-   label = "green:mmc0";
-   pwms = < 1 200 0>;
-   pwm-names = "pwm1";
-   /*
-* Green LED is much brighter than the others
-* so limit its max brightness
-*/
-   max_brightness = <127>;
-   linux,default-trigger = "mmc0";
-   };
-
-   blueled {
-   label = "blue:heartbeat";
-   pwms = < 2 200 0>;
-   pwm-names = "pwm2";
-   max_brightness = <255>;
-   linux,default-trigger = "heartbeat";
-   };
-   };
-
-   gpioleds {
-   compatible = "gpio-leds";
-   redled {
-   label = "red:microSD";
-   gpios = < 3 GPIO_ACTIVE_HIGH>;
-   default-state = "off";
-   linux,default-trigger = "mmc1";
-   };
-   };
-
fan0: pwm-fan {
compatible = "pwm-fan";
pwms = < 0 20972 0>;
@@ -417,19 +383,6 @@
};
 };
 
- {
-   /*
-* PWM 0 -- fan
-* PWM 1 -- Green LED
-* PWM 2 -- Blue LED
-* PWM 3 -- on MIPI connector for backlight
-*/
-   pinctrl-0 = <_out _out _out _out>;
-   pinctrl-names = "default";
-   samsung,pwm-outputs = <0>;
-   status = "okay";
-};
-
 _cpu0 {
vtmu-supply = <_reg>;
status = "okay";
@@ -465,9 +418,7 @@
dr_mode = "host";
 };
 
-_dwc3_1 {
-   dr_mode = "otg";
-};
+/* usbdrd_dwc3_1 mode customized in each board */
 
 _0 {
vdd33-supply = <_reg>;
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts 
b/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts
index 9c0cea99c996..379cd61178ee 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts
@@ -18,4 +18,55 @@
 / {
model = "Hardkernel Odroid XU3 Lite";
compatible = "hardkernel,odroid-xu3-lite", "samsung,exynos5800", 
"samsung,exynos5";
+
+   pwmleds {
+   compatible = "pwm-leds";
+
+   greenled {
+   label = "green:mmc0";
+   pwms = < 1 200 0>;
+   pwm-names = "pwm1";
+   /*
+* Green LED is much brighter than the others
+* so limit its max brightness
+*/
+   max_brightness = <127>;
+   linux,default-trigger = "mmc0";
+   };
+
+   blueled {
+   label = "blue:heartbeat";
+   pwms = < 2

[PATCH v2 2/2] ARM: dts: Add exynos5422-odroidxu4 board

2015-09-01 Thread Krzysztof Kozlowski 
Add Hardkernel Odroid XU4 board Device Tree sources. The board differs
from Odroid XU3 and XU3-Lite by:
1. No green and red leds (except standard red power led).
2. No audio codec.
3. Two USB3 ports in host mode (no micro USB3 connector for OTG).
4. Realtek RTL8153-CG gigabit network adapter (instead of SMSC9514).
5. Additional connector with IO ports (I2S_0, I2C_5).
6. No DisplayPort (like XU3-Lite).
7. No TI INA231 power measurement sensors (like XU3-Lite).

Signed-off-by: Krzysztof Kozlowski 

---

Changes since v1:
1. hsi2c_5 and is20 are disabled on Odroid XU4 (after moving these nodes
   to the audio DTSI).
2. Update Samsung's copyright date for XU4 DTS.

I did not add Javier's reviewed-by tag because of splitting audio codec
to separate patch (1/2).
---
 arch/arm/boot/dts/Makefile |  1 +
 arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 51 +-
 arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts| 51 ++
 arch/arm/boot/dts/exynos5422-odroidxu3.dts | 51 ++
 arch/arm/boot/dts/exynos5422-odroidxu4.dts | 48 
 5 files changed, 152 insertions(+), 50 deletions(-)
 create mode 100644 arch/arm/boot/dts/exynos5422-odroidxu4.dts

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 233159d2eaab..3d27fe34647f 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -123,6 +123,7 @@ dtb-$(CONFIG_ARCH_EXYNOS5) += \
exynos5420-smdk5420.dtb \
exynos5422-odroidxu3.dtb \
exynos5422-odroidxu3-lite.dtb \
+   exynos5422-odroidxu4.dtb \
exynos5440-sd5v1.dtb \
exynos5440-ssdk5440.dtb \
exynos5800-peach-pi.dtb
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi 
b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
index 987c15d8ebe5..a83d569baea8 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
@@ -46,40 +46,6 @@
reset-gpios = < 0 1>;
};
 
-   pwmleds {
-   compatible = "pwm-leds";
-
-   greenled {
-   label = "green:mmc0";
-   pwms = < 1 200 0>;
-   pwm-names = "pwm1";
-   /*
-* Green LED is much brighter than the others
-* so limit its max brightness
-*/
-   max_brightness = <127>;
-   linux,default-trigger = "mmc0";
-   };
-
-   blueled {
-   label = "blue:heartbeat";
-   pwms = < 2 200 0>;
-   pwm-names = "pwm2";
-   max_brightness = <255>;
-   linux,default-trigger = "heartbeat";
-   };
-   };
-
-   gpioleds {
-   compatible = "gpio-leds";
-   redled {
-   label = "red:microSD";
-   gpios = < 3 GPIO_ACTIVE_HIGH>;
-   default-state = "off";
-   linux,default-trigger = "mmc1";
-   };
-   };
-
fan0: pwm-fan {
compatible = "pwm-fan";
pwms = < 0 20972 0>;
@@ -417,19 +383,6 @@
};
 };
 
- {
-   /*
-* PWM 0 -- fan
-* PWM 1 -- Green LED
-* PWM 2 -- Blue LED
-* PWM 3 -- on MIPI connector for backlight
-*/
-   pinctrl-0 = <_out _out _out _out>;
-   pinctrl-names = "default";
-   samsung,pwm-outputs = <0>;
-   status = "okay";
-};
-
 _cpu0 {
vtmu-supply = <_reg>;
status = "okay";
@@ -465,9 +418,7 @@
dr_mode = "host";
 };
 
-_dwc3_1 {
-   dr_mode = "otg";
-};
+/* usbdrd_dwc3_1 mode customized in each board */
 
 _0 {
vdd33-supply = <_reg>;
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts 
b/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts
index 9c0cea99c996..379cd61178ee 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3-lite.dts
@@ -18,4 +18,55 @@
 / {
model = "Hardkernel Odroid XU3 Lite";
compatible = "hardkernel,odroid-xu3-lite", "samsung,exynos5800", 
"samsung,exynos5";
+
+   pwmleds {
+   compatible = "pwm-leds";
+
+   greenled {
+   label = "green:mmc0";
+   pwms = < 1 200 0>;
+   pwm-names = "pwm1";
+   /*
+* Green LED is much brighter than the others
+* so limit its max brightness
+*/
+   max_brightness = <127>;
+   linux,default-trigger = "mmc0";
+   };
+
+   blueled {
+   label = "blue:heartbeat";
+