Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes
On Fri, Oct 28, 2016 at 5:34 AM, Leo Yan wrote:
> On Fri, Oct 28, 2016 at 08:52:49PM +0900, Jaehoon Chung wrote:
>
> [...]
>
>> >> Could you check the below thing..
>> >>
>> >> /* find reset controller when exist */
>> >> - pdata->rstc = devm_reset_control_get_optional(dev, NULL);
>> >> + pdata->rstc = devm_reset_control_get_optional(dev, "dwmci-reset");
>> >> if (IS_ERR(pdata->rstc)) {
>> >> if (PTR_ERR(pdata->rstc) == -EPROBE_DEFER)
>> >> return ERR_PTR(-EPROBE_DEFER);
>> >
>> > Confirmed with this fixing, the kernel can bootup successfully.
>> >
>> > Thanks for this.
>>
>> Thanks for checking this..If this approach is not bad, i will send the patch.
>> Or if there are other good approaches, let me know, plz.
>
> I'd like Guodong and John to confirm for Hikey specific. I have no
> knowledge for this so cannot answer.
No objection from me. I hadn't run into the issue, as I'm not booting
off the sd card.
The patch from Jaehoon doesn't seem to cause trouble in my testing so
far, so I think its worth generating a patch and sending it in for
4.9-rc
thanks
-john
Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes
On Fri, Oct 28, 2016 at 08:52:49PM +0900, Jaehoon Chung wrote:
[...]
> >> Could you check the below thing..
> >>
> >> /* find reset controller when exist */
> >> - pdata->rstc = devm_reset_control_get_optional(dev, NULL);
> >> + pdata->rstc = devm_reset_control_get_optional(dev, "dwmci-reset");
> >> if (IS_ERR(pdata->rstc)) {
> >> if (PTR_ERR(pdata->rstc) == -EPROBE_DEFER)
> >> return ERR_PTR(-EPROBE_DEFER);
> >
> > Confirmed with this fixing, the kernel can bootup successfully.
> >
> > Thanks for this.
>
> Thanks for checking this..If this approach is not bad, i will send the patch.
> Or if there are other good approaches, let me know, plz.
I'd like Guodong and John to confirm for Hikey specific. I have no
knowledge for this so cannot answer.
Thanks,
Leo Yan
Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes
Hi,
On 10/28/2016 07:19 PM, Leo Yan wrote:
> On Fri, Oct 28, 2016 at 06:54:58PM +0900, Jaehoon Chung wrote:
>
> [...]
>
> Could you share the log? Is there any log about failure?
Sure, please see below log:
>>>
>>> It's related with -EPROBE_DEFER..I'm not sure but if
>>> CONFIG_RESET_CONTROLLER is enabled, it's searching for reset controller.
>>> Maybe hi6220 has handled the reset controller(?)...
>>>
>>> I'm checking devm_reset_control_xxx...It's possible to occur the other
>>> boards which enabled RESET_CONTROLLER..
>>
>> Could you check the below thing..
>>
>> /* find reset controller when exist */
>> - pdata->rstc = devm_reset_control_get_optional(dev, NULL);
>> + pdata->rstc = devm_reset_control_get_optional(dev, "dwmci-reset");
>> if (IS_ERR(pdata->rstc)) {
>> if (PTR_ERR(pdata->rstc) == -EPROBE_DEFER)
>> return ERR_PTR(-EPROBE_DEFER);
>
> Confirmed with this fixing, the kernel can bootup successfully.
>
> Thanks for this.
Thanks for checking this..If this approach is not bad, i will send the patch.
Or if there are other good approaches, let me know, plz.
Best Regards,
Jaehoon Chung
>
>> To prevent the wrong controlling, how about adding "#reset-names" for dwmmc
>> controller?
>>
>>
>> Best Regards,
>> Jaehoon Chung
>
>
>
Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes
On Fri, Oct 28, 2016 at 06:54:58PM +0900, Jaehoon Chung wrote:
[...]
> >>> Could you share the log? Is there any log about failure?
> >>
> >> Sure, please see below log:
> >
> > It's related with -EPROBE_DEFER..I'm not sure but if
> > CONFIG_RESET_CONTROLLER is enabled, it's searching for reset controller.
> > Maybe hi6220 has handled the reset controller(?)...
> >
> > I'm checking devm_reset_control_xxx...It's possible to occur the other
> > boards which enabled RESET_CONTROLLER..
>
> Could you check the below thing..
>
> /* find reset controller when exist */
> - pdata->rstc = devm_reset_control_get_optional(dev, NULL);
> + pdata->rstc = devm_reset_control_get_optional(dev, "dwmci-reset");
> if (IS_ERR(pdata->rstc)) {
> if (PTR_ERR(pdata->rstc) == -EPROBE_DEFER)
> return ERR_PTR(-EPROBE_DEFER);
Confirmed with this fixing, the kernel can bootup successfully.
Thanks for this.
> To prevent the wrong controlling, how about adding "#reset-names" for dwmmc
> controller?
>
>
> Best Regards,
> Jaehoon Chung
Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes
Hi,
On 10/28/2016 06:43 PM, Jaehoon Chung wrote:
> Hi,
>
> On 10/28/2016 04:38 PM, Leo Yan wrote:
>> On Fri, Oct 28, 2016 at 04:33:41PM +0900, Jaehoon Chung wrote:
>>
>> [...]
>>
>> Guodong: Is there any bootloader dependency on that change?
>
> FYI, I use firmwares available in AOSP
I tried latest firmware [1], still cannot boot up until revert the
patch "arm64: dts: hi6220: add resets property into dwmmc nodes".
>>>
>>> Could you share the log? Is there any log about failure?
>>
>> Sure, please see below log:
>
> It's related with -EPROBE_DEFER..I'm not sure but if CONFIG_RESET_CONTROLLER
> is enabled, it's searching for reset controller.
> Maybe hi6220 has handled the reset controller(?)...
>
> I'm checking devm_reset_control_xxx...It's possible to occur the other boards
> which enabled RESET_CONTROLLER..
Could you check the below thing..
/* find reset controller when exist */
- pdata->rstc = devm_reset_control_get_optional(dev, NULL);
+ pdata->rstc = devm_reset_control_get_optional(dev, "dwmci-reset");
if (IS_ERR(pdata->rstc)) {
if (PTR_ERR(pdata->rstc) == -EPROBE_DEFER)
return ERR_PTR(-EPROBE_DEFER);
To prevent the wrong controlling, how about adding "#reset-names" for dwmmc
controller?
Best Regards,
Jaehoon Chung
>
> Best Regards,
> Jaehoon Chung
>
>>
>> EFI stub: Booting Linux Kernel...
>> EFI stub: Using DTB from configuration table
>> EFI stub: Exiting boot services and installing virtual address map...
>> [0.00] Booting Linux on physical CPU 0x0
>> [0.00] Linux version 4.9.0-rc1-00251-g323792f (leoy@leoy-linaro)
>> (gcc version 4.9.2 20140904 (prerelease) (crosstool-NG
>> linaro-1.13.1-4.9-2014.09 - Linaro GCC 4.9-2014.09) ) #589 SMP PREEMPT Fri
>> Oct 28 15:35:15 CST 2016
>> [0.00] Boot CPU: AArch64 Processor [410fd033]
>> [0.00] efi: Getting EFI parameters from FDT:
>> [0.00] efi: EFI v2.50 by hikey EFI Oct 26 2016 15:14:29
>> [0.00] efi: PROP=0x3d8297d8
>> [0.00] Reserved memory: created CMA memory pool at
>> 0x2d00, size 128 MiB
>> [0.00] OF: reserved mem: initialized node linux,cma, compatible id
>> shared-dma-pool
>> [0.00] psci: probing for conduit method from DT.
>> [0.00] psci: PSCIv1.0 detected in firmware.
>> [0.00] psci: Using standard PSCI v0.2 function IDs
>> [0.00] psci: MIGRATE_INFO_TYPE not supported.
>> [0.00] percpu: Embedded 21 pages/cpu @80003df1 s48000 r8192
>> d29824 u86016
>> [0.00] Detected VIPT I-cache on CPU0
>> [0.00] CPU features: enabling workaround for ARM erratum 845719
>> [0.00] Built 1 zonelists in Zone order, mobility grouping on. Total
>> pages: 249229
>> [0.00] Kernel command line: BOOT_IMAGE=(hd0,gpt6)/Image console=tty0
>> console=ttyAMA3,115200 root=/dev/disk/by-partlabel/system rootwait rw
>> efi=noruntime
>> [0.00] log_buf_len individual max cpu contribution: 4096 bytes
>> [0.00] log_buf_len total cpu_extra contributions: 28672 bytes
>> [0.00] log_buf_len min size: 16384 bytes
>> [0.00] log_buf_len: 65536 bytes
>> [0.00] early log buf free: 14468(88%)
>> [0.00] PID hash table entries: 4096 (order: 3, 32768 bytes)
>> [0.00] Dentry cache hash table entries: 131072 (order: 8, 1048576
>> bytes)
>> [0.00] Inode-cache hash table entries: 65536 (order: 7, 524288 bytes)
>> [0.00] Memory: 841572K/1012788K available (8316K kernel code, 860K
>> rwdata, 3668K rodata, 1024K init, 283K bss, 40144K reserved, 131072K
>> cma-reserved)
>> [0.00] Virtual kernel memory layout:
>> [0.00] modules : 0x - 0x0800 (
>> 128 MB)
>> [0.00] vmalloc : 0x0800 - 0x7dffbfff
>> (129022 GB)
>> [0.00] .text : 0x0808 - 0x088a (
>> 8320 KB)
>> [0.00] .rodata : 0x088a - 0x08c4 (
>> 3712 KB)
>> [0.00] .init : 0x08c4 - 0x08d4 (
>> 1024 KB)
>> [0.00] .data : 0x08d4 - 0x08e17200 (
>> 861 KB)
>> [0.00].bss : 0x08e17200 - 0x08e5e0c0 (
>> 284 KB)
>> [0.00] fixed : 0x7dfffe7fd000 - 0x7dfffec0 (
>> 4108 KB)
>> [0.00] PCI I/O : 0x7dfffee0 - 0x7de0 (
>> 16 MB)
>> [0.00] vmemmap : 0x7e00 - 0x8000 (
>> 2048 GB maximum)
>> [0.00] 0x7e00 - 0x7ef8 (
>> 15 MB actual)
>> [0.00] memory : 0x8000 - 0x80003e00 (
>> 992 MB)
>> [0.00] SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=8, Nodes=1
>> [0.00] Preemptible hierarchical RCU implementation.
>> [0.00] Build-tim
Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes
Hi, On 10/28/2016 04:38 PM, Leo Yan wrote: > On Fri, Oct 28, 2016 at 04:33:41PM +0900, Jaehoon Chung wrote: > > [...] > > Guodong: Is there any bootloader dependency on that change? FYI, I use firmwares available in AOSP >>> >>> I tried latest firmware [1], still cannot boot up until revert the >>> patch "arm64: dts: hi6220: add resets property into dwmmc nodes". >> >> Could you share the log? Is there any log about failure? > > Sure, please see below log: It's related with -EPROBE_DEFER..I'm not sure but if CONFIG_RESET_CONTROLLER is enabled, it's searching for reset controller. Maybe hi6220 has handled the reset controller(?)... I'm checking devm_reset_control_xxx...It's possible to occur the other boards which enabled RESET_CONTROLLER.. Best Regards, Jaehoon Chung > > EFI stub: Booting Linux Kernel... > EFI stub: Using DTB from configuration table > EFI stub: Exiting boot services and installing virtual address map... > [0.00] Booting Linux on physical CPU 0x0 > [0.00] Linux version 4.9.0-rc1-00251-g323792f (leoy@leoy-linaro) (gcc > version 4.9.2 20140904 (prerelease) (crosstool-NG linaro-1.13.1-4.9-2014.09 - > Linaro GCC 4.9-2014.09) ) #589 SMP PREEMPT Fri Oct 28 15:35:15 CST 2016 > [0.00] Boot CPU: AArch64 Processor [410fd033] > [0.00] efi: Getting EFI parameters from FDT: > [0.00] efi: EFI v2.50 by hikey EFI Oct 26 2016 15:14:29 > [0.00] efi: PROP=0x3d8297d8 > [0.00] Reserved memory: created CMA memory pool at > 0x2d00, size 128 MiB > [0.00] OF: reserved mem: initialized node linux,cma, compatible id > shared-dma-pool > [0.00] psci: probing for conduit method from DT. > [0.00] psci: PSCIv1.0 detected in firmware. > [0.00] psci: Using standard PSCI v0.2 function IDs > [0.00] psci: MIGRATE_INFO_TYPE not supported. > [0.00] percpu: Embedded 21 pages/cpu @80003df1 s48000 r8192 > d29824 u86016 > [0.00] Detected VIPT I-cache on CPU0 > [0.00] CPU features: enabling workaround for ARM erratum 845719 > [0.00] Built 1 zonelists in Zone order, mobility grouping on. Total > pages: 249229 > [0.00] Kernel command line: BOOT_IMAGE=(hd0,gpt6)/Image console=tty0 > console=ttyAMA3,115200 root=/dev/disk/by-partlabel/system rootwait rw > efi=noruntime > [0.00] log_buf_len individual max cpu contribution: 4096 bytes > [0.00] log_buf_len total cpu_extra contributions: 28672 bytes > [0.00] log_buf_len min size: 16384 bytes > [0.00] log_buf_len: 65536 bytes > [0.00] early log buf free: 14468(88%) > [0.00] PID hash table entries: 4096 (order: 3, 32768 bytes) > [0.00] Dentry cache hash table entries: 131072 (order: 8, 1048576 > bytes) > [0.00] Inode-cache hash table entries: 65536 (order: 7, 524288 bytes) > [0.00] Memory: 841572K/1012788K available (8316K kernel code, 860K > rwdata, 3668K rodata, 1024K init, 283K bss, 40144K reserved, 131072K > cma-reserved) > [0.00] Virtual kernel memory layout: > [0.00] modules : 0x - 0x0800 ( > 128 MB) > [0.00] vmalloc : 0x0800 - 0x7dffbfff > (129022 GB) > [0.00] .text : 0x0808 - 0x088a ( > 8320 KB) > [0.00] .rodata : 0x088a - 0x08c4 ( > 3712 KB) > [0.00] .init : 0x08c4 - 0x08d4 ( > 1024 KB) > [0.00] .data : 0x08d4 - 0x08e17200 ( > 861 KB) > [0.00].bss : 0x08e17200 - 0x08e5e0c0 ( > 284 KB) > [0.00] fixed : 0x7dfffe7fd000 - 0x7dfffec0 ( > 4108 KB) > [0.00] PCI I/O : 0x7dfffee0 - 0x7de0 ( > 16 MB) > [0.00] vmemmap : 0x7e00 - 0x8000 ( > 2048 GB maximum) > [0.00] 0x7e00 - 0x7ef8 ( > 15 MB actual) > [0.00] memory : 0x8000 - 0x80003e00 ( > 992 MB) > [0.00] SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=8, Nodes=1 > [0.00] Preemptible hierarchical RCU implementation. > [0.00]Build-time adjustment of leaf fanout to 64. > [0.00]RCU restricting CPUs from NR_CPUS=64 to nr_cpu_ids=8. > [0.00] RCU: Adjusting geometry for rcu_fanout_leaf=64, nr_cpu_ids=8 > [0.00] NR_IRQS:64 nr_irqs:64 0 > [0.00] GIC: Using split EOI/Deactivate mode > [0.00] arm_arch_timer: Architected cp15 timer(s) running at 1.20MHz > (phys). > [0.00] clocksource: arch_sys_counter: mask: 0xff > max_cycles: 0x11b661f8e, max_idle_ns: 1763180809113 ns > [0.04] sched_clock: 56 bits at 1200kHz, resolution 833ns, wraps every > 4398046510838ns > [0.000101] clocksource: arm,sp804: mask: 0xff
Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes
Hi, On 10/28/2016 04:26 PM, Leo Yan wrote: > On Fri, Oct 28, 2016 at 08:43:51AM +0200, Vincent Guittot wrote: > > [...] > >>> running with? Also do you have any details about the card in case its >>> card specific? >> >> The sdcard is quite common: sandisk ultra 16GB >> and my rootfs is on the sdcard > > I'm using rootfs in emmc also have same failure. > >>> Guodong: Is there any bootloader dependency on that change? >> >> FYI, I use firmwares available in AOSP > > I tried latest firmware [1], still cannot boot up until revert the > patch "arm64: dts: hi6220: add resets property into dwmmc nodes". Could you share the log? Is there any log about failure? Best Regards, Jaehoon Chung > > [1] > http://builds.96boards.org/snapshots/hikey/linaro/uefi-openplatformpkg/latest/ > > Thanks, > Leo Yan > > >
Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes
On Fri, Oct 28, 2016 at 04:33:41PM +0900, Jaehoon Chung wrote: [...] > >>> Guodong: Is there any bootloader dependency on that change? > >> > >> FYI, I use firmwares available in AOSP > > > > I tried latest firmware [1], still cannot boot up until revert the > > patch "arm64: dts: hi6220: add resets property into dwmmc nodes". > > Could you share the log? Is there any log about failure? Sure, please see below log: EFI stub: Booting Linux Kernel... EFI stub: Using DTB from configuration table EFI stub: Exiting boot services and installing virtual address map... [0.00] Booting Linux on physical CPU 0x0 [0.00] Linux version 4.9.0-rc1-00251-g323792f (leoy@leoy-linaro) (gcc version 4.9.2 20140904 (prerelease) (crosstool-NG linaro-1.13.1-4.9-2014.09 - Linaro GCC 4.9-2014.09) ) #589 SMP PREEMPT Fri Oct 28 15:35:15 CST 2016 [0.00] Boot CPU: AArch64 Processor [410fd033] [0.00] efi: Getting EFI parameters from FDT: [0.00] efi: EFI v2.50 by hikey EFI Oct 26 2016 15:14:29 [0.00] efi: PROP=0x3d8297d8 [0.00] Reserved memory: created CMA memory pool at 0x2d00, size 128 MiB [0.00] OF: reserved mem: initialized node linux,cma, compatible id shared-dma-pool [0.00] psci: probing for conduit method from DT. [0.00] psci: PSCIv1.0 detected in firmware. [0.00] psci: Using standard PSCI v0.2 function IDs [0.00] psci: MIGRATE_INFO_TYPE not supported. [0.00] percpu: Embedded 21 pages/cpu @80003df1 s48000 r8192 d29824 u86016 [0.00] Detected VIPT I-cache on CPU0 [0.00] CPU features: enabling workaround for ARM erratum 845719 [0.00] Built 1 zonelists in Zone order, mobility grouping on. Total pages: 249229 [0.00] Kernel command line: BOOT_IMAGE=(hd0,gpt6)/Image console=tty0 console=ttyAMA3,115200 root=/dev/disk/by-partlabel/system rootwait rw efi=noruntime [0.00] log_buf_len individual max cpu contribution: 4096 bytes [0.00] log_buf_len total cpu_extra contributions: 28672 bytes [0.00] log_buf_len min size: 16384 bytes [0.00] log_buf_len: 65536 bytes [0.00] early log buf free: 14468(88%) [0.00] PID hash table entries: 4096 (order: 3, 32768 bytes) [0.00] Dentry cache hash table entries: 131072 (order: 8, 1048576 bytes) [0.00] Inode-cache hash table entries: 65536 (order: 7, 524288 bytes) [0.00] Memory: 841572K/1012788K available (8316K kernel code, 860K rwdata, 3668K rodata, 1024K init, 283K bss, 40144K reserved, 131072K cma-reserved) [0.00] Virtual kernel memory layout: [0.00] modules : 0x - 0x0800 ( 128 MB) [0.00] vmalloc : 0x0800 - 0x7dffbfff (129022 GB) [0.00] .text : 0x0808 - 0x088a ( 8320 KB) [0.00] .rodata : 0x088a - 0x08c4 ( 3712 KB) [0.00] .init : 0x08c4 - 0x08d4 ( 1024 KB) [0.00] .data : 0x08d4 - 0x08e17200 ( 861 KB) [0.00].bss : 0x08e17200 - 0x08e5e0c0 ( 284 KB) [0.00] fixed : 0x7dfffe7fd000 - 0x7dfffec0 ( 4108 KB) [0.00] PCI I/O : 0x7dfffee0 - 0x7de0 (16 MB) [0.00] vmemmap : 0x7e00 - 0x8000 ( 2048 GB maximum) [0.00] 0x7e00 - 0x7ef8 (15 MB actual) [0.00] memory : 0x8000 - 0x80003e00 ( 992 MB) [0.00] SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=8, Nodes=1 [0.00] Preemptible hierarchical RCU implementation. [0.00] Build-time adjustment of leaf fanout to 64. [0.00] RCU restricting CPUs from NR_CPUS=64 to nr_cpu_ids=8. [0.00] RCU: Adjusting geometry for rcu_fanout_leaf=64, nr_cpu_ids=8 [0.00] NR_IRQS:64 nr_irqs:64 0 [0.00] GIC: Using split EOI/Deactivate mode [0.00] arm_arch_timer: Architected cp15 timer(s) running at 1.20MHz (phys). [0.00] clocksource: arch_sys_counter: mask: 0xff max_cycles: 0x11b661f8e, max_idle_ns: 1763180809113 ns [0.04] sched_clock: 56 bits at 1200kHz, resolution 833ns, wraps every 4398046510838ns [0.000101] clocksource: arm,sp804: mask: 0x max_cycles: 0x, max_idle_ns: 99544814920 ns [0.000108] sched_clock: 32 bits at 19MHz, resolution 52ns, wraps every 111848106981ns [0.000495] Console: colour dummy device 80x25 [0.001193] console [tty0] enabled [0.001224] Calibrating delay loop (skipped), value calculated using timer frequency.. 2.40 BogoMIPS (lpj=4800) [0.001253] pid_max: default: 32768 minimum: 301 [0.001331] Security Framework initialized [0.001373] Mount-cache hash table entries: 2048 (order: 2, 16384 bytes) [0.001392] Mountpoi
Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes
On Fri, Oct 28, 2016 at 08:43:51AM +0200, Vincent Guittot wrote: [...] > > running with? Also do you have any details about the card in case its > > card specific? > > The sdcard is quite common: sandisk ultra 16GB > and my rootfs is on the sdcard I'm using rootfs in emmc also have same failure. > > Guodong: Is there any bootloader dependency on that change? > > FYI, I use firmwares available in AOSP I tried latest firmware [1], still cannot boot up until revert the patch "arm64: dts: hi6220: add resets property into dwmmc nodes". [1] http://builds.96boards.org/snapshots/hikey/linaro/uefi-openplatformpkg/latest/ Thanks, Leo Yan
Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes
On Thu, Oct 27, 2016 at 6:56 AM, Vincent Guittot wrote: > > My hikey board failed to detect and mount sdcard with v4.9-rc1 and i > have bisected the issue to this patch. Once reverted, the sdcard is > detected again. Hrm.. I've not seen this w/ my v4.9-rc2 based tree, and I don't have any mmc patches there. Can you send me your .config and point me to any other patches you're running with? Also do you have any details about the card in case its card specific? Guodong: Is there any bootloader dependency on that change? thanks -john
Re: [PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes
Hi, My hikey board failed to detect and mount sdcard with v4.9-rc1 and i have bisected the issue to this patch. Once reverted, the sdcard is detected again. Regards, Vincent On 25 August 2016 at 05:00, Guodong Xu wrote: > Add resets property into dwmmc_0, dwmmc_1 and dwmmc_2 for hi6220 > > Code and documentation to this property were confirmed by maintainers. > See: > [1] https://patchwork.kernel.org/patch/9276607/ > [2] https://patchwork.kernel.org/patch/8487151/ > [3] https://lkml.org/lkml/2016/8/12/91 > > cc: Jaehoon Chung > cc: Rob Herring > Signed-off-by: Guodong Xu > --- > arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > index d0b887a..63608e9 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > @@ -771,6 +771,7 @@ > interrupts = <0x0 0x48 0x4>; > clocks = <&sys_ctrl 2>, <&sys_ctrl 1>; > clock-names = "ciu", "biu"; > + resets = <&sys_ctrl PERIPH_RSTDIS0_MMC0>; > bus-width = <0x8>; > vmmc-supply = <&ldo19>; > pinctrl-names = "default"; > @@ -790,6 +791,7 @@ > #size-cells = <0x0>; > clocks = <&sys_ctrl 4>, <&sys_ctrl 3>; > clock-names = "ciu", "biu"; > + resets = <&sys_ctrl PERIPH_RSTDIS0_MMC1>; > vqmmc-supply = <&ldo7>; > vmmc-supply = <&ldo10>; > bus-width = <0x4>; > @@ -807,6 +809,7 @@ > interrupts = <0x0 0x4a 0x4>; > clocks = <&sys_ctrl HI6220_MMC2_CIUCLK>, <&sys_ctrl > HI6220_MMC2_CLK>; > clock-names = "ciu", "biu"; > + resets = <&sys_ctrl PERIPH_RSTDIS0_MMC2>; > bus-width = <0x4>; > broken-cd; > pinctrl-names = "default", "idle"; > -- > 1.9.1 > > > ___ > linux-arm-kernel mailing list > linux-arm-ker...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
[PATCH v2 2/2] arm64: dts: hi6220: add resets property into dwmmc nodes
Add resets property into dwmmc_0, dwmmc_1 and dwmmc_2 for hi6220 Code and documentation to this property were confirmed by maintainers. See: [1] https://patchwork.kernel.org/patch/9276607/ [2] https://patchwork.kernel.org/patch/8487151/ [3] https://lkml.org/lkml/2016/8/12/91 cc: Jaehoon Chung cc: Rob Herring Signed-off-by: Guodong Xu --- arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi index d0b887a..63608e9 100644 --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi @@ -771,6 +771,7 @@ interrupts = <0x0 0x48 0x4>; clocks = <&sys_ctrl 2>, <&sys_ctrl 1>; clock-names = "ciu", "biu"; + resets = <&sys_ctrl PERIPH_RSTDIS0_MMC0>; bus-width = <0x8>; vmmc-supply = <&ldo19>; pinctrl-names = "default"; @@ -790,6 +791,7 @@ #size-cells = <0x0>; clocks = <&sys_ctrl 4>, <&sys_ctrl 3>; clock-names = "ciu", "biu"; + resets = <&sys_ctrl PERIPH_RSTDIS0_MMC1>; vqmmc-supply = <&ldo7>; vmmc-supply = <&ldo10>; bus-width = <0x4>; @@ -807,6 +809,7 @@ interrupts = <0x0 0x4a 0x4>; clocks = <&sys_ctrl HI6220_MMC2_CIUCLK>, <&sys_ctrl HI6220_MMC2_CLK>; clock-names = "ciu", "biu"; + resets = <&sys_ctrl PERIPH_RSTDIS0_MMC2>; bus-width = <0x4>; broken-cd; pinctrl-names = "default", "idle"; -- 1.9.1
