Re: [PATCH v2 2/3] dt-bindings: Convert the rockchip power_domain to YAML and extend
Hi, Enric 在 2021/3/24 上午4:58, Enric Balletbo Serra 写道: Hi Elaine, Missatge de Johan Jonker del dia dt., 23 de març 2021 a les 12:06: Hi Elaine, Some comments. Have a look if it's useful or that you disagree with...(part 1) == There is currently already a patch proposal that does the same. Could you read that review history and port the good things to your own patch serie? Re: [PATCH] dt-bindings: power: rockchip: Convert to json-schema https://lore.kernel.org/linux-rockchip/20201007151159.GA221754@bogus/ Re: [PATCH v3] dt-bindings: power: rockchip: Convert to json-schema https://lore.kernel.org/linux-rockchip/20201007151159.GA221754@bogus/ In fact, the latest version is v6 which can be found here: https://patchwork.kernel.org/project/linux-rockchip/patch/20210225102643.653095-1-enric.balle...@collabora.com/ Feel free to integrate and/or improve that version in your series. Thank you for your submission. I will revise the submission on this basis.
Re: [PATCH v2 2/3] dt-bindings: Convert the rockchip power_domain to YAML and extend【请注意,邮件由robherri...@gmail.com代发】
Hi, Rob Herring 在 2021/3/24 上午4:16, Rob Herring 写道: On Tue, 23 Mar 2021 16:24:09 +0800, Elaine Zhang wrote: This converts the rockchip power domain family bindings to YAML schema, and add binding documentation for the power domains found on Rockchip RK3568 SoCs. Signed-off-by: Elaine Zhang --- .../bindings/soc/rockchip/power_domain.txt| 136 - .../rockchip/rockchip,power-controller.yaml | 259 ++ 2 files changed, 259 insertions(+), 136 deletions(-) delete mode 100644 Documentation/devicetree/bindings/soc/rockchip/power_domain.txt create mode 100644 Documentation/devicetree/bindings/soc/rockchip/rockchip,power-controller.yaml My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/soc/rockchip/rockchip,power-controller.example.dts:19:18: fatal error: dt-bindings/clock/rk3568-cru.h: No such file or directory 19 | #include | ^~~~ compilation terminated. make[1]: *** [scripts/Makefile.lib:349: Documentation/devicetree/bindings/soc/rockchip/rockchip,power-controller.example.dt.yaml] Error 1 make: *** [Makefile:1380: dt_binding_check] Error 2 #include This file has been merged, can be seen on the Master branch of Linux-Next. I will rearrange the submission based on this: https://patchwork.kernel.org/project/linux-rockchip/patch/20210225102643.653095-1-enric.balle...@collabora.com/ See https://patchwork.ozlabs.org/patch/1457096 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
Re: [PATCH v2 2/3] dt-bindings: Convert the rockchip power_domain to YAML and extend
Hi Elaine, Missatge de Johan Jonker del dia dt., 23 de març 2021 a les 12:06: > > Hi Elaine, > > Some comments. Have a look if it's useful or that you disagree > with...(part 1) > > == > There is currently already a patch proposal that does the same. > Could you read that review history and port the good things to your own > patch serie? > > Re: [PATCH] dt-bindings: power: rockchip: Convert to json-schema > https://lore.kernel.org/linux-rockchip/20201007151159.GA221754@bogus/ > > Re: [PATCH v3] dt-bindings: power: rockchip: Convert to json-schema > https://lore.kernel.org/linux-rockchip/20201007151159.GA221754@bogus/ > In fact, the latest version is v6 which can be found here: https://patchwork.kernel.org/project/linux-rockchip/patch/20210225102643.653095-1-enric.balle...@collabora.com/ Feel free to integrate and/or improve that version in your series.
Re: [PATCH v2 2/3] dt-bindings: Convert the rockchip power_domain to YAML and extend
On Tue, 23 Mar 2021 16:24:09 +0800, Elaine Zhang wrote: > This converts the rockchip power domain family bindings to YAML schema, > and add binding documentation for the power domains found on Rockchip > RK3568 SoCs. > > Signed-off-by: Elaine Zhang > --- > .../bindings/soc/rockchip/power_domain.txt| 136 - > .../rockchip/rockchip,power-controller.yaml | 259 ++ > 2 files changed, 259 insertions(+), 136 deletions(-) > delete mode 100644 > Documentation/devicetree/bindings/soc/rockchip/power_domain.txt > create mode 100644 > Documentation/devicetree/bindings/soc/rockchip/rockchip,power-controller.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/soc/rockchip/rockchip,power-controller.example.dts:19:18: fatal error: dt-bindings/clock/rk3568-cru.h: No such file or directory 19 | #include | ^~~~ compilation terminated. make[1]: *** [scripts/Makefile.lib:349: Documentation/devicetree/bindings/soc/rockchip/rockchip,power-controller.example.dt.yaml] Error 1 make: *** [Makefile:1380: dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1457096 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
Re: [PATCH v2 2/3] dt-bindings: Convert the rockchip power_domain to YAML and extend
Hi Elaine, Some comments. Have a look if it's useful or that you disagree with...(part 1) == There is currently already a patch proposal that does the same. Could you read that review history and port the good things to your own patch serie? Re: [PATCH] dt-bindings: power: rockchip: Convert to json-schema https://lore.kernel.org/linux-rockchip/20201007151159.GA221754@bogus/ Re: [PATCH v3] dt-bindings: power: rockchip: Convert to json-schema https://lore.kernel.org/linux-rockchip/20201007151159.GA221754@bogus/ == The kernel scripts checks expects that patches still have approx. 79-80 characters per line. Please keep the YAML descriptions max length < 80 and restyle. On 3/23/21 9:24 AM, Elaine Zhang wrote: > This converts the rockchip power domain family bindings to YAML schema, > and add binding documentation for the power domains found on Rockchip > RK3568 SoCs. > > Signed-off-by: Elaine Zhang > --- > .../bindings/soc/rockchip/power_domain.txt| 136 - > .../rockchip/rockchip,power-controller.yaml | 259 ++ > 2 files changed, 259 insertions(+), 136 deletions(-) > delete mode 100644 > Documentation/devicetree/bindings/soc/rockchip/power_domain.txt > create mode 100644 > Documentation/devicetree/bindings/soc/rockchip/rockchip,power-controller.yaml > > diff --git a/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt > b/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt > deleted file mode 100644 > index 8304eceb62e4.. > --- a/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt > +++ /dev/null > @@ -1,136 +0,0 @@ > -* Rockchip Power Domains > - > -Rockchip processors include support for multiple power domains which can be > -powered up/down by software based on different application scenes to save > power. > - > -Required properties for power domain controller: > -- compatible: Should be one of the following. > - "rockchip,px30-power-controller" - for PX30 SoCs. > - "rockchip,rk3036-power-controller" - for RK3036 SoCs. > - "rockchip,rk3066-power-controller" - for RK3066 SoCs. > - "rockchip,rk3128-power-controller" - for RK3128 SoCs. > - "rockchip,rk3188-power-controller" - for RK3188 SoCs. > - "rockchip,rk3228-power-controller" - for RK3228 SoCs. > - "rockchip,rk3288-power-controller" - for RK3288 SoCs. > - "rockchip,rk3328-power-controller" - for RK3328 SoCs. > - "rockchip,rk3366-power-controller" - for RK3366 SoCs. > - "rockchip,rk3368-power-controller" - for RK3368 SoCs. > - "rockchip,rk3399-power-controller" - for RK3399 SoCs. > -- #power-domain-cells: Number of cells in a power-domain specifier. > - Should be 1 for multiple PM domains. > -- #address-cells: Should be 1. > -- #size-cells: Should be 0. > - > -Required properties for power domain sub nodes: > -- reg: index of the power domain, should use macros in: > - "include/dt-bindings/power/px30-power.h" - for PX30 type power domain. > - "include/dt-bindings/power/rk3036-power.h" - for RK3036 type power > domain. > - "include/dt-bindings/power/rk3066-power.h" - for RK3066 type power > domain. > - "include/dt-bindings/power/rk3128-power.h" - for RK3128 type power > domain. > - "include/dt-bindings/power/rk3188-power.h" - for RK3188 type power > domain. > - "include/dt-bindings/power/rk3228-power.h" - for RK3228 type power > domain. > - "include/dt-bindings/power/rk3288-power.h" - for RK3288 type power > domain. > - "include/dt-bindings/power/rk3328-power.h" - for RK3328 type power > domain. > - "include/dt-bindings/power/rk3366-power.h" - for RK3366 type power > domain. > - "include/dt-bindings/power/rk3368-power.h" - for RK3368 type power > domain. > - "include/dt-bindings/power/rk3399-power.h" - for RK3399 type power > domain. > -- clocks (optional): phandles to clocks which need to be enabled while power > domain > - switches state. > -- pm_qos (optional): phandles to qos blocks which need to be saved and > restored > - while power domain switches state. > - > -Qos Example: > - > - qos_gpu: qos_gpu@ffaf { > - compatible ="syscon"; > - reg = <0x0 0xffaf 0x0 0x20>; > - }; > - > -Example: > - > - power: power-controller { > - compatible = "rockchip,rk3288-power-controller"; > - #power-domain-cells = <1>; > - #address-cells = <1>; > - #size-cells = <0>; > - > - pd_gpu { > - reg = ; > - clocks = <&cru ACLK_GPU>; > - pm_qos = <&qos_gpu>; > - }; > - }; > - > - power: power-controller { > -compatible = "rockchip,rk3368-power-controller"; > -#power-domain-cells = <1>; > -#address-cells = <1>; > -#size-cells = <0>; > - > -pd_gpu_1 { > -reg = ; > -
[PATCH v2 2/3] dt-bindings: Convert the rockchip power_domain to YAML and extend
This converts the rockchip power domain family bindings to YAML schema, and add binding documentation for the power domains found on Rockchip RK3568 SoCs. Signed-off-by: Elaine Zhang --- .../bindings/soc/rockchip/power_domain.txt| 136 - .../rockchip/rockchip,power-controller.yaml | 259 ++ 2 files changed, 259 insertions(+), 136 deletions(-) delete mode 100644 Documentation/devicetree/bindings/soc/rockchip/power_domain.txt create mode 100644 Documentation/devicetree/bindings/soc/rockchip/rockchip,power-controller.yaml diff --git a/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt b/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt deleted file mode 100644 index 8304eceb62e4.. --- a/Documentation/devicetree/bindings/soc/rockchip/power_domain.txt +++ /dev/null @@ -1,136 +0,0 @@ -* Rockchip Power Domains - -Rockchip processors include support for multiple power domains which can be -powered up/down by software based on different application scenes to save power. - -Required properties for power domain controller: -- compatible: Should be one of the following. - "rockchip,px30-power-controller" - for PX30 SoCs. - "rockchip,rk3036-power-controller" - for RK3036 SoCs. - "rockchip,rk3066-power-controller" - for RK3066 SoCs. - "rockchip,rk3128-power-controller" - for RK3128 SoCs. - "rockchip,rk3188-power-controller" - for RK3188 SoCs. - "rockchip,rk3228-power-controller" - for RK3228 SoCs. - "rockchip,rk3288-power-controller" - for RK3288 SoCs. - "rockchip,rk3328-power-controller" - for RK3328 SoCs. - "rockchip,rk3366-power-controller" - for RK3366 SoCs. - "rockchip,rk3368-power-controller" - for RK3368 SoCs. - "rockchip,rk3399-power-controller" - for RK3399 SoCs. -- #power-domain-cells: Number of cells in a power-domain specifier. - Should be 1 for multiple PM domains. -- #address-cells: Should be 1. -- #size-cells: Should be 0. - -Required properties for power domain sub nodes: -- reg: index of the power domain, should use macros in: - "include/dt-bindings/power/px30-power.h" - for PX30 type power domain. - "include/dt-bindings/power/rk3036-power.h" - for RK3036 type power domain. - "include/dt-bindings/power/rk3066-power.h" - for RK3066 type power domain. - "include/dt-bindings/power/rk3128-power.h" - for RK3128 type power domain. - "include/dt-bindings/power/rk3188-power.h" - for RK3188 type power domain. - "include/dt-bindings/power/rk3228-power.h" - for RK3228 type power domain. - "include/dt-bindings/power/rk3288-power.h" - for RK3288 type power domain. - "include/dt-bindings/power/rk3328-power.h" - for RK3328 type power domain. - "include/dt-bindings/power/rk3366-power.h" - for RK3366 type power domain. - "include/dt-bindings/power/rk3368-power.h" - for RK3368 type power domain. - "include/dt-bindings/power/rk3399-power.h" - for RK3399 type power domain. -- clocks (optional): phandles to clocks which need to be enabled while power domain - switches state. -- pm_qos (optional): phandles to qos blocks which need to be saved and restored - while power domain switches state. - -Qos Example: - - qos_gpu: qos_gpu@ffaf { - compatible ="syscon"; - reg = <0x0 0xffaf 0x0 0x20>; - }; - -Example: - - power: power-controller { - compatible = "rockchip,rk3288-power-controller"; - #power-domain-cells = <1>; - #address-cells = <1>; - #size-cells = <0>; - - pd_gpu { - reg = ; - clocks = <&cru ACLK_GPU>; - pm_qos = <&qos_gpu>; - }; - }; - -power: power-controller { -compatible = "rockchip,rk3368-power-controller"; -#power-domain-cells = <1>; -#address-cells = <1>; -#size-cells = <0>; - -pd_gpu_1 { -reg = ; -clocks = <&cru ACLK_GPU_CFG>; -}; -}; - -Example 2: - power: power-controller { - compatible = "rockchip,rk3399-power-controller"; - #power-domain-cells = <1>; - #address-cells = <1>; - #size-cells = <0>; - - pd_vio { - #address-cells = <1>; - #size-cells = <0>; - reg = ; - - pd_vo { - #address-cells = <1>; - #size-cells = <0>; - reg = ; - - pd_vopb { - reg = ; -