Re: [PATCH v2 2/7] MIPS: numa: Remove the unused parent_node() macro
Hi Ralf, At 09/01/2017 04:42 PM, Ralf Baechle wrote: On Fri, Sep 01, 2017 at 10:56:34AM +0800, Dou Liyang wrote: Commit a7be6e5a7f8d ("mm: drop useless local parameters of __register_one_node()") removes the last user of parent_node(). The parent_node() macros in both IP27 and Loongson64 are unnecessary. Remove it for cleanup. I already applied v1. Thank you very much. :-) Maybe I missed some message, so I thought it was not yet accepted. please ignore this patch. Thanks, dou Thanks, Ralf
Re: [PATCH v2 2/7] MIPS: numa: Remove the unused parent_node() macro
On Fri, Sep 01, 2017 at 10:56:34AM +0800, Dou Liyang wrote: > Commit a7be6e5a7f8d ("mm: drop useless local parameters of > __register_one_node()") removes the last user of parent_node(). > > The parent_node() macros in both IP27 and Loongson64 are unnecessary. > > Remove it for cleanup. I already applied v1. Thanks, Ralf
[PATCH v2 2/7] MIPS: numa: Remove the unused parent_node() macro
Commit a7be6e5a7f8d ("mm: drop useless local parameters of __register_one_node()") removes the last user of parent_node(). The parent_node() macros in both IP27 and Loongson64 are unnecessary. Remove it for cleanup. Reported-by: Michael Ellerman Signed-off-by: Dou Liyang Cc: Ralf Baechle Cc: James Hogan Cc: linux-m...@linux-mips.org --- arch/mips/include/asm/mach-ip27/topology.h | 1 - arch/mips/include/asm/mach-loongson64/topology.h | 1 - 2 files changed, 2 deletions(-) diff --git a/arch/mips/include/asm/mach-ip27/topology.h b/arch/mips/include/asm/mach-ip27/topology.h index defd135..3fb7a0e 100644 --- a/arch/mips/include/asm/mach-ip27/topology.h +++ b/arch/mips/include/asm/mach-ip27/topology.h @@ -23,7 +23,6 @@ struct cpuinfo_ip27 { extern struct cpuinfo_ip27 sn_cpu_info[NR_CPUS]; #define cpu_to_node(cpu) (sn_cpu_info[(cpu)].p_nodeid) -#define parent_node(node) (node) #define cpumask_of_node(node) ((node) == -1 ? \ cpu_all_mask : \ &hub_data(node)->h_cpus) diff --git a/arch/mips/include/asm/mach-loongson64/topology.h b/arch/mips/include/asm/mach-loongson64/topology.h index 0d8f3b5..bcb8856 100644 --- a/arch/mips/include/asm/mach-loongson64/topology.h +++ b/arch/mips/include/asm/mach-loongson64/topology.h @@ -4,7 +4,6 @@ #ifdef CONFIG_NUMA #define cpu_to_node(cpu) (cpu_logical_map(cpu) >> 2) -#define parent_node(node) (node) #define cpumask_of_node(node) (&__node_data[(node)]->cpumask) struct pci_bus; -- 2.5.5